Removes dev dependencies from generated plugin registrant for non-Android platforms #161828

camsim99 · 2025-01-17T19:56:32Z

Removes dev dependencies from the generated plugin registrants for all platforms since they will be removed from release builds (this was already done for Android, mostly in #161343).

Fixes #161348.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

matanlurey · 2025-01-23T22:55:59Z

So while this technically works, we've now copied over filtering code for each platform, instead of just filtering at the source.

That is, I'd assume just the filtering logic added here:

flutter/packages/flutter_tools/lib/src/flutter_plugins.dart

Line 1228 in 8c4ad50

final List<Plugin> plugins = await findPlugins(project);

If that doesn't work, let's talk about it, because it should (TM).

matanlurey

Needs more work, see comment.

camsim99 · 2025-01-23T23:08:16Z

Fair point. That should work. Note to self that I'll now need to test injectPlugins instead of the various platform classes. Maybe can combine the tests to one singular file then. Maybe

flutter/packages/flutter_tools/test/general.shard/plugins_test.dart

Line 928 in 8c4ad50

group('injectPlugins', () {

…st injectPlugins

matanlurey

Sorry I did not come back to this, but the latest revision LGTM!

auto-submit · 2025-01-30T17:35:25Z

autosubmit label was removed for flutter/flutter/161828, because - The status or check suite Linux_android_emu_34 android views has failed. Please fix the issues identified (or deflake) before re-applying this label.

… non-Android platforms (flutter/flutter#161828)

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

… non-Android platforms (flutter/flutter#161828)

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

is this it?

6291c80

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 17, 2025

add missing arg

f88e3f6

github-actions bot added the a: desktop Running on desktop label Jan 22, 2025

camsim99 added 5 commits January 22, 2025 12:32

Merge remote-tracking branch 'upstream/master' into devdeop_f2

d870fa9

nit

0142faa

add windows test, will do the same for all platforms

df28089

small nits + tests for each platform

1790845

format + analyze

0f8912c

camsim99 requested a review from matanlurey January 23, 2025 22:48

camsim99 marked this pull request as ready for review January 23, 2025 22:49

matanlurey requested changes Jan 23, 2025

View reviewed changes

camsim99 added 4 commits January 24, 2025 07:05

Add base flutter_plugins changes. Need to re-review + fix tests to te…

2b4d223

…st injectPlugins

Finish undoing flutter_plugins test

b29fc82

tests + nits + bug fix

119a2d2

Merge remote-tracking branch 'upstream/master' into devdeop_f2

18118c0

matanlurey approved these changes Jan 30, 2025

View reviewed changes

fix typo

5930a0f

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

auto-submit bot added this pull request to the merge queue Jan 30, 2025

Merged via the queue into flutter:master with commit fffbf66 Jan 30, 2025
140 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

engine-flutter-autoroll mentioned this pull request Jan 30, 2025

Roll Flutter from b007899d3a7a to fffbf663ff34 (19 revisions) flutter/packages#8537

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

b7bb496

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll mentioned this pull request Jan 30, 2025

Roll Flutter from b007899d3a7a to 1eecbf12568d (20 revisions) flutter/packages#8538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

f3afbb8

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

d27a110

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

9d1bd6f

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8547

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

b840f50

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll mentioned this pull request Feb 1, 2025

Roll Flutter from b007899d3a7a to f56d5a98c1da (59 revisions) flutter/packages#8548

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

4121df9

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8549

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

ada7084

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll mentioned this pull request Feb 2, 2025

Roll Flutter from b007899d3a7a to 4d08217f8dca (60 revisions) flutter/packages#8550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

5ce5ccb

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

587ff6a

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll mentioned this pull request Feb 3, 2025

Roll Flutter from b007899d3a7a to 8e2a6fc3fd2c (61 revisions) flutter/packages#8556

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

4617b4c

… non-Android platforms (flutter/flutter#161828)

emakar mentioned this pull request Feb 13, 2025

Patrol is built into a release app, even when it is a dev_dependency leancodepl/patrol#681

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

324d78e

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

be21d8e

… non-Android platforms (flutter/flutter#161828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

fffbf66 Removes dev dependencies from generated plugin registrant for…

32191db

… non-Android platforms (flutter/flutter#161828)

piotruela mentioned this pull request Jun 13, 2025

Revert dynamic ports leancodepl/patrol#2649

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Removes dev dependencies from generated plugin registrant for non-Android platforms #161828

Removes dev dependencies from generated plugin registrant for non-Android platforms #161828

Uh oh!

camsim99 commented Jan 17, 2025 •

edited

Loading

Uh oh!

matanlurey commented Jan 23, 2025

Uh oh!

matanlurey left a comment •

edited

Loading

Uh oh!

camsim99 commented Jan 23, 2025 •

edited

Loading

Uh oh!

matanlurey left a comment

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Removes dev dependencies from generated plugin registrant for non-Android platforms #161828

Removes dev dependencies from generated plugin registrant for non-Android platforms #161828

Uh oh!

Conversation

camsim99 commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

matanlurey commented Jan 23, 2025

Uh oh!

matanlurey left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camsim99 commented Jan 17, 2025 •

edited

Loading

matanlurey left a comment •

edited

Loading

camsim99 commented Jan 23, 2025 •

edited

Loading