Skip to content

Conversation

@yiiim
Copy link
Member

@yiiim yiiim commented Jan 16, 2025

Fixes: #91581

This PR adds an onTapMove event to TapGestureRecognizer, and then CupertinoButton uses this event to implement the behavior of the native iOS UIButton (as shown in the issue). It is worth noting that this PR slightly changes the way CupertinoButton's onPressed is triggered. Specifically, it changes from being triggered by TapGestureRecognizer's onTap to checking if the event position is still above the button in TapGestureRecognizer's onTapUp. Additionally, it removes the previous behavior where the gesture was canceled if moved beyond kScaleSlop (18 logical pixels). Overall, previously, onPressed could not be triggered if the button was pressed and then moved more than 18 pixels. This PR adjusts it so that onPressed cannot be triggered if the button is pressed and then moved outside the button.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. labels Jan 16, 2025
@yiiim yiiim force-pushed the cupertion_button_gesture branch from ceb258b to 560a9ff Compare January 17, 2025 13:36
@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label Jan 17, 2025
@dkwingsmt dkwingsmt self-requested a review January 22, 2025 19:25
@dkwingsmt
Copy link
Contributor

dkwingsmt commented Jan 27, 2025

This is awesome! I'm still reading the code (and it looks great so far) and I have a question: If I understand correctly, only Cupertino uses the tap-move gesture, while other existing code (such as Material) still cancels on movement. How did BaseTapGestureRecognizer distinguish between the two behaviors?

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally great! I think iOS's button behavior is slightly different from the current code (see comments below), but no major issues!

expect(find.text('Copy'), findsOneWidget);
},
variant: TargetPlatformVariant.all(),
variant: TargetPlatformVariant.mobile(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this is changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, maybe just don't do this in this PR. I guess you did it just because this test appears to be relevant only to mobile? But I worry that it could conceal a failure if we make this change in this PR.

}

void _handTapMove(TapMoveDetails event) {
final double distance = switch (defaultTargetPlatform) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit troubled by the duplicate switch statement here and in the unit test. What do you think if we extract this switch statement as a function and replace the kCupertinoButtonTapMoveOpacityChangeDistance constant?

@yiiim
Copy link
Member Author

yiiim commented Feb 7, 2025

Sorry for the delay due to the Chinese New Year holiday.

How did BaseTapGestureRecognizer distinguish between the two behaviors?

BaseTapGestureRecognizer does not care whether onTap or onTapMove is used. However, should this be clarified for the users of the button?

@yiiim yiiim requested a review from dkwingsmt February 7, 2025 08:15
@dkwingsmt
Copy link
Contributor

dkwingsmt commented Feb 7, 2025

The reason why I asked that is because there would be two kinds of behaviors:

  1. Traditional Flutter tap gesture, where moving after tapping down cancels the tap (triggering onTapCancel.
  2. The new iOS gesture, where moving after tapping triggers the onTapMove.

Does your PR keep the first kind for existing widgets, and if so, how?

@yiiim
Copy link
Member Author

yiiim commented Feb 7, 2025

@dkwingsmt In BaseTapGestureRecognizer, the cancellation of the tap gesture is set through postAcceptSlopTolerance. postAcceptSlopTolerance is still retained, but it is set to null in CupertinoButton. This change does not affect BaseTapGestureRecognizer at all. Only CupertinoButton is affected.

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions. Thank you very much!

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions and small changes. I think the only real blockers are the "eyeballed" comment and the question about being a breaking change.

Thanks for the PR! It looks like this required some reworking of the events here that probably wasn't easy, but everything looks very Fluttery and like a good change.

/// The parameter `move` is the move event of the primary pointer that started
/// the tap sequence.
@protected
void handleTapMove({required PointerMoveEvent move});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this possibly be a breaking change for users that implement BaseTapGestureRecognizer? Would it be desirable to add a default implementation here to avoid this, or do we want to break people that implement BaseTapGestureRecognizer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running the Google tests on this PR to check if there are breakages there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently there has been a complaint about we adding such methods breaking packages that implement it. I think it'll help developers if we mention such "non-breaking-by-Flutter-standards" changes, especially "notable new methods" in the patchnotes. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds like a good idea to me. I've seen this kind of thing come up before too.

I think in this case it makes sense to allow users to subtype BaseTapGestureRecognizer, right? And if they are, then do they care about implementing handleTapMove? Maybe not, since I guess they would probably have some specific use case for their subclass that doesn't care about this "tap and move" bug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it makes sense to provide a default implementation in this case too.

String get debugDescription => 'any tap';

@override
void handleTapMove({required PointerMoveEvent move}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you provided a default implementation for handleTapMove, then you wouldn't need this. Not sure if that's good or not though.

expect(find.text('Copy'), findsOneWidget);
},
variant: TargetPlatformVariant.all(),
variant: TargetPlatformVariant.mobile(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, maybe just don't do this in this PR. I guess you did it just because this test appears to be relevant only to mobile? But I worry that it could conceal a failure if we make this change in this PR.

@github-actions github-actions bot removed the f: material design flutter/packages/flutter/material repository. label Feb 20, 2025
@yiiim
Copy link
Member Author

yiiim commented Feb 28, 2025

@dkwingsmt @justinmc Waiting for a new LGTM.

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt requested a review from justinmc February 28, 2025 23:12
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the fixes.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 28, 2025
Merged via the queue into flutter:master with commit 246d6c6 Mar 1, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 2, 2025
Roll Flutter from 2e570ca to 842db35 (59 revisions)

flutter/flutter@2e570ca...842db35

2025-03-02 [email protected] Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449)
2025-03-02 [email protected] Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440)
2025-03-02 [email protected] android: Clean up gen_snapshot artifact build (flutter/flutter#164418)
2025-03-02 [email protected] Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352)
2025-03-01 [email protected] Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410)
2025-03-01 [email protected] Delete unused build archive targets (flutter/flutter#164414)
2025-03-01 [email protected] Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423)
2025-03-01 [email protected] Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413)
2025-03-01 [email protected] Update linux_host_engine.json ci/host_release description (flutter/flutter#164402)
2025-03-01 [email protected] In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395)
2025-03-01 [email protected] Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401)
2025-02-28 [email protected] Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731)
2025-02-28 [email protected] Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404)
2025-02-28 [email protected] [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962)
2025-02-28 [email protected] Add PlatformDispatcher.engineId (flutter/flutter#163476)
2025-02-28 [email protected] Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398)
2025-02-28 [email protected] Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853)
2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396)
2025-02-28 [email protected] Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575)
2025-02-28 [email protected] Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200)
2025-02-28 [email protected] Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380)
2025-02-28 [email protected] [tool] Allow using archiveName in android bundle build (flutter/flutter#162390)
2025-02-28 [email protected] Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101)
2025-02-28 [email protected] Support forward and back buttons (flutter/flutter#164356)
2025-02-28 [email protected] Fix window creation callback for multi-window (flutter/flutter#164353)
2025-02-28 [email protected] Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334)
2025-02-28 [email protected]  Refactor writing of package config in tests (flutter/flutter#163734)
2025-02-28 [email protected] Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996)
2025-02-28 [email protected] Roll pub packages (flutter/flutter#164357)
2025-02-28 [email protected] Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350)
2025-02-28 [email protected] Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351)
2025-02-28 [email protected] Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723)
2025-02-28 [email protected] [Android] Use java for looking up Android API level. (flutter/flutter#163558)
2025-02-28 [email protected] Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317)
2025-02-27 [email protected] Wires up expanded state in web engine (flutter/flutter#164048)
2025-02-27 [email protected] Remove Cheserton's File (flutter/flutter#164340)
2025-02-27 [email protected] Replace update semantics handler with signal. (flutter/flutter#163583)
2025-02-27 [email protected] Split up the conical gradient fragment shader (flutter/flutter#164058)
2025-02-27 [email protected] Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339)
2025-02-27 [email protected] Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324)
2025-02-27 [email protected] Document how `engine.version` (is/will be) computed (flutter/flutter#164335)
2025-02-27 [email protected] Update conductor to write engine.version file (flutter/flutter#163350)
2025-02-27 [email protected] remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198)
2025-02-27 [email protected] Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328)
2025-02-27 [email protected] Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233)
2025-02-27 [email protected] Revert dart sdks that were causing dartaotruntime issues in g3  (flutter/flutter#164307)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
Roll Flutter from 2e570ca to 842db35 (59 revisions)

flutter/flutter@2e570ca...842db35

2025-03-02 [email protected] Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449)
2025-03-02 [email protected] Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440)
2025-03-02 [email protected] android: Clean up gen_snapshot artifact build (flutter/flutter#164418)
2025-03-02 [email protected] Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352)
2025-03-01 [email protected] Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410)
2025-03-01 [email protected] Delete unused build archive targets (flutter/flutter#164414)
2025-03-01 [email protected] Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423)
2025-03-01 [email protected] Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413)
2025-03-01 [email protected] Update linux_host_engine.json ci/host_release description (flutter/flutter#164402)
2025-03-01 [email protected] In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395)
2025-03-01 [email protected] Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401)
2025-02-28 [email protected] Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731)
2025-02-28 [email protected] Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404)
2025-02-28 [email protected] [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962)
2025-02-28 [email protected] Add PlatformDispatcher.engineId (flutter/flutter#163476)
2025-02-28 [email protected] Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398)
2025-02-28 [email protected] Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853)
2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396)
2025-02-28 [email protected] Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575)
2025-02-28 [email protected] Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200)
2025-02-28 [email protected] Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380)
2025-02-28 [email protected] [tool] Allow using archiveName in android bundle build (flutter/flutter#162390)
2025-02-28 [email protected] Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101)
2025-02-28 [email protected] Support forward and back buttons (flutter/flutter#164356)
2025-02-28 [email protected] Fix window creation callback for multi-window (flutter/flutter#164353)
2025-02-28 [email protected] Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334)
2025-02-28 [email protected]  Refactor writing of package config in tests (flutter/flutter#163734)
2025-02-28 [email protected] Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996)
2025-02-28 [email protected] Roll pub packages (flutter/flutter#164357)
2025-02-28 [email protected] Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350)
2025-02-28 [email protected] Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351)
2025-02-28 [email protected] Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723)
2025-02-28 [email protected] [Android] Use java for looking up Android API level. (flutter/flutter#163558)
2025-02-28 [email protected] Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317)
2025-02-27 [email protected] Wires up expanded state in web engine (flutter/flutter#164048)
2025-02-27 [email protected] Remove Cheserton's File (flutter/flutter#164340)
2025-02-27 [email protected] Replace update semantics handler with signal. (flutter/flutter#163583)
2025-02-27 [email protected] Split up the conical gradient fragment shader (flutter/flutter#164058)
2025-02-27 [email protected] Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339)
2025-02-27 [email protected] Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324)
2025-02-27 [email protected] Document how `engine.version` (is/will be) computed (flutter/flutter#164335)
2025-02-27 [email protected] Update conductor to write engine.version file (flutter/flutter#163350)
2025-02-27 [email protected] remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198)
2025-02-27 [email protected] Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328)
2025-02-27 [email protected] Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233)
2025-02-27 [email protected] Revert dart sdks that were causing dartaotruntime issues in g3  (flutter/flutter#164307)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
Roll Flutter from 2e570ca to 842db35 (59 revisions)

flutter/flutter@2e570ca...842db35

2025-03-02 [email protected] Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449)
2025-03-02 [email protected] Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440)
2025-03-02 [email protected] android: Clean up gen_snapshot artifact build (flutter/flutter#164418)
2025-03-02 [email protected] Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352)
2025-03-01 [email protected] Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410)
2025-03-01 [email protected] Delete unused build archive targets (flutter/flutter#164414)
2025-03-01 [email protected] Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423)
2025-03-01 [email protected] Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413)
2025-03-01 [email protected] Update linux_host_engine.json ci/host_release description (flutter/flutter#164402)
2025-03-01 [email protected] In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395)
2025-03-01 [email protected] Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401)
2025-02-28 [email protected] Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731)
2025-02-28 [email protected] Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404)
2025-02-28 [email protected] [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962)
2025-02-28 [email protected] Add PlatformDispatcher.engineId (flutter/flutter#163476)
2025-02-28 [email protected] Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398)
2025-02-28 [email protected] Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853)
2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396)
2025-02-28 [email protected] Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575)
2025-02-28 [email protected] Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200)
2025-02-28 [email protected] Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380)
2025-02-28 [email protected] [tool] Allow using archiveName in android bundle build (flutter/flutter#162390)
2025-02-28 [email protected] Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101)
2025-02-28 [email protected] Support forward and back buttons (flutter/flutter#164356)
2025-02-28 [email protected] Fix window creation callback for multi-window (flutter/flutter#164353)
2025-02-28 [email protected] Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334)
2025-02-28 [email protected]  Refactor writing of package config in tests (flutter/flutter#163734)
2025-02-28 [email protected] Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996)
2025-02-28 [email protected] Roll pub packages (flutter/flutter#164357)
2025-02-28 [email protected] Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350)
2025-02-28 [email protected] Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351)
2025-02-28 [email protected] Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723)
2025-02-28 [email protected] [Android] Use java for looking up Android API level. (flutter/flutter#163558)
2025-02-28 [email protected] Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317)
2025-02-27 [email protected] Wires up expanded state in web engine (flutter/flutter#164048)
2025-02-27 [email protected] Remove Cheserton's File (flutter/flutter#164340)
2025-02-27 [email protected] Replace update semantics handler with signal. (flutter/flutter#163583)
2025-02-27 [email protected] Split up the conical gradient fragment shader (flutter/flutter#164058)
2025-02-27 [email protected] Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339)
2025-02-27 [email protected] Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324)
2025-02-27 [email protected] Document how `engine.version` (is/will be) computed (flutter/flutter#164335)
2025-02-27 [email protected] Update conductor to write engine.version file (flutter/flutter#163350)
2025-02-27 [email protected] remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198)
2025-02-27 [email protected] Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328)
2025-02-27 [email protected] Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233)
2025-02-27 [email protected] Revert dart sdks that were causing dartaotruntime issues in g3  (flutter/flutter#164307)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Cancelling a button press doesn't match native selection behavior

3 participants