Reland "#143249 Autocomplete options width" #161695

victorsanni · 2025-01-15T21:38:15Z

Original PR: #143249
Revert PR: #161666

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

Reland LGTM 👍 . Assuming that a g3fix is added and all checks go green.

…161695)

… delay Same reasoning as in 0bfa79d. This new test was merged in zulip#1266 / 4942f25. At the time, the breaking change in upstream's RawAutocomplete had been reverted, because it broke some Google tests: flutter/flutter#161666 and it had not yet relanded, which is why our CI passed. But the reland happened, in flutter/flutter#161695 , so our test broke; this fixes it.

…161695)

flutter/flutter@5517cc9...b9e86a5 2025-01-18 [email protected] Fix link to Linux custom embedder artifacts (flutter/flutter#161699) 2025-01-18 [email protected] Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786) 2025-01-18 [email protected] [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765) 2025-01-18 [email protected] revert removing Twitter, retain BlueSky (flutter/flutter#161803) 2025-01-17 [email protected] fix reorderable_list_test.dart (flutter/flutter#161836) 2025-01-17 [email protected] [Release] Update the cherry-pick process. (flutter/flutter#161771) 2025-01-17 [email protected] Reland "#143249 Autocomplete options width" (flutter/flutter#161695) 2025-01-17 [email protected] Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781) 2025-01-17 [email protected] [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767) 2025-01-17 [email protected] [Impeller] remove Adreno denylist entries. (flutter/flutter#161740) 2025-01-17 [email protected] Refactor event redispatching (flutter/flutter#161701) 2025-01-17 [email protected] [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697) 2025-01-17 [email protected] Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383) 2025-01-16 [email protected] Make fl_keyboard_manager_handle_event async (flutter/flutter#161637) 2025-01-16 [email protected] Update social links in readme (flutter/flutter#161778) 2025-01-16 [email protected] Remove some stray printf debugging (flutter/flutter#161706) 2025-01-16 [email protected] Set meta tag in default index (flutter/flutter#161493) 2025-01-16 [email protected] remove usage of `Usage` from build system (flutter/flutter#160663) 2025-01-16 [email protected] route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533) 2025-01-16 [email protected] Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613) 2025-01-16 [email protected] Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696) 2025-01-16 [email protected] [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…161695)

flutter/flutter@5517cc9...b9e86a5 2025-01-18 [email protected] Fix link to Linux custom embedder artifacts (flutter/flutter#161699) 2025-01-18 [email protected] Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786) 2025-01-18 [email protected] [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765) 2025-01-18 [email protected] revert removing Twitter, retain BlueSky (flutter/flutter#161803) 2025-01-17 [email protected] fix reorderable_list_test.dart (flutter/flutter#161836) 2025-01-17 [email protected] [Release] Update the cherry-pick process. (flutter/flutter#161771) 2025-01-17 [email protected] Reland "#143249 Autocomplete options width" (flutter/flutter#161695) 2025-01-17 [email protected] Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781) 2025-01-17 [email protected] [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767) 2025-01-17 [email protected] [Impeller] remove Adreno denylist entries. (flutter/flutter#161740) 2025-01-17 [email protected] Refactor event redispatching (flutter/flutter#161701) 2025-01-17 [email protected] [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697) 2025-01-17 [email protected] Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383) 2025-01-16 [email protected] Make fl_keyboard_manager_handle_event async (flutter/flutter#161637) 2025-01-16 [email protected] Update social links in readme (flutter/flutter#161778) 2025-01-16 [email protected] Remove some stray printf debugging (flutter/flutter#161706) 2025-01-16 [email protected] Set meta tag in default index (flutter/flutter#161493) 2025-01-16 [email protected] remove usage of `Usage` from build system (flutter/flutter#160663) 2025-01-16 [email protected] route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533) 2025-01-16 [email protected] Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613) 2025-01-16 [email protected] Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696) 2025-01-16 [email protected] [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reland "Autocomplete options width"

eafea53

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 15, 2025

victorsanni requested review from jacobsimionato and justinmc January 15, 2025 21:38

justinmc approved these changes Jan 16, 2025

View reviewed changes

Merge branch 'master' into autocomplete-options-width

c54b015

justinmc mentioned this pull request Jan 16, 2025

add optionsLayerLink attribute #158417

Closed

Merge branch 'master' into autocomplete-options-width

81cec02

victorsanni added this pull request to the merge queue Jan 17, 2025

Merged via the queue into flutter:master with commit 3297454 Jan 17, 2025
102 checks passed

victorsanni deleted the autocomplete-options-width branch January 17, 2025 08:51

engine-flutter-autoroll mentioned this pull request Jan 17, 2025

Roll Flutter from 5517cc9b3b3b to 329745473284 (16 revisions) flutter/packages#8454

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

a2351e9

…161695)

victorsanni restored the autocomplete-options-width branch January 17, 2025 16:34

engine-flutter-autoroll mentioned this pull request Jan 17, 2025

Roll Flutter from 5517cc9b3b3b to bb2d34126cc8 (17 revisions) flutter/packages#8455

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

fc50b66

…161695)

chrisbobbe mentioned this pull request Jan 17, 2025

CI failing in autocomplete tests with "Finder specifies a widget that would not receive pointer events." zulip/zulip-flutter#1289

Closed

Piinks mentioned this pull request Jan 17, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll mentioned this pull request Jan 18, 2025

Roll Flutter from 5517cc9b3b3b to b9e86a565f92 (22 revisions) flutter/packages#8457

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

7b00c30

…161695)

engine-flutter-autoroll mentioned this pull request Jan 18, 2025

Roll Flutter from 5517cc9b3b3b to b9e86a565f92 (22 revisions) flutter/packages#8458

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

b0e5d67

…161695)

engine-flutter-autoroll mentioned this pull request Jan 19, 2025

Roll Flutter from 5517cc9b3b3b to b9e86a565f92 (22 revisions) flutter/packages#8459

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

322fbce

…161695)

victorsanni mentioned this pull request Jan 21, 2025

set constraints for autocomplete suggestion overlay #157590

Closed

9 tasks

justinmc mentioned this pull request Jan 21, 2025

Autocomplete options overlay should automatically moves up when soft keyboard is visible #157664

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

3e60f84

…161695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

7ec840a

…161695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

3297454 Reland "#143249 Autocomplete options width" (flutter/flutter#…

ef43128

…161695)

victorsanni deleted the autocomplete-options-width branch July 1, 2025 20:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland "#143249 Autocomplete options width" #161695

Reland "#143249 Autocomplete options width" #161695

Uh oh!

victorsanni commented Jan 15, 2025 •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reland "#143249 Autocomplete options width" #161695

Reland "#143249 Autocomplete options width" #161695

Uh oh!

Conversation

victorsanni commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

victorsanni commented Jan 15, 2025 •

edited

Loading