Skip to content

[DisplayList] Migrate from SkRSXform to Impeller RSTransform #161652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jan 15, 2025
Merged

[DisplayList] Migrate from SkRSXform to Impeller RSTransform #161652

auto-submit merged 2 commits into from
Jan 15, 2025

Conversation

@flar
Copy link
Contributor

@flar flar commented Jan 15, 2025 •
edited
Loading

Fixes SkRSXform task in #161456

Removes (nearly) all uses of Skia SkRSXform object from DisplayList and replaces it with a new Impeller RSTransform geometry object.

There are remaining uses in:

  • Skia adapter code which needs to convert them back to SkRSXform when using the Skia backend
  • dl_rendering_tests which is waiting for a major conversion effort
  • ?Fuchsia? code has an SkCanvas spy adapter used in its embedder code (not DisplayList related)
  • web_ui/skwasm

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 15, 2025
@flar flar mentioned this pull request Jan 15, 2025
Open
37 tasks
@flar flar requested a review from jonahwilliams January 15, 2025 11:08
jonahwilliams
jonahwilliams approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 15, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 15, 2025
Merged via the queue into flutter:master with commit a10e25e Jan 15, 2025
183 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 15, 2025
This was referenced Jan 16, 2025
Merged
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
44b17ee 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
df53238 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
544916f 
…lutter/flutter#161652)
This was referenced Jan 16, 2025
Closed
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
0829123 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
0e56124 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
8a59e97 
…lutter/flutter#161652)
This was referenced Jan 16, 2025
Closed
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
7c07665 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
5b1765d 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
6c3ead6 
…lutter/flutter#161652)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 16, 2025
@engine-flutter-autoroll
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (#8441)
973e8b5 
flutter/flutter@40c2b86...5517cc9

2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680)
2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 [email protected] Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643)
2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632)
2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ahmedrasar pushed a commit to ahmedrasar/flutter that referenced this pull request Jan 16, 2025
@flar @ahmedrasar
[DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter…
28482e7 
…#161652)

Fixes SkRSXform task in flutter#161456

Removes (nearly) all uses of Skia SkRSXform object from DisplayList and
replaces it with a new Impeller RSTransform geometry object.

There are remaining uses in:
- Skia adapter code which needs to convert them back to SkRSXform when
using the Skia backend
- dl_rendering_tests which is waiting for a major conversion effort
- ?Fuchsia? code has an SkCanvas spy adapter used in its embedder code
(not DisplayList related)
- web_ui/skwasm
ahmedrasar pushed a commit to ahmedrasar/flutter that referenced this pull request Jan 16, 2025
@flar @ahmedrasar
[DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter…
3fe8868 
…#161652)

Fixes SkRSXform task in flutter#161456

Removes (nearly) all uses of Skia SkRSXform object from DisplayList and
replaces it with a new Impeller RSTransform geometry object.

There are remaining uses in:
- Skia adapter code which needs to convert them back to SkRSXform when
using the Skia backend
- dl_rendering_tests which is waiting for a major conversion effort
- ?Fuchsia? code has an SkCanvas spy adapter used in its embedder code
(not DisplayList related)
- web_ui/skwasm
ahmedrasar pushed a commit to ahmedrasar/flutter that referenced this pull request Jan 16, 2025
@flar @ahmedrasar
[DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter…
c068988 
…#161652)

Fixes SkRSXform task in flutter#161456

Removes (nearly) all uses of Skia SkRSXform object from DisplayList and
replaces it with a new Impeller RSTransform geometry object.

There are remaining uses in:
- Skia adapter code which needs to convert them back to SkRSXform when
using the Skia backend
- dl_rendering_tests which is waiting for a major conversion effort
- ?Fuchsia? code has an SkCanvas spy adapter used in its embedder code
(not DisplayList related)
- web_ui/skwasm
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
124dc86 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
ba76961 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
f327539 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
56c2093 
…lutter/flutter#161652)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
a10e25e [DisplayList] Migrate from SkRSXform to Impeller RSTransform (f…
61e8e1b 
…lutter/flutter#161652)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter#8441)
14e9b88 
flutter/flutter@40c2b86...5517cc9

2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680)
2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 [email protected] Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643)
2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632)
2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter#8441)
84ee9b4 
flutter/flutter@40c2b86...5517cc9

2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680)
2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666)
2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667)
2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652)
2025-01-15 [email protected] Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672)
2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427)
2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609)
2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab`  animation (flutter/flutter#161514)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643)
2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635)
2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632)
2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534)
2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194)
2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025)
2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271)
2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554)
2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622)
2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605)
2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553)
2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409)
2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464)
2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536)
2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562)
2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560)
2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608)
2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343)
2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flar @jonahwilliams