Use wildcards #161548

goderbauer · 2025-01-13T21:32:43Z

https://dart.dev/language/pattern-types#wildcard

goderbauer · 2025-01-13T21:33:15Z

analysis_options.yaml

    - unnecessary_string_interpolations
    - unnecessary_this
    - unnecessary_to_list_in_spreads
+    - unnecessary_underscores


@pq let me know if this lint is too hot of the press and we shouldn't be enforcing it yet.

My hope is it's good to go; feedback is of course totally welcome!

/fyi @kallentu

pq

Woohoo!

auto-submit · 2025-01-13T23:02:25Z

auto label is removed for flutter/flutter/161548, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-14T00:19:05Z

auto label is removed for flutter/flutter/161548, due to - The status or check suite Mac clangd has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux clangd has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux test_ownership has failed. Please fix the issues identified (or deflake) before re-applying this label.

kallentu · 2025-01-14T00:19:37Z

Ohh, yay, love to see it :D

auto-submit · 2025-01-14T00:44:24Z

auto label is removed for flutter/flutter/161548, due to - The status or check suite Windows web_tool_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Windows tool_integration_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_4_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_1_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_android_host_app_with_module_aar has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 hot_mode_dev_cycle_macos_target__benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux android_java17_dependency_smoke_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_integration_tests_6_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_integration_tests_2_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) flutter/flutter@72db8f6...40c2b86 2025-01-14 [email protected] update changelog for 3.27.2 release (flutter/flutter#161569) 2025-01-14 [email protected] Fix `showLicensePage` does not inherit ambient `Theme` (flutter/flutter#161599) 2025-01-14 [email protected] Added special case for fat width arcs (flutter/flutter#161255) 2025-01-14 [email protected] Replace `fetch `with `gclient sync`. (flutter/flutter#161565) 2025-01-14 [email protected] Roll Packages from 3c3bc68 to d1fd623 (4 revisions) (flutter/flutter#161597) 2025-01-14 [email protected] Remove unused method (flutter/flutter#161572) 2025-01-14 [email protected] Fix crash when closing a window with `Alt+F4` in multi-win Flutter on Windows (flutter/flutter#161375) 2025-01-14 [email protected] Update InputDecoration.border documentation (flutter/flutter#161415) 2025-01-14 [email protected] [Web] Allow specifying the strategy on when to use <img> element to display images (flutter/flutter#159917) 2025-01-14 [email protected] Roll Dart to Version 3.7.0-323.0.dev (flutter/flutter#161567) 2025-01-14 [email protected] Use wildcards (flutter/flutter#161548) 2025-01-14 [email protected] Autocomplete Options Width (flutter/flutter#143249) 2025-01-13 [email protected] Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter/flutter#161405) 2025-01-13 [email protected] Remove references to `cirrus`, mostly in doc comments. (flutter/flutter#161529) 2025-01-13 [email protected] Fix paths when running clang-tidy on git diffs (flutter/flutter#161496) 2025-01-13 [email protected] [web:a11y] treat empty tappables as buttons (flutter/flutter#161360) 2025-01-13 [email protected] Add route settings to CupertinoSheetRoute (flutter/flutter#161528) 2025-01-13 [email protected] Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. (flutter/flutter#161532) 2025-01-13 [email protected] Remove last two references to Cirrus CI. (flutter/flutter#161530) 2025-01-13 [email protected] Mark `Mac_mokey microbenchmarks` as flakey (flutter/flutter#161550) 2025-01-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (#160241)" (flutter/flutter#161555) 2025-01-13 [email protected] Add validator execution times to `flutter doctor --verbose` (flutter/flutter#158124) 2025-01-13 [email protected] Explain more specifically how to use `flutter drive`/what it does (flutter/flutter#161450) 2025-01-13 [email protected] Fixed repeated strings for incompatible Gradle or AGP version in `create` command (flutter/flutter#161223) 2025-01-13 [email protected] Remove `WEB_SHARD_COUNT`, which no longer exists post-Cirrus. (flutter/flutter#161527) 2025-01-13 [email protected] [Impeller] Update guidance on prebuilt artifacts. (flutter/flutter#161251) 2025-01-13 [email protected] Migrate DisplayList unit tests to DL/Impeller geometry classes (flutter/flutter#161453) 2025-01-13 [email protected] Context menu button callback docs clarification (flutter/flutter#161451) 2025-01-13 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (flutter/flutter#160241) 2025-01-13 [email protected] Udpate documentation on the third_party directories (flutter/flutter#161407) 2025-01-13 [email protected] Propagate environment variables when `flutter drive` is invoked. (flutter/flutter#161452) 2025-01-13 [email protected] Convert base application name handling to kotlin source (start of FGP kt conversion) (flutter/flutter#155963) 2025-01-13 [email protected] [Impeller] remove API 30 restriction for SurfaceControl testing. (flutter/flutter#161438) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

https://dart.dev/language/pattern-types#wildcard

Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) flutter/flutter@72db8f6...40c2b86 2025-01-14 [email protected] update changelog for 3.27.2 release (flutter/flutter#161569) 2025-01-14 [email protected] Fix `showLicensePage` does not inherit ambient `Theme` (flutter/flutter#161599) 2025-01-14 [email protected] Added special case for fat width arcs (flutter/flutter#161255) 2025-01-14 [email protected] Replace `fetch `with `gclient sync`. (flutter/flutter#161565) 2025-01-14 [email protected] Roll Packages from 3c3bc68 to d1fd623 (4 revisions) (flutter/flutter#161597) 2025-01-14 [email protected] Remove unused method (flutter/flutter#161572) 2025-01-14 [email protected] Fix crash when closing a window with `Alt+F4` in multi-win Flutter on Windows (flutter/flutter#161375) 2025-01-14 [email protected] Update InputDecoration.border documentation (flutter/flutter#161415) 2025-01-14 [email protected] [Web] Allow specifying the strategy on when to use <img> element to display images (flutter/flutter#159917) 2025-01-14 [email protected] Roll Dart to Version 3.7.0-323.0.dev (flutter/flutter#161567) 2025-01-14 [email protected] Use wildcards (flutter/flutter#161548) 2025-01-14 [email protected] Autocomplete Options Width (flutter/flutter#143249) 2025-01-13 [email protected] Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter/flutter#161405) 2025-01-13 [email protected] Remove references to `cirrus`, mostly in doc comments. (flutter/flutter#161529) 2025-01-13 [email protected] Fix paths when running clang-tidy on git diffs (flutter/flutter#161496) 2025-01-13 [email protected] [web:a11y] treat empty tappables as buttons (flutter/flutter#161360) 2025-01-13 [email protected] Add route settings to CupertinoSheetRoute (flutter/flutter#161528) 2025-01-13 [email protected] Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. (flutter/flutter#161532) 2025-01-13 [email protected] Remove last two references to Cirrus CI. (flutter/flutter#161530) 2025-01-13 [email protected] Mark `Mac_mokey microbenchmarks` as flakey (flutter/flutter#161550) 2025-01-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (#160241)" (flutter/flutter#161555) 2025-01-13 [email protected] Add validator execution times to `flutter doctor --verbose` (flutter/flutter#158124) 2025-01-13 [email protected] Explain more specifically how to use `flutter drive`/what it does (flutter/flutter#161450) 2025-01-13 [email protected] Fixed repeated strings for incompatible Gradle or AGP version in `create` command (flutter/flutter#161223) 2025-01-13 [email protected] Remove `WEB_SHARD_COUNT`, which no longer exists post-Cirrus. (flutter/flutter#161527) 2025-01-13 [email protected] [Impeller] Update guidance on prebuilt artifacts. (flutter/flutter#161251) 2025-01-13 [email protected] Migrate DisplayList unit tests to DL/Impeller geometry classes (flutter/flutter#161453) 2025-01-13 [email protected] Context menu button callback docs clarification (flutter/flutter#161451) 2025-01-13 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (flutter/flutter#160241) 2025-01-13 [email protected] Udpate documentation on the third_party directories (flutter/flutter#161407) 2025-01-13 [email protected] Propagate environment variables when `flutter drive` is invoked. (flutter/flutter#161452) 2025-01-13 [email protected] Convert base application name handling to kotlin source (start of FGP kt conversion) (flutter/flutter#155963) 2025-01-13 [email protected] [Impeller] remove API 30 restriction for SurfaceControl testing. (flutter/flutter#161438) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

Use wildcards

024ffb2

goderbauer requested a review from pq January 13, 2025 21:32

goderbauer commented Jan 13, 2025

View reviewed changes

pq approved these changes Jan 13, 2025

View reviewed changes

fix one doc comment

3f2cc94

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2025

fix another doc comment

154849e

github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 13, 2025

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

auto-submit bot added this pull request to the merge queue Jan 14, 2025

Merged via the queue into flutter:master with commit 9cab4ff Jan 14, 2025
183 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to f2c15f9debb2 (27 revisions) flutter/packages#8424

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

359034b

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to c9923ca609cc (28 revisions) flutter/packages#8425

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

6c4eb67

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to ed9f9206629b (29 revisions) flutter/packages#8426

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

1cc710a

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to 40c2b86fdf65 (33 revisions) flutter/packages#8428

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

2971ad5

maheshj01 pushed a commit to maheshj01/flutter that referenced this pull request Jan 15, 2025

Use wildcards (flutter#161548)

175fbd0

https://dart.dev/language/pattern-types#wildcard

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

6a1824a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

c8da429

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

50c96f7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

e4bb5ca

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

9cab4ff Use wildcards (flutter/flutter#161548)

e5e6e85

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use wildcards #161548

Use wildcards #161548

Uh oh!

goderbauer commented Jan 13, 2025

Uh oh!

goderbauer Jan 13, 2025

Uh oh!

pq Jan 13, 2025

Uh oh!

pq left a comment

Uh oh!

auto-submit bot commented Jan 13, 2025

Uh oh!

auto-submit bot commented Jan 14, 2025

Uh oh!

kallentu commented Jan 14, 2025

Uh oh!

auto-submit bot commented Jan 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Use wildcards #161548

Use wildcards #161548

Uh oh!

Conversation

goderbauer commented Jan 13, 2025

Uh oh!

goderbauer Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

pq Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

pq left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 13, 2025

Uh oh!

auto-submit bot commented Jan 14, 2025

Uh oh!

kallentu commented Jan 14, 2025

Uh oh!

auto-submit bot commented Jan 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants