[remake] Restore old back handling for FlutterFragmentActivity #161545

gmackall · 2025-01-13T20:49:30Z

Remake of flutter/engine#56565. Quoting from an old comment, slightly edited:

flutter/engine#52302 seems to have unintentionally had the effect of not allowing people to "opt out" of predictive back. This is actually aligned with what the android docs say should happen:
https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture

Note: OnBackPressedCallback is always called regardless of the value of android:enableOnBackInvokedCallback. In other words, disabling the system animation doesn't affect your app's back handling logic if it uses OnBackPressedCallback.

But this wasn't actually true for flutter apps before flutter/engine#52302, because we were not calling super, and FlutterFragmentActivity extends a FragmentActivity which in turn extends a ComponentActivity, which uses the old onBackPressed to invoke the new back handling:

   override fun onBackPressed() {
        onBackPressedDispatcher.onBackPressed()
    }

So while the docs imply that removing the onBackPressed in FlutterFragmentActivity shouldn't have had an effect, that wasn't true because in our case we were consuming the back event and ignoring the warning

  @Override
  @SuppressWarnings("MissingSuperCall")
  public void onBackPressed() {
    flutterFragment.onBackPressed();
  }

What all this means is that apps that aren't opting in to predictive back had their back handling migrated to the new code path automatically. FlutterFragmentActivity was uniquely is forced into the new back handling codepath by flutter/engine#52302, which this PR fixes.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc · 2025-01-16T19:37:02Z

Is this planned to fix #149753?

kevinhuijsman13 · 2025-01-17T08:39:13Z

When can we expect this to go live?

gmackall · 2025-02-11T22:58:58Z

I was originally planning on adding a test that modifies the manifest value, but I think this current test sufficiently covers the expected behavior (and adding a test that modified the manifest proved more challenging than expected).

ZhuJHua · 2025-02-17T17:36:47Z

Predictive back is enabled by default in Android 15, so when can this pr be merged?

...src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java

auto-submit · 2025-02-20T18:47:29Z

autosubmit label was removed for flutter/flutter/161545, because - The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux android_release_builds_exclude_dev_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-02-20T19:39:00Z

autosubmit label was removed for flutter/flutter/161545, because - The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux android_release_builds_exclude_dev_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter#161545)

kevinhuijsman13 · 2025-02-26T14:34:46Z

Hi @justinmc, when can we expect this to be merged to the stable branch?

flutter/flutter#161545)

Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter#161545)

) Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

remake engine pr, still needs test

a96a3ac

gmackall mentioned this pull request Jan 13, 2025

[wip] Restore old back handling for FlutterFragmentActivity flutter/engine#56565

Closed

8 tasks

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Jan 13, 2025

gmackall and others added 5 commits January 31, 2025 10:05

Merge branch 'master' into remake_predictive_back_breakage_in_framework

f59e6d2

add a test that we forward back calls

4d84da4

format

f921bc4

Merge branch 'master' into remake_predictive_back_breakage_in_framework

6a6d03f

Merge branch 'master' into remake_predictive_back_breakage_in_framework

1a8a7ba

gmackall marked this pull request as ready for review February 11, 2025 22:11

gmackall requested review from a team and justinmc February 11, 2025 22:59

jmagman changed the title ~~[wip][remake] Restore old back handling for FlutterFragmentActivity~~ [remake] Restore old back handling for FlutterFragmentActivity Feb 12, 2025

reidbaker reviewed Feb 18, 2025

View reviewed changes

...src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java Show resolved Hide resolved

reidbaker approved these changes Feb 18, 2025

View reviewed changes

gmackall and others added 2 commits February 20, 2025 09:59

Merge branch 'master' into remake_predictive_back_breakage_in_framework

116e6ad

add comment

a45b423

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025

Merge branch 'master' into remake_predictive_back_breakage_in_framework

0271386

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025

Merge branch 'master' into remake_predictive_back_breakage_in_framework

22e2889

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

d284c00

flutter/flutter#161545)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 641765e283cf (42 revisions) flutter/packages#8699

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

c2a906c

flutter/flutter#161545)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 5a8f23c3dcf0 (43 revisions) flutter/packages#8701

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

23092df

flutter/flutter#161545)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 73b518d0c36e (44 revisions) flutter/packages#8702

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

b9a664e

flutter/flutter#161545)

This was referenced Feb 25, 2025

Roll Flutter from 911aa7547ed7 to be1938aa1cbe (45 revisions) flutter/packages#8703

Closed

Roll Flutter from 911aa7547ed7 to 289993ab8347 (46 revisions) flutter/packages#8704

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

60a2822

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

f47956a

flutter/flutter#161545)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 940fb3c8b1ad (47 revisions) flutter/packages#8705

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

2c4e4e8

flutter/flutter#161545)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 70b7664ba297 (48 revisions) flutter/packages#8706

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

622dcec

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

2115fc8

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

79fe01a

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

6802828

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

bc5f3ea

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

6de3533

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

4660851

flutter/flutter#161545)

engine-flutter-autoroll mentioned this pull request Feb 27, 2025

Manual roll Flutter from 043b71954ce7 to 16592066d70b (19 revisions) flutter/packages#8728

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

5b27a4d

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

5eda940

flutter/flutter#161545)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

7d23780 [remake] Restore old back handling for FlutterFragmentActivity (

b33dca9

flutter/flutter#161545)

FrankenApps mentioned this pull request May 25, 2025

FlutterFragmentActivity support for predictive back #149753

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[remake] Restore old back handling for FlutterFragmentActivity #161545

[remake] Restore old back handling for FlutterFragmentActivity #161545

Uh oh!

gmackall commented Jan 13, 2025 •

edited

Loading

Uh oh!

justinmc commented Jan 16, 2025

Uh oh!

kevinhuijsman13 commented Jan 17, 2025

Uh oh!

gmackall commented Feb 11, 2025

Uh oh!

ZhuJHua commented Feb 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

auto-submit bot commented Feb 20, 2025

Uh oh!

auto-submit bot commented Feb 20, 2025

Uh oh!

kevinhuijsman13 commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[remake] Restore old back handling for FlutterFragmentActivity #161545

[remake] Restore old back handling for FlutterFragmentActivity #161545

Uh oh!

Conversation

gmackall commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

justinmc commented Jan 16, 2025

Uh oh!

kevinhuijsman13 commented Jan 17, 2025

Uh oh!

gmackall commented Feb 11, 2025

Uh oh!

ZhuJHua commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

auto-submit bot commented Feb 20, 2025

Uh oh!

auto-submit bot commented Feb 20, 2025

Uh oh!

kevinhuijsman13 commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gmackall commented Jan 13, 2025 •

edited

Loading

ZhuJHua commented Feb 17, 2025 •

edited

Loading