Set meta tag in default index #161493
Merged
Set meta tag in default index #161493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bootstrapping for the DDC module format and library bundle module format contained a preamble to dynamically set the meta tag to ensure the document is parsed as utf-8. This doesn't work as the page has already been parsed at that point. Instead, it should go in the html directly. The meta tag should not affect the AMD module format, as require.js already ensures any loaded scripts are parsed as utf-8. This tag in general is needed to parse this string correctly: https://github.com/dart-lang/sdk/blob/main/sdk/lib/core/uri.dart#L4100
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
tool
Contributor
Author
|
friendly ping :) |
Contributor
Author
|
Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 19, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 20, 2025
flutter/flutter@5517cc9...b9e86a5 2025-01-18 [email protected] Fix link to Linux custom embedder artifacts (flutter/flutter#161699) 2025-01-18 [email protected] Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786) 2025-01-18 [email protected] [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765) 2025-01-18 [email protected] revert removing Twitter, retain BlueSky (flutter/flutter#161803) 2025-01-17 [email protected] fix reorderable_list_test.dart (flutter/flutter#161836) 2025-01-17 [email protected] [Release] Update the cherry-pick process. (flutter/flutter#161771) 2025-01-17 [email protected] Reland "#143249 Autocomplete options width" (flutter/flutter#161695) 2025-01-17 [email protected] Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781) 2025-01-17 [email protected] [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767) 2025-01-17 [email protected] [Impeller] remove Adreno denylist entries. (flutter/flutter#161740) 2025-01-17 [email protected] Refactor event redispatching (flutter/flutter#161701) 2025-01-17 [email protected] [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697) 2025-01-17 [email protected] Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383) 2025-01-16 [email protected] Make fl_keyboard_manager_handle_event async (flutter/flutter#161637) 2025-01-16 [email protected] Update social links in readme (flutter/flutter#161778) 2025-01-16 [email protected] Remove some stray printf debugging (flutter/flutter#161706) 2025-01-16 [email protected] Set meta tag in default index (flutter/flutter#161493) 2025-01-16 [email protected] remove usage of `Usage` from build system (flutter/flutter#160663) 2025-01-16 [email protected] route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533) 2025-01-16 [email protected] Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613) 2025-01-16 [email protected] Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696) 2025-01-16 [email protected] [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
srujzs
added a commit
to srujzs/flutter
that referenced
this pull request
Jan 23, 2025
- Adds logic to emit newly compiled sources to a file that can be read by the bootstrapper. - Adds bootstrapping logic to reload scripts as needed. This involves implementing the necessary hot restart callback, fetching and processing the emitted file of newly compiled sources, cache busting, and loading the scripts onto the page. A lot of this logic is similar or identical to what we have for internal hot restart support. - Runs existing hot restart tests with the new bundle format. - Adds meta tag to run with utf-8 like in flutter#161493. - Uses DWDS 24.3.3.
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
dart-lang/webdev#2516 dart-lang/webdev#2561 - Adds logic to emit newly compiled sources to a file that can be read by the bootstrapper. - Adds bootstrapping logic to reload scripts as needed. This involves implementing the necessary hot restart callback, fetching and processing the emitted file of newly compiled sources, cache busting, and loading the scripts onto the page. A lot of this logic is similar or identical to what we have for internal hot restart support. - Runs existing hot restart tests with the new bundle format. - Adds meta tag to run with utf-8 like in #161493. - Uses DWDS 24.3.3. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
flutter/flutter@5517cc9...b9e86a5 2025-01-18 [email protected] Fix link to Linux custom embedder artifacts (flutter/flutter#161699) 2025-01-18 [email protected] Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786) 2025-01-18 [email protected] [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765) 2025-01-18 [email protected] revert removing Twitter, retain BlueSky (flutter/flutter#161803) 2025-01-17 [email protected] fix reorderable_list_test.dart (flutter/flutter#161836) 2025-01-17 [email protected] [Release] Update the cherry-pick process. (flutter/flutter#161771) 2025-01-17 [email protected] Reland "#143249 Autocomplete options width" (flutter/flutter#161695) 2025-01-17 [email protected] Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781) 2025-01-17 [email protected] [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767) 2025-01-17 [email protected] [Impeller] remove Adreno denylist entries. (flutter/flutter#161740) 2025-01-17 [email protected] Refactor event redispatching (flutter/flutter#161701) 2025-01-17 [email protected] [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697) 2025-01-17 [email protected] Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383) 2025-01-16 [email protected] Make fl_keyboard_manager_handle_event async (flutter/flutter#161637) 2025-01-16 [email protected] Update social links in readme (flutter/flutter#161778) 2025-01-16 [email protected] Remove some stray printf debugging (flutter/flutter#161706) 2025-01-16 [email protected] Set meta tag in default index (flutter/flutter#161493) 2025-01-16 [email protected] remove usage of `Usage` from build system (flutter/flutter#160663) 2025-01-16 [email protected] route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533) 2025-01-16 [email protected] Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613) 2025-01-16 [email protected] Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696) 2025-01-16 [email protected] [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
flutter/flutter@5517cc9...b9e86a5 2025-01-18 [email protected] Fix link to Linux custom embedder artifacts (flutter/flutter#161699) 2025-01-18 [email protected] Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786) 2025-01-18 [email protected] [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765) 2025-01-18 [email protected] revert removing Twitter, retain BlueSky (flutter/flutter#161803) 2025-01-17 [email protected] fix reorderable_list_test.dart (flutter/flutter#161836) 2025-01-17 [email protected] [Release] Update the cherry-pick process. (flutter/flutter#161771) 2025-01-17 [email protected] Reland "#143249 Autocomplete options width" (flutter/flutter#161695) 2025-01-17 [email protected] Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781) 2025-01-17 [email protected] [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767) 2025-01-17 [email protected] [Impeller] remove Adreno denylist entries. (flutter/flutter#161740) 2025-01-17 [email protected] Refactor event redispatching (flutter/flutter#161701) 2025-01-17 [email protected] [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697) 2025-01-17 [email protected] Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383) 2025-01-16 [email protected] Make fl_keyboard_manager_handle_event async (flutter/flutter#161637) 2025-01-16 [email protected] Update social links in readme (flutter/flutter#161778) 2025-01-16 [email protected] Remove some stray printf debugging (flutter/flutter#161706) 2025-01-16 [email protected] Set meta tag in default index (flutter/flutter#161493) 2025-01-16 [email protected] remove usage of `Usage` from build system (flutter/flutter#160663) 2025-01-16 [email protected] route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533) 2025-01-16 [email protected] Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613) 2025-01-16 [email protected] Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696) 2025-01-16 [email protected] [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootstrapping for the DDC module format and library bundle module format contained a preamble to dynamically set the meta tag to ensure the document is parsed as utf-8. This doesn't work as the page has already been parsed at that point. Instead, it should go in the html directly.
The meta tag should not affect the AMD module format, as require.js already ensures any loaded scripts are parsed as utf-8.
This tag in general is needed to parse this string correctly: https://github.com/dart-lang/sdk/blob/main/sdk/lib/core/uri.dart#L4100
This is a follow-up to PR #161276.
Pre-launch Checklist
///).