Remove Cirrus CI from Flutter goldens. #161396

matanlurey · 2025-01-09T19:30:22Z

I believe this effectively a NOP as the CIRRUS_-environment variables are never set.

Piinks

Ooo love cleaning up tech debt - thank you so much for doing this!

Piinks · 2025-01-09T19:34:58Z

packages/flutter_goldens/lib/flutter_goldens.dart

-    return platform.environment.containsKey('SWARMING_TASK_ID')
-        // Some builds are still being run on Cirrus, we should skip these.
-        ||
-        platform.environment.containsKey('CIRRUS_CI');


This one we might want to keep. This covers other repos that might be running our tests on Cirrus. I think a dart or skia repo might still be using Cirrus, not sure. Happy to remove it if everyone is off Cirrus finally.

The use case here would be a dart repo is running framework tests using Cirrus, but in dart Cirrus CI they cannot affect goldens, so the skipping comparator should be chosen. That way the dart repo does not inadvertently get blocked.

We could try adding a throw StateError(...) and see if anyone complains that CIRRUS_CI is being used?

Or I can leave it one - what is your preference?

Ya know, let's see if we can just remove it. If we can, it's such a nice cleanup.

We'll hear back pretty quick if it breaks someone's CI. We have not been using Cirrus for a really long time, and I have not heard of it being used anymore either.

Piinks

LGTM

Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) flutter/flutter@4b23b81...864d4f5 2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997) 2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998) 2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996) 2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999) 2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000) 2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349) 2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391) 2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392) 2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400) 2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344) 2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404) 2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401) 2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379) 2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246) 2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396) 2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525) 2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394) 2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307) 2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331) 2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276) 2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389) 2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196) 2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567) 2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354) 2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278) 2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347) 2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637) 2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199) 2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342) 2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339) 2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184) 2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287) 2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275) 2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270) 2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109) 2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263) 2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326) 2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978) 2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032) 2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318) 2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277) 2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292) ...

Remove Cirrus CI from Flutter goldens.

9af9008

matanlurey requested a review from Piinks January 9, 2025 19:30

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jan 9, 2025

Piinks reviewed Jan 9, 2025

View reviewed changes

matanlurey requested a review from Piinks January 9, 2025 20:34

Piinks approved these changes Jan 9, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

auto-submit bot added this pull request to the merge queue Jan 9, 2025

Merged via the queue into flutter:master with commit 59f630b Jan 9, 2025
102 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

engine-flutter-autoroll mentioned this pull request Jan 10, 2025

Roll Flutter from 4b23b8182888 to 864d4f59dde0 (50 revisions) flutter/packages#8407

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025

59f630b Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)

ff5e08b

engine-flutter-autoroll mentioned this pull request Jan 10, 2025

Roll Flutter from 4b23b8182888 to 864d4f59dde0 (50 revisions) flutter/packages#8408

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025

59f630b Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)

b3872cf

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

59f630b Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)

3cd83f0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

59f630b Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)

dc5593b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

59f630b Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)

5bbe53c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

59f630b Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)

1c6744e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

59f630b Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)

3d728e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove Cirrus CI from Flutter goldens. #161396

Remove Cirrus CI from Flutter goldens. #161396

Uh oh!

matanlurey commented Jan 9, 2025

Uh oh!

Piinks left a comment

Uh oh!

Piinks Jan 9, 2025

Uh oh!

matanlurey Jan 9, 2025

Uh oh!

Piinks Jan 9, 2025

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Remove Cirrus CI from Flutter goldens. #161396

Remove Cirrus CI from Flutter goldens. #161396

Uh oh!

Conversation

matanlurey commented Jan 9, 2025

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

Piinks Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants