Add a virtual-display (VD) platform view test, and refactor tests a bit. #161349

matanlurey · 2025-01-09T00:37:20Z

Still need to add a HC (Hybrid Composition) variant, but figured I'd do this incrementally to make it easier to review.

jonahwilliams · 2025-01-09T00:53:50Z

...test/test_driver/platform_view/texture_layer_hybrid_composition_platform_view_main_test.dart

@@ -0,0 +1,64 @@
+// Copyright 2014 The Flutter Authors. All rights reserved.


Should this be called virtual display test?

That's the next one, sorry this is the original test!

jonahwilliams · 2025-01-09T00:54:14Z

...s/android_engine_test/test_driver/platform_view/virtual_display_platform_view_main_test.dart

+
+    // Double check that we are really probably testing using Virtual Display.
+    // See https://github.com/flutter/flutter/blob/master/docs/platforms/android/Android-Platform-Views.md.
+    if (await nativeDriver.sdkVersion case final int version when version < 23) {


jonahwilliams

LGTM with nit

auto-submit · 2025-01-09T01:27:10Z

auto label is removed for flutter/flutter/161349, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-09T19:31:54Z

auto label is removed for flutter/flutter/161349, due to - The status or check suite Merge Queue Guard has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-01-10T02:51:16Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #161349 at sha 43a17e9

…ests a bit. (flutter/flutter#161349)

Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) flutter/flutter@4b23b81...864d4f5 2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997) 2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998) 2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996) 2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999) 2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000) 2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349) 2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391) 2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392) 2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400) 2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344) 2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404) 2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401) 2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379) 2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246) 2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396) 2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525) 2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394) 2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307) 2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331) 2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276) 2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389) 2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196) 2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567) 2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354) 2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278) 2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347) 2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637) 2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199) 2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342) 2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339) 2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184) 2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287) 2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275) 2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270) 2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109) 2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263) 2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326) 2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978) 2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032) 2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318) 2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277) 2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292) ...

…ests a bit. (flutter/flutter#161349)

Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) flutter/flutter@4b23b81...864d4f5 2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997) 2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998) 2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996) 2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999) 2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000) 2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349) 2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391) 2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392) 2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400) 2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344) 2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404) 2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401) 2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379) 2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246) 2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396) 2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525) 2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394) 2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307) 2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331) 2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276) 2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389) 2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196) 2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567) 2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354) 2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353) 2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278) 2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347) 2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637) 2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199) 2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342) 2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339) 2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184) 2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287) 2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275) 2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270) 2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109) 2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263) 2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326) 2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978) 2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032) 2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302) 2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318) 2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277) 2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292) ...

Add a virtual-display platform view test, and refactor tests a bit.

a151363

matanlurey requested a review from jonahwilliams January 9, 2025 00:37

github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Jan 9, 2025

jonahwilliams reviewed Jan 9, 2025

View reviewed changes

jonahwilliams approved these changes Jan 9, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

Lint.

a179a10

matanlurey mentioned this pull request Jan 9, 2025

Run android_engine_test explicitly with both OpenGLES and Vulkan backends #161355

Closed

github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Jan 9, 2025

Run ktlint.

59ddeb4

matanlurey force-pushed the add-virtual-display-test branch from 27bdeb9 to 59ddeb4 Compare January 9, 2025 18:01

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025

master -> main.

a0e4e41

matanlurey force-pushed the add-virtual-display-test branch from d4e81c2 to a0e4e41 Compare January 9, 2025 22:22

Format.

43a17e9

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 10, 2025

matanlurey added this pull request to the merge queue Jan 10, 2025

Merged via the queue into flutter:master with commit 89b3361 Jan 10, 2025
174 of 175 checks passed

matanlurey deleted the add-virtual-display-test branch January 10, 2025 04:50

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2025

engine-flutter-autoroll mentioned this pull request Jan 10, 2025

Roll Flutter from 4b23b8182888 to 864d4f59dde0 (50 revisions) flutter/packages#8407

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025

89b3361 Add a virtual-display (VD) platform view test, and refactor t…

5901a92

…ests a bit. (flutter/flutter#161349)

engine-flutter-autoroll mentioned this pull request Jan 10, 2025

Roll Flutter from 4b23b8182888 to 864d4f59dde0 (50 revisions) flutter/packages#8408

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025

89b3361 Add a virtual-display (VD) platform view test, and refactor t…

ccaa36a

…ests a bit. (flutter/flutter#161349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

89b3361 Add a virtual-display (VD) platform view test, and refactor t…

73949a0

…ests a bit. (flutter/flutter#161349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

89b3361 Add a virtual-display (VD) platform view test, and refactor t…

10d8fb5

…ests a bit. (flutter/flutter#161349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

89b3361 Add a virtual-display (VD) platform view test, and refactor t…

410e9d7

…ests a bit. (flutter/flutter#161349)

BakerSmithA mentioned this pull request Feb 19, 2025

[Web] Cannot enter any text into Payment Element on Safari flutter-stripe/flutter_stripe#2081

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

89b3361 Add a virtual-display (VD) platform view test, and refactor t…

7ef1bdb

…ests a bit. (flutter/flutter#161349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

89b3361 Add a virtual-display (VD) platform view test, and refactor t…

2be0acb

…ests a bit. (flutter/flutter#161349)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a virtual-display (VD) platform view test, and refactor tests a bit. #161349

Add a virtual-display (VD) platform view test, and refactor tests a bit. #161349

Uh oh!

matanlurey commented Jan 9, 2025

Uh oh!

jonahwilliams Jan 9, 2025

Uh oh!

matanlurey Jan 9, 2025

Uh oh!

jonahwilliams Jan 9, 2025

Uh oh!

jonahwilliams Jan 9, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit bot commented Jan 9, 2025

Uh oh!

auto-submit bot commented Jan 9, 2025

Uh oh!

flutter-dashboard bot commented Jan 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,64 @@
		// Copyright 2014 The Flutter Authors. All rights reserved.

Add a virtual-display (VD) platform view test, and refactor tests a bit. #161349

Add a virtual-display (VD) platform view test, and refactor tests a bit. #161349

Uh oh!

Conversation

matanlurey commented Jan 9, 2025

Uh oh!

jonahwilliams Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 9, 2025

Uh oh!

auto-submit bot commented Jan 9, 2025

Uh oh!

flutter-dashboard bot commented Jan 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants