Skip to content

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jan 7, 2025

This turns on Swift Package Manager by default:

  1. New apps will have Swift Package Manager integration
  2. New plugins will support Swift Package Manager
  3. Existing apps will continue to use CocoaPods. They can migrate to SwiftPM using flutter config --enable-swift-package-manager-migration.

See this mini design doc: #151567 (comment)

Here's the PR that updates the SwiftPM docs: flutter/website#11495

Part of #151567

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 7, 2025
await flutter(
'config',
options: <String>['--no-enable-swift-package-manager'],
);
Copy link
Member Author

@loic-sharma loic-sharma Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin_lint_mac test checks that plugins pass CocoaPods lints and that Flutter's CocoaPods integration works as expected.

These tests are very CocoaPods specific and don't make sense for Swift Package Manager.

These tests should continue to use CocoaPods even if Swift Package Manager is on by default.

@loic-sharma loic-sharma marked this pull request as ready for review January 7, 2025 23:34
@loic-sharma loic-sharma mentioned this pull request Jan 8, 2025
9 tasks
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 8, 2025
Merged via the queue into flutter:master with commit d8c4fc0 Jan 8, 2025
174 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2025
@loic-sharma
Copy link
Member Author

Reason for revert: failing post submit check `build_ios_framework_module_test

[2025-01-08 14:19:48.853336] [STDOUT] stdout:            ** BUILD SUCCEEDED **
[2025-01-08 14:19:50.360684] [STDOUT] stdout: [+1522 ms]  ├─Building plugins... (completed in 4.8s)
[2025-01-08 14:19:50.360824] [STDOUT] stdout: [        ]  └─Moving to flutter-frameworks/Debug
[2025-01-08 14:19:50.398470] [STDOUT] stdout: [  +37 ms]  └─Moving to flutter-frameworks/Debug (completed in 37ms)
[2025-01-08 14:19:50.399368] [STDOUT] stdout: [   +1 ms] executing: [/Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/] /usr/bin/arch -arm64e xcrun xcodebuild -list
[2025-01-08 14:19:52.115397] [STDOUT] stdout: [+1715 ms] Command line invocation:
[2025-01-08 14:19:52.115416] [STDOUT] stdout:                /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/usr/bin/xcodebuild -list
[2025-01-08 14:19:52.115420] [STDOUT] stdout: 
[2025-01-08 14:19:52.115422] [STDOUT] stdout:            User defaults from command line:
[2025-01-08 14:19:52.115425] [STDOUT] stdout:                IDEPackageSupportUseBuiltinSCM = YES
[2025-01-08 14:19:52.115428] [STDOUT] stdout: 
[2025-01-08 14:19:52.115430] [STDOUT] stdout:            Resolve Package Graph
[2025-01-08 14:19:52.115440] [STDOUT] stdout:            the package manifest at '/Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift' cannot be accessed (/Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift doesn't exist in file system)
[2025-01-08 14:19:52.115443] [STDOUT] stdout: 
[2025-01-08 14:19:52.115445] [STDOUT] stdout:            Resolved source packages:
[2025-01-08 14:19:52.115448] [STDOUT] stdout:              FlutterGeneratedPluginSwiftPackage: /Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage @ local
[2025-01-08 14:19:52.115451] [STDOUT] stdout: 
[2025-01-08 14:19:52.115453] [STDOUT] stdout: 
[2025-01-08 14:19:52.115459] [STDOUT] stdout:            2025-01-08 14:19:50.937 xcodebuild[61498:263773] Writing error result bundle to /var/folders/74/_q1p0s0n13sggz3lw759sfr80000gp/T/ResultBundle_2025-08-01_14-19-0050.xcresult
[2025-01-08 14:19:52.115462] [STDOUT] stdout:            xcodebuild: error: Could not resolve package dependencies:
[2025-01-08 14:19:52.115465] [STDOUT] stdout:              the package manifest at '/Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift' cannot be accessed (/Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift doesn't exist in file system)
[2025-01-08 14:19:52.116931] [STDOUT] stdout: [   +1 ms] "flutter ios-framework" took 18,968ms.
[2025-01-08 14:19:52.118651] [STDOUT] stderr: [   +1 ms] Unable to get Xcode project information:
[2025-01-08 14:19:52.118672] [STDOUT] stderr:             2025-01-08 14:19:50.937 xcodebuild[61498:263773] Writing error result bundle to /var/folders/74/_q1p0s0n13sggz3lw759sfr80000gp/T/ResultBundle_2025-08-01_14-19-0050.xcresult
[2025-01-08 14:19:52.118676] [STDOUT] stderr:            xcodebuild: error: Could not resolve package dependencies:
[2025-01-08 14:19:52.118734] [STDOUT] stderr:              the package manifest at '/Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift' cannot be accessed (/Volumes/Work/s/w/ir/x/t/flutter_module_test.AhsaKp/hello_project/ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift doesn't exist in file system)
[2025-01-08 14:19:52.118741] [STDOUT] stderr: 
[2025-01-08 14:19:52.118744] [STDOUT] stderr: 
[2025-01-08 14:19:52.118866] [STDOUT] stderr: [        ] 
[2025-01-08 14:19:52.118870] [STDOUT] stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:34:3)
[2025-01-08 14:19:52.118873] [STDOUT] stderr:            #1      XcodeProjectInterpreter.getInfo (package:flutter_tools/src/ios/xcodeproj.dart:365:7)
[2025-01-08 14:19:52.118875] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.118878] [STDOUT] stderr:            #2      XcodeBasedProject.projectInfo (package:flutter_tools/src/xcode_project.dart:204:29)
[2025-01-08 14:19:52.118881] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.118883] [STDOUT] stderr:            #3      IosProject.productBundleIdentifier (package:flutter_tools/src/xcode_project.dart:439:36)
[2025-01-08 14:19:52.118886] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.118888] [STDOUT] stderr:            #4      BuildIOSFrameworkCommand.runCommand (package:flutter_tools/src/commands/build_ios_framework.dart:261:47)
[2025-01-08 14:19:52.118890] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.118893] [STDOUT] stderr:            #5      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1558:27)
[2025-01-08 14:19:52.118901] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.118903] [STDOUT] stderr:            #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
[2025-01-08 14:19:52.118960] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.119019] [STDOUT] stderr:            #7      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
[2025-01-08 14:19:52.119104] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.119115] [STDOUT] stderr:            #8      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:496:9)
[2025-01-08 14:19:52.119119] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.119121] [STDOUT] stderr:            #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
[2025-01-08 14:19:52.119124] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.119126] [STDOUT] stderr:            #10     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:431:5)
[2025-01-08 14:19:52.119129] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.119131] [STDOUT] stderr:            #11     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:98:11)
[2025-01-08 14:19:52.119133] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.119136] [STDOUT] stderr:            #12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
[2025-01-08 14:19:52.119138] [STDOUT] stderr:            <asynchronous suspension>
[2025-01-08 14:19:52.119140] [STDOUT] stderr:            #13     main (package:flutter_tools/executable.dart:99:3)
[2025-01-08 14:19:52.119143] [STDOUT] stderr:            <asynchronous suspension>

@loic-sharma loic-sharma added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 8, 2025
auto-submit bot pushed a commit that referenced this pull request Jan 8, 2025
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2025
<!-- start_original_pr_link -->
Reverts: #161275
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: failing post submit check
`[build_ios_framework_module_test](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20build_ios_framework_module_test)

```
[2025-01-08 14:19:48.853336] [STDOUT] stdout:            ** BUILD SUCCEEDED **
[2025-01-08 14:19:50.360684] [STDOUT] stdout: [+1522 ms]  ├─Building plugins... (completed in 4.8s)
[2025-01-08 14:19:50.360824] [STDOUT] stdout: [       
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: loic-sharma
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {cbracken, vashworth, jmagman}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This turns on Swift Package Manager by default:

1. New apps will have Swift Package Manager integration
2. New plugins will support Swift Package Manager
3. Existing apps will continue to use CocoaPods. They can migrate to SwiftPM using `flutter config --enable-swift-package-manager-migration`.

See this mini design doc: #151567 (comment)

Here's the PR that updates the SwiftPM docs: flutter/website#11495

Part of #151567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

<!-- Links -->
[Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2025
…58897)" (#161342)

This reverts #158897 (commit
e7a1b68) as it is intended to be in the
same release as #161275.

However, #161275 had to be
reverted and won't be relanded until after the release cutoff. Hence,
I'm reverting this as well.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 11, 2025
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions)

flutter/flutter@4b23b81...864d4f5

2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997)
2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998)
2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996)
2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999)
2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000)
2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349)
2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391)
2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392)
2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400)
2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344)
2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404)
2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401)
2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379)
2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246)
2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)
2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525)
2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394)
2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307)
2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331)
2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276)
2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389)
2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196)
2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567)
2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354)
2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278)
2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347)
2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637)
2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199)
2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342)
2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339)
2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184)
2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287)
2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275)
2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270)
2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109)
2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263)
2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326)
2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978)
2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032)
2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318)
2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277)
2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292)
...
srujzs pushed a commit to srujzs/flutter that referenced this pull request Jan 12, 2025
This turns on Swift Package Manager by default:

1. New apps will have Swift Package Manager integration
2. New plugins will support Swift Package Manager
3. Existing apps will continue to use CocoaPods. They can migrate to
SwiftPM using `flutter config --enable-swift-package-manager-migration`.

See this mini design doc:
flutter#151567 (comment)

Here's the PR that updates the SwiftPM docs:
flutter/website#11495

Part of flutter#151567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
srujzs pushed a commit to srujzs/flutter that referenced this pull request Jan 12, 2025
<!-- start_original_pr_link -->
Reverts: flutter#161275
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: failing post submit check
`[build_ios_framework_module_test](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20build_ios_framework_module_test)

```
[2025-01-08 14:19:48.853336] [STDOUT] stdout:            ** BUILD SUCCEEDED **
[2025-01-08 14:19:50.360684] [STDOUT] stdout: [+1522 ms]  ├─Building plugins... (completed in 4.8s)
[2025-01-08 14:19:50.360824] [STDOUT] stdout: [       
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: loic-sharma
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {cbracken, vashworth, jmagman}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This turns on Swift Package Manager by default:

1. New apps will have Swift Package Manager integration
2. New plugins will support Swift Package Manager
3. Existing apps will continue to use CocoaPods. They can migrate to SwiftPM using `flutter config --enable-swift-package-manager-migration`.

See this mini design doc: flutter#151567 (comment)

Here's the PR that updates the SwiftPM docs: flutter/website#11495

Part of flutter#151567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

<!-- Links -->
[Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
@loic-sharma loic-sharma mentioned this pull request Jan 14, 2025
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions)

flutter/flutter@4b23b81...864d4f5

2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997)
2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998)
2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996)
2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999)
2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000)
2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349)
2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391)
2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392)
2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400)
2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344)
2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404)
2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401)
2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379)
2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246)
2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)
2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525)
2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394)
2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307)
2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331)
2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276)
2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389)
2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196)
2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567)
2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354)
2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278)
2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347)
2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637)
2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199)
2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342)
2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339)
2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184)
2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287)
2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275)
2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270)
2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109)
2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263)
2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326)
2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978)
2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032)
2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318)
2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277)
2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions)

flutter/flutter@4b23b81...864d4f5

2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997)
2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998)
2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996)
2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999)
2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000)
2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349)
2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391)
2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392)
2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400)
2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344)
2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404)
2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401)
2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379)
2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246)
2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)
2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525)
2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394)
2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307)
2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331)
2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276)
2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389)
2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196)
2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567)
2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354)
2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278)
2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347)
2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637)
2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199)
2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342)
2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339)
2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184)
2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287)
2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275)
2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270)
2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109)
2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263)
2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326)
2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978)
2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032)
2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318)
2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277)
2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants