Fixed XiaoMi statusBar Bug #161271

jesswrd · 2025-01-07T22:22:43Z

Updated usages of statusBar() to systemBar() to fix XiaoMi statusBar bug.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

reidbaker · 2025-01-08T15:33:17Z

Looking at this documentation here again the difference is that systemBars does not include ime https://developer.android.com/reference/android/view/WindowInsets.Type#ime()

I think our code might actually be correct in that we want input types as well. Is it possible to verify that this change actually fixes the issue the XiaoMi user was seeing? My first past on the documentation makes me think this cant add any inset that would allow us to inset correctly.

reidbaker · 2025-01-08T15:25:08Z

engine/src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java

      if (navigationBarVisible) {
        mask = mask | android.view.WindowInsets.Type.navigationBars();
      }
      if (statusBarVisible) {


Consider renaming this variable

deleted the masking code and used systemBars instead

reidbaker · 2025-01-08T15:26:59Z

...ne/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java

            .setInsets(
                android.view.WindowInsets.Type.navigationBars()
-                    | android.view.WindowInsets.Type.statusBars(),
+                    | android.view.WindowInsets.Type.systemBars(),


Should we add a test that sets the statusbars insets to something other than 100. To make sure we are using systemBars instead of status bars?

reidbaker · 2025-01-09T16:58:31Z

Looking at this documentation here again the difference is that systemBars does not include ime https://developer.android.com/reference/android/view/WindowInsets.Type#ime()

I think our code might actually be correct in that we want input types as well. Is it possible to verify that this change actually fixes the issue the XiaoMi user was seeing? My first past on the documentation makes me think this cant add any inset that would allow us to inset correctly.

@jesswrd and I looked at this yesterday. An internal doc states that to support edge to edge we need to move usage of statusBars to systemBars so that is what we will do. There is code that handles status bars only if they are visible and a straight replacement would invalidate some of that code so @jesswrd is going to add tests for that behavior and we are going to make sure we dont regress a non full screen inset logic when we fix the support for xiaomi (which is a broader bug impacting more devices but this gave us an easy to reproduce case).

I believe the actual code level issue is not including systemOverlays.

reidbaker · 2025-01-14T15:53:42Z

...ne/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java

+  // getSystemUiVisibility
+  // This test uses the API 30+ Algorithm for window insets. This test requires API 34 or
+  // higher to use the systemOverlays inset. The legacy algorithm is
+  // set to -1 values, so it is clear if the wrong algorithm is used.


Great comment helping explain the test!

reidbaker · 2025-01-14T15:54:18Z

...ne/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java

+  // set to -1 values, so it is clear if the wrong algorithm is used.
+  @Test
+  @TargetApi(34)
+  @Config(sdk = 34)


I think you want this to be minSdk instead of sdk so that it run against api 35 and beyond.

reidbaker · 2025-01-14T15:55:37Z

...ne/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java

+    FlutterRenderer flutterRenderer = spy(new FlutterRenderer(mockFlutterJni));
+    when(flutterEngine.getRenderer()).thenReturn(flutterRenderer);
+
+    // When we attach a new FlutterView to the engine without any system insets, the viewport


I think this comment should probably move to line 357 where we verify top is zero.

reidbaker · 2025-01-14T15:57:20Z

...ne/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java

+
+    // Verify.
+    verify(flutterRenderer, times(3)).setViewportMetrics(viewportMetricsCaptor.capture());
+    // Confirm that the statusBar inset is used because it is greater.


greater -> largest of the insets faked.
or
larger than captionBar

reidbaker · 2025-01-14T15:58:47Z

...ne/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java

+    WindowInsets navigationBarwindowInsets =
+        new WindowInsets.Builder()
+            .setInsets(android.view.WindowInsets.Type.navigationBars(), Insets.of(0, 0, 0, 10))
+            .setInsets(android.view.WindowInsets.Type.navigationBars(), Insets.of(0, 0, 0, 50))


Why use navigationBars twice?

an accident meant to use systemOverlays() thanks for catching it! done

reidbaker · 2025-01-14T15:59:47Z

...ne/src/flutter/shell/platform/android/test/io/flutter/embedding/android/FlutterViewTest.java

+    validateViewportMetricPadding(viewportMetricsCaptor, 0, 100, 0, 0);
+    clearInvocations(flutterRenderer);
+
+    // Then we simulate the system applying a window inset.


I am not sure this comment has value my guess is this is a copy paste.

Remove it or make it valuable like "Then simulate the system applying a navigationbar inset."

Here and below

flutter/flutter@40c2b86...5517cc9 2025-01-15 [email protected] feat: Change default value of keyboardDismissBehavior (flutter/flutter#158580) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161680) 2025-01-15 [email protected] Revert "Autocomplete Options Width" (flutter/flutter#161666) 2025-01-15 [email protected] Update two_dimensional_scrollables triage routing (flutter/flutter#161667) 2025-01-15 [email protected] [DisplayList] Migrate from SkRSXform to Impeller RSTransform (flutter/flutter#161652) 2025-01-15 [email protected] Roll Packages from d1fd623 to f73cb00 (2 revisions) (flutter/flutter#161672) 2025-01-15 [email protected] Fix DropdownMenu isCollapsed decoration does not Reduce height (flutter/flutter#161427) 2025-01-15 [email protected] Manual roll of Skia to e7b8d078851f (flutter/flutter#161609) 2025-01-15 [email protected] Fix `TabBar` glitchy elastic `Tab` animation (flutter/flutter#161514) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161643) 2025-01-15 [email protected] Exclude the top-level `engine` directory from `generate_gradle_lockfiles`. (flutter/flutter#161635) 2025-01-15 [email protected] Roll pub packages (flutter/flutter#161632) 2025-01-15 [email protected] Refactor `android_engine_test`, make it easier to debug/deflake locally. (flutter/flutter#161534) 2025-01-15 [email protected] [Impeller] null check device buffer in image encoding. (flutter/flutter#161194) 2025-01-15 [email protected] Feature/twitter keyboard (flutter/flutter#161025) 2025-01-15 [email protected] Fixed XiaoMi statusBar Bug (flutter/flutter#161271) 2025-01-15 [email protected] Clean up engine's analysis_options.yaml (flutter/flutter#161554) 2025-01-14 [email protected] Remove `gradle_deprecated_settings` test app, and remove reference from lockfile exclusion yaml (flutter/flutter#161622) 2025-01-14 [email protected] [deps] remove no-longer-used repo deps (flutter/flutter#161605) 2025-01-14 [email protected] [DisplayList] remove obsolete use of Skia goemetry objects in DL utils (flutter/flutter#161553) 2025-01-14 [email protected] [Engine] Support asymmetrical rounded superellipses (flutter/flutter#161409) 2025-01-14 [email protected] [SwiftPM] Make 'flutter build ios-framework' generate an empty Package.swift (flutter/flutter#161464) 2025-01-14 [email protected] [canvaskit] Fix GIF decode failure (flutter/flutter#161536) 2025-01-14 [email protected] [Impeller] fixes for AHB swapchains. (flutter/flutter#161562) 2025-01-14 [email protected] Last Engine<>Framework lint sync (flutter/flutter#161560) 2025-01-14 [email protected] Check that localization files of stocks app are up-to-date (flutter/flutter#161608) 2025-01-14 [email protected] [Android] Actually remove dev dependencies from release builds (flutter/flutter#161343) 2025-01-14 [email protected] Update package revisions to latest (flutter/flutter#161525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

updated statusBar to systemBar

d482011

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Jan 7, 2025

jesswrd changed the title ~~Fixed XiaoMi statusBar() Bug~~ Fixed XiaoMi statusBar Bug Jan 7, 2025

jesswrd marked this pull request as ready for review January 8, 2025 00:45

jesswrd requested a review from reidbaker January 8, 2025 00:45

reidbaker requested changes Jan 8, 2025

View reviewed changes

simplified code and added a test

a738a92

reidbaker reviewed Jan 14, 2025

View reviewed changes

addressed comments

2a9bba8

reidbaker approved these changes Jan 14, 2025

View reviewed changes

Merge branch 'master' into i132831-xiaomi-status-bar-bug

2363bcf

jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

auto-submit bot added this pull request to the merge queue Jan 15, 2025

Merged via the queue into flutter:master with commit d832220 Jan 15, 2025
181 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 15, 2025

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 2b34d78c2331 (20 revisions) flutter/packages#8435

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

e6d2280

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 44ff2f59774b (22 revisions) flutter/packages#8436

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

c2b3607

engine-flutter-autoroll mentioned this pull request Jan 15, 2025

Roll Flutter from 40c2b86fdf65 to 1580a3d3fbe7 (23 revisions) flutter/packages#8437

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 15, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

9049caa

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

8bfaec1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

a56e2d7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

c16acd0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

bac1ea0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

78e1fe2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

140c3e7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

03f49ff

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

9dad29d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 16, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

9932544

reidbaker mentioned this pull request Jan 17, 2025

Incorrect MediaQuery padding in small window (freeform) mode on xiaomi device(Xiaomi 14, HyperOS2.0.7.0, Android15, Api35) causing abnormal layout on Flutter 3.27.X #161086

Open

Piinks mentioned this pull request Jan 17, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

131c0a8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

14e8170

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

482cb44

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

6ea630b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

d832220 Fixed XiaoMi statusBar Bug (flutter/flutter#161271)

5437230

Fixed XiaoMi statusBar Bug #161271

Fixed XiaoMi statusBar Bug #161271

Uh oh!

Conversation

jesswrd commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

reidbaker commented Jan 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jesswrd Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Jan 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jesswrd Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jesswrd commented Jan 7, 2025 •

edited

Loading

jesswrd Jan 14, 2025 •

edited

Loading

jesswrd Jan 14, 2025 •

edited

Loading