Skip to content

Move validation logic for .ci.yaml to flutter/flutter.#161249

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
matanlurey:ci_yaml_validation_test
Jan 7, 2025
Merged

Move validation logic for .ci.yaml to flutter/flutter.#161249
auto-submit[bot] merged 1 commit into
flutter:masterfrom
matanlurey:ci_yaml_validation_test

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Towards #160915 (future cleanup: remove the validation from flutter/cocoon).

This PR effectively duplicates the logic in flutter/cocoon#4137, in flutter/flutter.

/cc @jtmcdole

@@ -0,0 +1,161 @@
// Copyright 2014 The Flutter Authors. All rights reserved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What causes this test to run? Do we glob everything under dev/bots/test?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not sure, I was going to spelunk through the logs but maybe @christopherfujino knows off hand.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import './common.dart';

void main() {
final String flutterRoot = () {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just do $(which flutter)/../..?

@matanlurey

Copy link
Copy Markdown
Contributor Author

Will wait for an LGTM from @christopherfujino before moving forward.

@christopherfujino

Copy link
Copy Markdown
Contributor

Will wait for an LGTM from @christopherfujino before moving forward.

oops yeah, was taking a look at this and got distracted. una momento...

Comment thread dev/bots/test/ci_yaml_validation_test.dart

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Jan 7, 2025
Merged via the queue into flutter:master with commit 13ae4cd Jan 7, 2025
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025
auto-submit Bot pushed a commit to flutter/cocoon that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
srujzs pushed a commit to srujzs/flutter that referenced this pull request Jan 12, 2025
…61249)

Towards flutter#160915 (future
cleanup: remove the validation from `flutter/cocoon`).

This PR effectively duplicates the logic in
flutter/cocoon#4137, in `flutter/flutter`.

/cc @jtmcdole
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
pull Bot pushed a commit to AbhiShake1/flutter that referenced this pull request Jun 29, 2026
issue: flutter#188640

This follows the pattern from
flutter#161249

This duplicates the logic of
https://github.com/flutter/cocoon/blob/main/app_dart/bin/validate_task_ownership.dart

Note that the TESTOWNERS file format seems straightforward but it is
actually weird where things that look like comments have semantic
meaning.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants