Repository navigation
Fix DropdownMenu default width does not take label into account - #161219
Merged
auto-submit[bot] merged 3 commits intoFeb 13, 2025
Conversation
github-actions
Bot
added
framework
QuncCccccc
reviewed
Jan 15, 2025
QuncCccccc
approved these changes
Jan 22, 2025
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the improvement:) Let's see whether there's any luck on Google testing🤞
bleroux
force-pushed
the
fix_DropdownMenu_default_width_does_not_take_label_into_account
branch
from
January 22, 2025 08:28
11702a0 to
99ddf8a
Compare
Contributor
Author
|
@QuncCccccc Unfortunately some Google tests are failing, thanks in advance for checking how many tests are failing and if they can be updated. |
Contributor
|
Sorry for the late response. Will take a look at the google testing. |
QuncCccccc
self-requested a review
February 5, 2025 03:46
Contributor
|
There is a a11y test breaking in Google testing. Will fix it today. Thank you for your patience! |
QuncCccccc
reviewed
Feb 12, 2025
| (Widget item) => ExcludeFocus(excluding: !controller.isOpen, child: item), | ||
| ), | ||
| if (widget.label != null) | ||
| Padding( |
Contributor
There was a problem hiding this comment.
Can we add ExcludeSemantics here? I think this can fix the failure.
Contributor
Author
There was a problem hiding this comment.
Great, it worked out!
Thanks for having investigated those Google test failures 🙏
bleroux
force-pushed
the
fix_DropdownMenu_default_width_does_not_take_label_into_account
branch
from
February 13, 2025 08:27
99ddf8a to
5e08c56
Compare
bleroux
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
bleroux
deleted the
fix_DropdownMenu_default_width_does_not_take_label_into_account
branch
February 13, 2025 10:59
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
DropdownMenudefault width when a long label is provided.Before:
The width is based on the longest menu item (which can be smaller than the label):
After:
The width also depends on the label width when it is longer than the menu items.
Related Issue
Fixes DropdownMenu default width does not take label into account
Tests
Adds 2 tests.