Skip to content

fix: Call codec.dispose in tests of engine/src/flutter #161115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 2 commits into from
Jan 23, 2025
Merged

fix: Call codec.dispose in tests of engine/src/flutter #161115

polina-c merged 2 commits into from
Jan 23, 2025

Conversation

@koji-1009
Copy link
Contributor

@koji-1009 koji-1009 commented Jan 4, 2025 •
edited
Loading

PR derived from #159945.

Added codec.dispose() for directories under engine/src/flutter.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 4, 2025
@koji-1009 koji-1009 force-pushed the fix/dispose_codec_web_ui branch 11 times, most recently from ea39d2c to fdc8daf Compare January 5, 2025 07:13
@koji-1009 koji-1009 force-pushed the fix/dispose_codec_web_ui branch from fdc8daf to f2365d2 Compare January 5, 2025 08:17
@koji-1009 koji-1009 mentioned this pull request Jan 5, 2025
Merged
9 tasks
@koji-1009 koji-1009 marked this pull request as ready for review January 5, 2025 09:53
@koji-1009 koji-1009 force-pushed the fix/dispose_codec_web_ui branch from f2365d2 to 3c53a6b Compare January 6, 2025 04:22
@polina-c polina-c changed the title fix: Call codec.dispose in engine/src/flutter fix: Call codec.dispose in tests of engine/src/flutter Jan 22, 2025
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 23, 2025

auto label is removed for flutter/flutter/161115, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@polina-c polina-c added this pull request to the merge queue Jan 23, 2025
Merged via the queue into flutter:master with commit 2919003 Jan 23, 2025
175 of 176 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
2919003 fix: Call codec.dispose in tests of engine/src/flutter (flu…
9afcca8 
…tter/flutter#161115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
2919003 fix: Call codec.dispose in tests of engine/src/flutter (flu…
fff9594 
…tter/flutter#161115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
2919003 fix: Call codec.dispose in tests of engine/src/flutter (flu…
80d60e1 
…tter/flutter#161115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
2919003 fix: Call codec.dispose in tests of engine/src/flutter (flu…
7819060 
…tter/flutter#161115)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (#8491)
913c949 
Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@koji-1009 koji-1009 deleted the fix/dispose_codec_web_ui branch January 23, 2025 23:16
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@koji-1009
fix: Call codec.dispose in tests of engine/src/flutter (flutter#161115
632188d 
)

PR derived from flutter#159945.

Added `codec.dispose()` for directories under `engine/src/flutter`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2919003 fix: Call codec.dispose in tests of engine/src/flutter (flu…
7bd9963 
…tter/flutter#161115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2919003 fix: Call codec.dispose in tests of engine/src/flutter (flu…
e0903cc 
…tter/flutter#161115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
2919003 fix: Call codec.dispose in tests of engine/src/flutter (flu…
557eda7 
…tter/flutter#161115)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter#8491
9277996 
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter#8491
04dea25 
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koji-1009 @polina-c