use uuid from package:uuid instead of from package:usage #161102
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
tool
|
cc @andrewkolos; I'd thought #151518 was closed - so re-created a PR to move off of the uuid impl from package:usage - but see that your PR is open again. Perhaps still worth landing this PR in the interest of tackling the problem incrementally? |
…utter#161292) Reverts flutter#161102 This requires a non-trivial update to `package:uuid` internally - see b/388416319 for more details.
2 participants
package:usageis discontinued and no longer maintained; this removes one use of it from the flutter_tools codebase.List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
See also:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.