-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Roll gn to c97a86a72105f3328a540f5a5ab17d11989ab7dd #161012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current version is more than 3 years old.
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The clangd-related issue will be addressed in this PR: #161072 |
…ly (#161072) It seems that not all files in the Flutter repository are compatible with clangd. This change improves the clangd invocation in CI to choose files that are known to work with clangd. Reason for the change: In #161012, I'm trying to update GN to the latest version. However, this change made the order of files in the compile_commands.json. This caused [the clangd check to fail](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20clangd/10395/overview) because `engine/src/flutter/tools/clangd_check/bin/main.dart` currently chooses the first file in the compile_commands.json, and the newly chosen file (`engine/src/flutter/third_party/skia/modules/skparagraph/src/Decorations.cpp`) is not compatible with clangd. To fix this, I'm making the test choose the file that is known to work with clangd. (`gen/flutter/assets/_fl__fl_assets_fixtures.cc`) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Jonah Williams <[email protected]>
|
Hi @jonahwilliams, I believe you're interested in GN rolls in Flutter. Could you please review this change? Thanks! |
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @bc-lee ! |
The current version is more than 3 years old.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.