Skip to content

Conversation

@bc-lee
Copy link
Contributor

@bc-lee bc-lee commented Dec 31, 2024

The current version is more than 3 years old.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The current version is more than 3 years old.
@bc-lee bc-lee marked this pull request as draft December 31, 2024 07:43
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Dec 31, 2024
@bc-lee bc-lee marked this pull request as ready for review December 31, 2024 10:01
@github-actions github-actions bot added the a: desktop Running on desktop label Jan 2, 2025
@bc-lee bc-lee marked this pull request as draft January 2, 2025 22:02
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bc-lee
Copy link
Contributor Author

bc-lee commented Jan 3, 2025

The clangd-related issue will be addressed in this PR: #161072

@bc-lee bc-lee marked this pull request as ready for review January 3, 2025 01:09
github-merge-queue bot pushed a commit that referenced this pull request Feb 4, 2025
…ly (#161072)

It seems that not all files in the Flutter repository are compatible
with clangd. This change improves the clangd invocation in CI to choose
files that are known to work with clangd.

Reason for the change:

In #161012, I'm trying to update
GN to the latest version. However, this change made the order of files
in the compile_commands.json. This caused [the clangd check to
fail](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20clangd/10395/overview)
because `engine/src/flutter/tools/clangd_check/bin/main.dart` currently
chooses the first file in the compile_commands.json, and the newly
chosen file
(`engine/src/flutter/third_party/skia/modules/skparagraph/src/Decorations.cpp`)
is not compatible with clangd. To fix this, I'm making the test choose
the file that is known to work with clangd.
(`gen/flutter/assets/_fl__fl_assets_fixtures.cc`)


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Jonah Williams <[email protected]>
@github-actions github-actions bot added platform-fuchsia Fuchsia code specifically platform-linux Building on or for Linux specifically labels Feb 4, 2025
@bc-lee
Copy link
Contributor Author

bc-lee commented Feb 4, 2025

Hi @jonahwilliams,

I believe you're interested in GN rolls in Flutter. Could you please review this change? Thanks!

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@jonahwilliams
Copy link
Contributor

Thanks @bc-lee !

@auto-submit auto-submit bot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into flutter:master with commit 44785da Feb 5, 2025
176 of 177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@bc-lee bc-lee deleted the feature/roll-gn branch February 13, 2025 22:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-fuchsia Fuchsia code specifically platform-linux Building on or for Linux specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants