Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 #160974

bartekpacia · 2024-12-30T17:00:28Z

No description provided.

dev/devicelab/bin/tasks/android_java17_dependency_smoke_tests.dart

reidbaker · 2025-01-10T15:41:19Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

 const String templateAndroidGradlePluginVersion = '8.7.0';
 const String templateAndroidGradlePluginVersionForModule = '8.7.0';
-const String templateKotlinGradlePluginVersion = '1.8.22';
+const String templateKotlinGradlePluginVersion = '2.1.0';


I believe to do this we need to enforce that gradle is at least 8.3.
Also this is a new condition in our 4 (now 5 way) dependency graph.

https://kotlinlang.org/docs/whatsnew20.html#current-k2-compiler-limitations

The highest version I think you can use without running into gradle compatibility issues is kotlin 1.9.25

This template is technically ok since the AGP version is 8.7 but I think we need a new test in dev/devicelab/bin/tasks/android_java17_dependency_smoke_tests.dart

I believe to do this we need to enforce that gradle is at least 8.3.

Yes, but don't we already do this since (as you said) in new Android project template we already have Gradle/AGP/Kotlin versions that are compatible with each other?

I think we need a new test in dev/devicelab/bin/tasks android_java17_dependency_smoke_tests.dart

Done.

bartekpacia · 2025-01-10T17:15:26Z

I decided that while I'm already at it, it probably won't hurt to also upgrade to latest stable Gradle 8.12.

reidbaker

want a second review from @gmackall

I think this is ok to land but we probably need to update our compatibility logic to look at gradle and kotlin support now that we know that kotlin 2 requires AGP 8.3 or higher.

reidbaker · 2025-01-10T18:56:12Z

#161443

…-> 8.12

bartekpacia · 2025-01-23T19:20:52Z

cc @gmackall second review will be appreciated

gmackall

LGTM!

dev/devicelab/bin/tasks/android_java17_dependency_smoke_tests.dart

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

… default Gradle from 8.9 to 8.12 (flutter#160974)

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

Manual roll requested by [email protected] flutter/flutter@c1561a4...c1ffaa9 2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 [email protected] Unskip test. (flutter/flutter#162106) 2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095) 2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

) Manual roll requested by [email protected] flutter/flutter@c1561a4...c1ffaa9 2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 [email protected] Unskip test. (flutter/flutter#162106) 2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095) 2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 30, 2024

bkonyi added the team-android Owned by Android platform team label Jan 9, 2025

bkonyi requested a review from a team January 9, 2025 21:23

bartekpacia force-pushed the bartekpacia/chore/default_kotlin_version_bump branch from bdddcc4 to ef1c594 Compare January 9, 2025 23:26

github-actions bot removed the team-android Owned by Android platform team label Jan 9, 2025

reidbaker reviewed Jan 10, 2025

View reviewed changes

bartekpacia force-pushed the bartekpacia/chore/default_kotlin_version_bump branch 2 times, most recently from b30aec3 to 3e68096 Compare January 10, 2025 17:11

bartekpacia changed the title ~~Bump default Kotlin version from 1.8.22 to 2.1.0~~ Android templatest: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 Jan 10, 2025

bartekpacia changed the title ~~Android templatest: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12~~ Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 Jan 10, 2025

reidbaker approved these changes Jan 10, 2025

View reviewed changes

reidbaker requested a review from gmackall January 10, 2025 18:49

reidbaker mentioned this pull request Jan 10, 2025

Update multiway AGP/Java/Gradle compatibility logic to also include a check for kotlin #161443

Closed

[Android templates] default Kotlin 1.8.22->2.1.0, default Gradle 8.9 …

2e6b0f3

…-> 8.12

bartekpacia force-pushed the bartekpacia/chore/default_kotlin_version_bump branch from 3e68096 to 2e6b0f3 Compare January 23, 2025 00:09

fix tests

252ec21

gmackall approved these changes Jan 23, 2025

View reviewed changes

dev/devicelab/bin/tasks/android_java17_dependency_smoke_tests.dart Show resolved Hide resolved

bartekpacia added this pull request to the merge queue Jan 23, 2025

Merged via the queue into master with commit 558b21a Jan 23, 2025
172 checks passed

bartekpacia deleted the bartekpacia/chore/default_kotlin_version_bump branch January 23, 2025 20:32

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to bf7daf22a51e (19 revisions) flutter/packages#8495

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

e0438da

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to 02e11f95a18a (20 revisions) flutter/packages#8496

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

f7284a8

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025

Android templates: update default Kotlin from 1.8.22 to 2.1.0, update…

faff240

… default Gradle from 8.9 to 8.12 (flutter#160974)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8497

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

77badcf

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Manual roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8498

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

e4627d9

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8500

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

f1bba0a

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

3920fc0

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

6b4fa71

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

558b21a Android templates: update default Kotlin from 1.8.22 to 2.1.0…

1405f60

…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)

ripplearcgit mentioned this pull request Jun 23, 2025

Integrate custom lint to the construculator-app project ripplearc/construculator-app#35

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 #160974

Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 #160974

Uh oh!

bartekpacia commented Dec 30, 2024

Uh oh!

Uh oh!

reidbaker Jan 10, 2025

Uh oh!

reidbaker Jan 10, 2025

Uh oh!

bartekpacia Jan 10, 2025

Uh oh!

bartekpacia commented Jan 10, 2025

Uh oh!

reidbaker left a comment •

edited

Loading

Uh oh!

reidbaker commented Jan 10, 2025

Uh oh!

bartekpacia commented Jan 23, 2025

Uh oh!

gmackall left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 #160974

Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 #160974

Uh oh!

Conversation

bartekpacia commented Dec 30, 2024

Uh oh!

Uh oh!

reidbaker Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

bartekpacia Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

bartekpacia commented Jan 10, 2025

Uh oh!

reidbaker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Jan 10, 2025

Uh oh!

bartekpacia commented Jan 23, 2025

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reidbaker left a comment •

edited

Loading