Skip to content

Enforce comment_references #160921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
goderbauer wants to merge 1 commit into from
Closed

Enforce comment_references #160921

goderbauer wants to merge 1 commit into from

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 27, 2024

Blocked on #150800

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Dec 27, 2024
@goderbauer goderbauer changed the title Enforce comment_references Enforce comment_references Dec 27, 2024
@goderbauer goderbauer force-pushed the enforceCommentReferences branch 4 times, most recently from 4dff95b to ef6753d Compare December 30, 2024 19:29
@goderbauer goderbauer mentioned this pull request Dec 30, 2024
Open
11 tasks
@goderbauer goderbauer force-pushed the enforceCommentReferences branch from ef6753d to 74bafea Compare February 7, 2025 18:09
@goderbauer goderbauer mentioned this pull request Feb 7, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 10, 2025
@goderbauer
Fix doc reference typos (#162893)
c484d14 
I updated #160921 and found
these. Sadly, the lint is not quite ready to be enabled yet.

Work towards #150800.
@goderbauer goderbauer force-pushed the enforceCommentReferences branch from 74bafea to 8bff191 Compare February 13, 2025 00:32
@goderbauer
Copy link
Member Author

goderbauer commented Mar 3, 2025

This is still a worthwhile lint to enable. It would be a great quality improvement for our docs. However, given there are still upstream issues with the lint (see #150800), I am going to close this PR for now.

@goderbauer goderbauer closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@goderbauer