Skip to content

Remove bringup: true from web tests. #160788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Dec 23, 2024
Merged

Remove bringup: true from web tests. #160788

auto-submit merged 2 commits into from
Dec 23, 2024

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Dec 23, 2024

We should make this a blocking CI step ASAP.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Dec 23, 2024
@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 23, 2024
@jtmcdole
Copy link
Member

jtmcdole commented Dec 23, 2024

We should make this a blocking CI step ASAP.

Blocking presubumits or blocking Mq?

@eyebrowsoffire
Copy link
Contributor Author

eyebrowsoffire commented Dec 23, 2024

We should make this a blocking CI step ASAP.

Blocking presubumits or blocking Mq?

Blocking presubmits, not MQ. MQ has the linux_web_engine builder which just builds the web engine artifacts. This runs the tests, but we should make sure that these actually run in presubmit and postsubmit. It's an important signal, especially for dart SDK rolls and skia rolls.

@jtmcdole
Copy link
Member

jtmcdole commented Dec 23, 2024

I believe we're deciding that all presubmits must pass; so we'll have to update Cocoon to record multiple stages before completing the MQG. Good thing for the new year.

@eyebrowsoffire
Copy link
Contributor Author

eyebrowsoffire commented Dec 23, 2024

Sorry, maybe I'm being confusing. I think just removing bringup: true should be fine for this change. It just needs to be another presubmit check that should pass before PRs are merged, it doesn't need to be part of the MQ guard (unless there's some other thing I'm misunderstanding).

@auto-submit auto-submit bot added this pull request to the merge queue Dec 23, 2024
Merged via the queue into flutter:master with commit 65ff060 Dec 23, 2024
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 23, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
be30d79
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
d48ce7e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
ff20d2e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
83d0015
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
e92ad60
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
e48909b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
cc58042
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
c5060d1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
c6b335a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
2606be7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
fd0726a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
31816b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
e3608ce
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
57e19a6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
fd49aa5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
1d37875
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
4a1bd0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
23876b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
2bc9cbd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
65ff060 Remove bringup: true from web tests. (flutter/flutter#160788)
224506a
@eyebrowsoffire eyebrowsoffire deleted the web_tests_remove_bringup branch December 12, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyebrowsoffire @jtmcdole @mdebbar