Skip to content

Remove --template=skeleton and add a placeholder error message instead. #160695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Dec 24, 2024
Merged

Remove --template=skeleton and add a placeholder error message instead. #160695

auto-submit merged 8 commits into from
Dec 24, 2024

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Dec 20, 2024 •
edited
Loading

Closes #160673.

Does the following:

  • Renames FlutterProjectType to FlutterTemplateType; did some enhanced enum cleanups while at it
  • Creates a hierarchy of RemovedFlutterTemplateType from ParsedFlutterTemplateType
  • Removes the skeleton directory
  • Merges app_shared back into app (no longer required now that skeleton is removed)

Final cleanups are tracked in #160692.

(Added @zanderso just to spot check this is what he meant by #160673 (comment))

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 20, 2024
jonahwilliams
jonahwilliams reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end but I would let @andrewkolos take a look when he is available.

@matanlurey
Copy link
Contributor Author

matanlurey commented Dec 21, 2024

Some hardcoded-test assumptions still need to be updated. I'll fix those up Monday.

andrewkolos
andrewkolos approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM. Feel free to re-request if tests end up needing significant re-writes

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. a: desktop Running on desktop labels Dec 23, 2024
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 24, 2024
Merged via the queue into flutter:master with commit 0ffc4ce Dec 24, 2024
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024
zanderso
zanderso reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what I was thinking.

packages/flutter_tools/lib/src/flutter_project_metadata.dart
'Formerly generated a list view / detail view Flutter application that '
'followed some community best practices. For up to date resources, see '
'https://flutter.github.io/samples, https://docs.flutter.dev/codelabs, '
'and external resources such as https://flutter-builder.app/.',
Copy link
Member

@zanderso zanderso Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: external -> "community" or "third-party".

packages/flutter_tools/lib/src/flutter_project_metadata.dart
enum RemovedFlutterTemplateType implements ParsedFlutterTemplateType {
skeleton(
helpText:
'Formerly generated a list view / detail view Flutter application that '
Copy link
Member

@zanderso zanderso Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericwindmill sgty?

matanlurey added a commit to matanlurey/flutter that referenced this pull request Dec 26, 2024
@matanlurey
Tweak language post-merge of flutter#160695.
48a430d
@matanlurey matanlurey mentioned this pull request Dec 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 27, 2024
@matanlurey
Tweak language post-merge of #160695. (#160876)
cdce287 
Post-merge feedback from #160695.

Feel free to suggest other (minor) changes, as the bulk of the work is
already complete.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
afa3f22 
…age instead. (flutter/flutter#160695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
ee6d9e9 
…age instead. (flutter/flutter#160695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
a10e39f 
…age instead. (flutter/flutter#160695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
267a868 
…age instead. (flutter/flutter#160695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
e55ab97 
…age instead. (flutter/flutter#160695)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
8eaf2d5 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
f7e8c56 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
3bcdb4b 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
2982a18 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
42a8499 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
26c7ec3 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
573fd47 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
260a5ed 
…age instead. (flutter/flutter#160695)
@StephenWithPH StephenWithPH mentioned this pull request Jan 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
5d3a49f 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
6ede15d 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
6073e69 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
f49cc6e 
…age instead. (flutter/flutter#160695)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
0ffc4ce Remove --template=skeleton and add a placeholder error mess…
6ac4fea 
…age instead. (flutter/flutter#160695)
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Mar 13, 2025
@JSUYA
Change FlutterProjectType to FlutterTemplateType
b55406d 
flutter/flutter#160695
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Mar 13, 2025
@JSUYA
Merges app_shaed into app
accf825 
flutter/flutter#160695
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 10, 2025
@JSUYA
Change FlutterProjectType to FlutterTemplateType
30b9c1d 
flutter/flutter#160695
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 10, 2025
@JSUYA
Merges app_shaed into app
fb83e0f 
flutter/flutter#160695
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 11, 2025
@JSUYA
Change FlutterProjectType to FlutterTemplateType
18c0ecf 
flutter/flutter#160695
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 11, 2025
@JSUYA
Merges app_shaed into app
1bbccbd 
flutter/flutter#160695
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 15, 2025
@JSUYA
Change FlutterProjectType to FlutterTemplateType
7449e39 
flutter/flutter#160695
JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 15, 2025
@JSUYA
Merges app_shaed into app
3198d71 
flutter/flutter#160695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso left review comments

@andrewkolos andrewkolos andrewkolos approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove 'skeleton' template

4 participants

@matanlurey @zanderso @jonahwilliams @andrewkolos