Skip to content

[flutter_tools] unconditionally skip bash test #160690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Dec 21, 2024
Merged

[flutter_tools] unconditionally skip bash test #160690

auto-submit merged 1 commit into from
Dec 21, 2024

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Dec 20, 2024 •
edited
Loading

Work around: #160689.

I locally verified that we have not regressed what this was testing (that just invoking //flutter/bin/dart will not build the flutter tool).

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 20, 2024
@christopherfujino christopherfujino added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Dec 20, 2024
@jtmcdole
Copy link
Member

jtmcdole commented Dec 20, 2024

I will look at the integration tests and make sure they copy the right data. Sorry about that!

@auto-submit auto-submit bot added this pull request to the merge queue Dec 20, 2024
Merged via the queue into flutter:master with commit 3dc695d Dec 21, 2024
159 of 164 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2024
@christopherfujino christopherfujino deleted the disable-bash-entrypoint-test branch December 21, 2024 00:42
@christopherfujino christopherfujino mentioned this pull request Dec 21, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
33e3f87 
…er#160690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
2859361 
…er#160690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
b15763b 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
500d1e1 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
efc5eb8 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
afcb34e 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
a55150f 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
7b10241 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
4a2d095 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
65ea232 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
c1b089c 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
6c47580 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
cb75b9c 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
f9b7a10 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
5206b3f 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
6739a5b 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
cee708e 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
ccf8390 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
3b155b8 
…er#160690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
3dc695d [flutter_tools] unconditionally skip bash test (flutter/flutt…
5d95480 
…er#160690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christopherfujino @jtmcdole @matanlurey