Skip to content

[Impeller] workarounds for slow Adreno primitive restart performance. #160683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Dec 22, 2024
Merged

[Impeller] workarounds for slow Adreno primitive restart performance. #160683

auto-submit merged 5 commits into from
Dec 22, 2024

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Dec 20, 2024 •
edited
Loading

Fixes #160593

Primitive Restart cannot be used on some (All?) Adreno's because it causes a dramatic performance regression. Opt out and use the GLES strategy. Refactors the batch submit command buffer capability into workarounds_vk

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Dec 20, 2024
jonahwilliams
jonahwilliams commented Dec 20, 2024
View reviewed changes
engine/src/flutter/impeller/display_list/dl_dispatcher.cc
PathBuilder builder;
builder.AddRoundRect(outer);
builder.AddRoundRect(inner);
builder.SetBounds(outer.GetBounds().Union(inner.GetBounds()));
Copy link
Contributor Author

@jonahwilliams jonahwilliams Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, the original issue shows a lot of overhead from us re-computing this value, but we don't need to.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 21, 2024

auto label is removed for flutter/flutter/160683, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2024
@jonahwilliams jonahwilliams added this pull request to the merge queue Dec 21, 2024
@jonahwilliams jonahwilliams removed this pull request from the merge queue due to a manual request Dec 21, 2024
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 22, 2024
Merged via the queue into flutter:master with commit 5e8b624 Dec 22, 2024
60 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
d5d9391 
…ormance. (flutter/flutter#160683)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
eea23d4 
…ormance. (flutter/flutter#160683)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
bbda66a 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
8fa7ba3 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
bed96c8 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
0898524 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
6ed158b 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
58b79ac 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
4baeed3 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
3ab3673 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
0384d2a 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
3f49521 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
bb1aa03 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
ab1e5fd 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
55e72bc 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
0a51791 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
df2dfbb 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
aa1c0d1 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
3f59c2a 
…ormance. (flutter/flutter#160683)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
5e8b624 [Impeller] workarounds for slow Adreno primitive restart perf…
d5a951b 
…ormance. (flutter/flutter#160683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] slow performance of DRRect on Adreno GPU due to primitive restart.

2 participants

@jonahwilliams @matanlurey