Skip to content

deprecate engine ci yaml roller #160682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Dec 21, 2024
Merged

deprecate engine ci yaml roller #160682

auto-submit merged 1 commit into from
Dec 21, 2024

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Dec 20, 2024

This is no longer working after the monorepo merge: #160670.

That issue tracks instead teaching the Linux ci_yaml flutter roller to roll both sets of configurations.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Dec 20, 2024
@christopherfujino christopherfujino mentioned this pull request Dec 20, 2024
Closed
eyebrowsoffire
eyebrowsoffire approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 21, 2024
Merged via the queue into flutter:master with commit 6d537a7 Dec 21, 2024
62 of 63 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
4d86a28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
baaa66d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
7909b1c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
9314a2a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
0e4b2ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
9f6b237
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
e770167
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
0b8ff5d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
81db20f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
91db05c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
60beff4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
c75f2de
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
07c1d75
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
1868cab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
7f11a3c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
b017140
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
705d4f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
b82aeb7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
138ff83
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
6d537a7 deprecate engine ci yaml roller (flutter/flutter#160682)
4a24298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @eyebrowsoffire