Skip to content

Update README.md #160677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Dec 21, 2024
Merged

Update README.md #160677

auto-submit merged 2 commits into from
Dec 21, 2024

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 20, 2024

No description provided.

@goderbauer goderbauer requested a review from jtmcdole December 20, 2024 19:13
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Dec 20, 2024
matanlurey
matanlurey reviewed Dec 20, 2024
View reviewed changes
engine/README.md Outdated

1. Copy one of the `engine/scripts/*.gclient` to the root folder as `.gclient`
1. Copy one of the `engine/scripts/*.gclient` to the root folder as `.gclient`:
1. Googlers: copy `rbe.gclient` to enable faster builds with RBE
Copy link
Contributor

@matanlurey matanlurey Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also link to https://github.com/flutter/flutter/blob/master/engine/src/flutter/docs/rbe/rbe.md.

Copy link
Member

@jtmcdole jtmcdole Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

googlers could also replace the url with git@github link?

Copy link
Member Author

@goderbauer goderbauer Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the link to RBE.

jtmcdole
jtmcdole approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 21, 2024
Merged via the queue into master with commit d9e5a5c Dec 21, 2024
61 of 62 checks passed
@auto-submit auto-submit bot deleted the goderbauer-patch-1 branch December 21, 2024 06:32
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
ed8269f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
482315e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
f112e2d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
421927a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
65f0903
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
e14e134
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
190d4fb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
3ab0407
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
0ee87a8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
e340caf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
ae826ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
59a373f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
4fd0880
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
6b7fce4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
7a7dc10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
043b65b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
1338e61
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
82e5097
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
9f5f13a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
d9e5a5c Update README.md (flutter/flutter#160677)
824ff0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey left review comments

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @matanlurey @jtmcdole