Skip to content

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented Dec 20, 2024

update_dart_sdk.(ps1|sh) is called too late and needs to be called from shared.(bat|sh).

Fixes #160640

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to regain a thorough understanding of the tool startup scripts, but I'm willing to LGTM since 1) this is P0 and 2) this PR just moves the existing operation of writing engine.version to be earlier

@jtmcdole
Copy link
Member Author

Pre submits ftw - going to figure out why the windows bots are failing

@jtmcdole jtmcdole enabled auto-merge December 20, 2024 19:46
@jtmcdole jtmcdole added this pull request to the merge queue Dec 20, 2024
auto-merge was automatically disabled December 20, 2024 20:23

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:24

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:24

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:24

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:24

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:24

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:25

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:25

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:25

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:25

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:25

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:26

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:26

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:26

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:26

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:26

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:26

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:26

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:27

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 21:07

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 21:07

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 21:12

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 21:15

Pull Request is not mergeable

Merged via the queue into flutter:master with commit 021b2b3 Dec 20, 2024
166 of 170 checks passed
@jtmcdole jtmcdole deleted the ensureEngineVersionIsCorrect branch December 20, 2024 21:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter upgrade has mismatched engine versions on master

2 participants