Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Fixes #160480

Both The Impeller and Skia variant of the OES texture rendering use the same shared code path, so the Impeller code must match the weird 1x1 texture behavior of Skia. In addition, we have to add back the TiledTextureContents support, since we need to render a texture with a transform. I had previously tested this but neglected to force the SurfaceTexture path, so I only tested the ImageReader path which does not use a transform.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. labels Dec 20, 2024
@jonahwilliams
Copy link
Contributor Author

I believe this will also fix #159851

@jonahwilliams jonahwilliams added this pull request to the merge queue Dec 20, 2024
auto-merge was automatically disabled December 20, 2024 19:55

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:56

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:56

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:56

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:56

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:56

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:57

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:57

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:58

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 19:59

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:00

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:00

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:01

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:01

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:01

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:02

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:03

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:03

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:03

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:17

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:19

Pull Request is not mergeable

auto-merge was automatically disabled December 20, 2024 20:23

Pull Request is not mergeable

Merged via the queue into flutter:master with commit 2d81159 Dec 20, 2024
58 of 62 checks passed
@jonahwilliams jonahwilliams deleted the fix_gles_surface_texture branch December 20, 2024 21:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] [Impeller] master branch: Virtual display platformview is broken on Android 10 (api 29) or lower.

2 participants