Skip to content

[Impeller] remove unused BliPass::EncodeCommands arg and cleanup. #160623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 2 commits into from
Dec 20, 2024
Merged

[Impeller] remove unused BliPass::EncodeCommands arg and cleanup. #160623

jonahwilliams merged 2 commits into from
Dec 20, 2024

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Dec 19, 2024

The TransientsAllocator argument to BlitPass::EncodeCommands is completely unused. Delete it (and add a missing IFDEF around the GLES debug labels.).

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. labels Dec 19, 2024
gaaclarke
gaaclarke approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2024
@jonahwilliams jonahwilliams added this pull request to the merge queue Dec 20, 2024
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Dec 20, 2024

Get back in there buddy

Merged via the queue into flutter:master with commit cec8f10 Dec 20, 2024
64 checks passed
@jonahwilliams jonahwilliams deleted the remove_extra_args branch December 20, 2024 20:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
0ac8d2a 
…nup. (flutter/flutter#160623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
1fb2b1b 
…nup. (flutter/flutter#160623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
3ca5f38 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
3230a12 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
5b2bd21 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
fd6aa69 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
a952533 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
018040d 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
cd63109 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
1a71b83 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
ad603e9 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
0873f5c 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
0fb608e 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
3a3b7a2 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
210aef8 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
2cf989d 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
c6090b3 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
377cf9e 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
10d9b09 
…nup. (flutter/flutter#160623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
cec8f10 [Impeller] remove unused BliPass::EncodeCommands arg and clea…
6682265 
…nup. (flutter/flutter#160623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @gaaclarke