[native_assets] Preparation existing tests for future of other (i.e. non-Code) assets #160436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
dcharkes
approved these changes
Dec 18, 2024
Member
Author
|
Thanks, @dcharkes ! |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mkustermann
force-pushed
the
asset-types
branch
from
fcaae80 to
03c8432
Compare
bkonyi
approved these changes
Dec 19, 2024
mkustermann
force-pushed
the
asset-types
branch
3 times, most recently
from
9b7e065 to
83bfbea
Compare
…non-Code) assets In the future a hook may be invoked multiple times with different `supportedAssetTypes` (soon to be renamed to `buildAssetTypes`). The hook should only emit those asset types that are in `supportedAssetTypes` - anything else is an error. Right now flutter happens to invoke hooks only with `Code` asset types, but more asset types are coming, for which this PR is a preparation for.
expectation test function
mkustermann
force-pushed
the
asset-types
branch
from
83bfbea to
18040cb
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 6, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
…r (i.e. non-Code) assets (flutter/flutter#160436)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future a hook may be invoked multiple times with different
supportedAssetTypes(soon to be renamed tobuildAssetTypes).The hook should only emit those asset types that are in
supportedAssetTypes- anything else is an error. Right now flutter happens to invoke hooks only withCodeasset types, but more asset types are coming, for which this PR is a preparation for.