Skip to content

Remove more references to deprecated package:usage (executable, runner) #160369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Dec 16, 2024
Merged

Remove more references to deprecated package:usage (executable, runner) #160369

auto-submit merged 3 commits into from
Dec 16, 2024

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Dec 16, 2024

Helps #150575

Pre-launch checklist

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 16, 2024
@andrewkolos andrewkolos changed the title Remove more references to deprecated package:usage Remove more references to deprecated package:usage (executable, runner) Dec 16, 2024
@andrewkolos andrewkolos mentioned this pull request Dec 16, 2024
Open
3 tasks
@andrewkolos andrewkolos marked this pull request as ready for review December 16, 2024 19:19
andrewkolos
andrewkolos commented Dec 16, 2024
View reviewed changes
packages/flutter_tools/lib/runner.dart
Comment on lines -103 to -110
if (!globals.analytics.telemetryEnabled &&
globals.flutterUsage.enabled) {
UsageEvent(
'ga4_and_ga3_status_mismatch',
'opted_out_of_ga4',
flutterUsage: globals.flutterUsage,
).send();
}
Copy link
Contributor Author

@andrewkolos andrewkolos Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if anyone ever looked for these events, but they are sure gone by now if they ever existed 🤷

@andrewkolos andrewkolos requested review from bkonyi and removed request for bkonyi December 16, 2024 19:20
@andrewkolos
Copy link
Contributor Author

andrewkolos commented Dec 16, 2024

Oops, I missed some things. I will re-request review when this is actually ready

@andrewkolos andrewkolos marked this pull request as draft December 16, 2024 19:22
@flutter-dashboard

This comment was marked as off-topic.

Sign in to view
andrewkolos
andrewkolos commented Dec 16, 2024
View reviewed changes
packages/flutter_tools/test/general.shard/runner/runner_test.dart
(globals.logger as BufferLogger).traceText,
isNot(contains('Showed analytics consent message.')),
);
},
Copy link
Contributor Author

@andrewkolos andrewkolos Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't immediately see any tests that make sure we actually do show the analytics consent message when we should. I filed and self-assigned #160374 as a follow-up item.

@andrewkolos andrewkolos requested a review from bkonyi December 16, 2024 20:31
@andrewkolos andrewkolos marked this pull request as ready for review December 16, 2024 20:31
@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 16, 2024
Merged via the queue into flutter:master with commit c803c13 Dec 16, 2024
146 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
c3eaa10 
…e, runner) (flutter/flutter#160369)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
bc0a84a 
…e, runner) (flutter/flutter#160369)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
b07e014 
…e, runner) (flutter/flutter#160369)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
5560623 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
46fcc90 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
f0c0626 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
813f1e1 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
336f10e 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
770c71f 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
0cbca52 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
b9444cc 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
0b6627c 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
b7d4de2 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
cdd6a72 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
70c0b2f 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
86199e4 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
51e9b5f 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
4f58829 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
22bebd9 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
78cafd4 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
9248bd9 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
1a19304 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
887765c 
…e, runner) (flutter/flutter#160369)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
c803c13 Remove more references to deprecated package:usage (executabl…
cbd2184 
…e, runner) (flutter/flutter#160369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewkolos @bkonyi