Skip to content

Fix a bug to skip flutter_gen when synthetic packages are disabled #160367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matanlurey merged 1 commit into from
Dec 16, 2024
Merged

Fix a bug to skip flutter_gen when synthetic packages are disabled #160367

matanlurey merged 1 commit into from
Dec 16, 2024

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Dec 16, 2024

Without this bug fix, when flipping the flag a lot of things blow up :)

(#160289 as an example of needing this)

@matanlurey matanlurey requested a review from camsim99 December 16, 2024 18:47
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 16, 2024
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@matanlurey matanlurey added this pull request to the merge queue Dec 16, 2024
Merged via the queue into flutter:master with commit daaceac Dec 16, 2024
145 of 146 checks passed
@matanlurey matanlurey deleted the fix-null-case-synthetic-packages branch December 16, 2024 19:35
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
2dec64c 
…isabled (flutter/flutter#160367)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
9b8d3d8 
…isabled (flutter/flutter#160367)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
0669cdf 
…isabled (flutter/flutter#160367)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
3bbaecb 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
dc01807 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
5942a06 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
201bd8c 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
fc5cd75 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
67fe3cf 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
88a4516 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
3ef14a5 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
326847d 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
e5e65b7 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
bb1a88e 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
cac24d9 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
7892d12 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
cbe4f55 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
a0ad34d 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
4fc5e2b 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
64909e6 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
11e1369 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
ca61505 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
3a5ebc6 
…isabled (flutter/flutter#160367)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
daaceac Fix a bug to skip flutter_gen when synthetic packages are d…
8f42f2f 
…isabled (flutter/flutter#160367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 camsim99 approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey @camsim99