Skip to content

Enable --explicit-package-dependencies by default. #160289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 23 commits into from
Feb 21, 2025
Merged

Enable --explicit-package-dependencies by default. #160289

auto-submit merged 23 commits into from
Feb 21, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Dec 14, 2024 •
edited
Loading

Closes #160257.

This will sit on CI for a bit and give me a better idea of how much work there is to do. Done!

IMPORTANT: Do not revert on 1-2 isolated post-submit failures.

While I've spent the last several weeks getting this passing all presubmit tests, and some integration tests I suspected might be affected, it is possible that there are 1-2 integration tests that will fail as a result of landing this PR. I'll disable the flag (--no-explicit-package-dependencies) if the failures look obvious enough, otherwise I'll revert.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 14, 2024
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 14, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@matanlurey matanlurey mentioned this pull request Dec 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 16, 2024
@matanlurey
Fix a bug to skip flutter_gen when synthetic packages are disabled (#…
daaceac 
…160367)

Without this bug fix, when flipping the flag a lot of things blow up :)

(#160289 as an example of needing
this)
matanlurey added a commit to flutter/tests that referenced this pull request Dec 16, 2024
@matanlurey
Update zulip.test to latest SHA.
93727f6 
Required for Flutter master channel to enable `explicit-package-dependencies` (flutter/flutter#160289, flutter/flutter#160257).
@matanlurey matanlurey mentioned this pull request Dec 16, 2024
Closed
matanlurey added a commit to flutter/packages that referenced this pull request Dec 17, 2024
@matanlurey
DO NOT MERGE: Try flutter config --explicit-package-dependencies.
ab2c4a2 
Smoke testing <flutter/flutter#160289> early.
This was referenced Dec 17, 2024
Closed
Closed
@matanlurey matanlurey force-pushed the enable-explicit-package-dependencies branch from 08b3efc to a974afa Compare December 19, 2024 21:29
@matanlurey matanlurey added the blocked Issue is blocked by another issue label Dec 30, 2024
@matanlurey matanlurey mentioned this pull request Jan 14, 2025
Closed
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Jan 15, 2025
@matanlurey
Copy link
Contributor Author

matanlurey commented Jan 15, 2025

fyi @camsim99 I pushed an update to the lockfiles in 39ccf42:

dart ./dev/tools/bin/generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion

I think dev/integration_tests/gradle_deprecated_settings crashes, but should be removed?

@camsim99
Copy link
Contributor

camsim99 commented Jan 15, 2025

Hmm looks like there's still lockfile issues?

@matanlurey matanlurey force-pushed the enable-explicit-package-dependencies branch from 77037c9 to 2548fc5 Compare January 16, 2025 19:19
@matanlurey
Copy link
Contributor Author

matanlurey commented Jan 16, 2025 

dart ./dev/tools/bin/generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion

Trying again after #161635.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
e3ec80c 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
4541b35 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
3038f33 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
d15aeb6 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
d3c8e31 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
ab8ebea 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
1b9c461 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
66e44c8 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
cbe92b0 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
17ff1ac 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
c056788 
…/flutter#160289)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
e6c49df 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
7f2ed74 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
a45f988 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
b4a957b 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
ac25f89 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
aa179e0 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
bbd902a 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
496b367 
…/flutter#160289)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
043b719 Enable --explicit-package-dependencies by default. (flutter…
a2004cc 
…/flutter#160289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 camsim99 approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

@bkonyi bkonyi Awaiting requested review from bkonyi

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prepare to enable explicit-package-dependencies

2 participants

@matanlurey @camsim99