Skip to content

Enable explicit-package-dependencies (resident_web_runner_cold_test.dart) #160258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Dec 13, 2024
Merged

Enable explicit-package-dependencies (resident_web_runner_cold_test.dart) #160258

auto-submit merged 2 commits into from
Dec 13, 2024

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Dec 13, 2024

Example of option (2) for #160257.

@matanlurey matanlurey mentioned this pull request Dec 13, 2024
Closed
1 task
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 13, 2024
@matanlurey matanlurey requested a review from bkonyi December 13, 2024 19:48
@matanlurey matanlurey marked this pull request as ready for review December 13, 2024 19:48
bkonyi
bkonyi approved these changes Dec 13, 2024
View reviewed changes
packages/flutter_tools/test/general.shard/resident_web_runner_cold_test.dart Outdated

// TODO(matanlurey): Remove after `explicit-package-dependencies` is enabled by default.
// See https://github.com/flutter/flutter/issues/160257 for details.
FeatureFlags enableExplicitPackageDepdendencies() {
Copy link
Contributor

@bkonyi bkonyi Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Depdendencies/Dependencies/

Copy link
Contributor Author

@matanlurey matanlurey Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 13, 2024
Merged via the queue into flutter:master with commit 1e2322c Dec 13, 2024
146 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
1c15d6c 
…cold_test.dart`) (flutter/flutter#160258)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
0070a32 
…cold_test.dart`) (flutter/flutter#160258)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 14, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
42e9eac 
…cold_test.dart`) (flutter/flutter#160258)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 15, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
a473e19 
…cold_test.dart`) (flutter/flutter#160258)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 15, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
6b4ccab 
…cold_test.dart`) (flutter/flutter#160258)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
7ac5007 
…cold_test.dart`) (flutter/flutter#160258)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
cc6966f 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
32a317e 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
8d18818 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
b48bdaa 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
d4704e2 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
fa50e1b 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
920366d 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
27821dc 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
1eb1825 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
84c1c68 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
2ec0183 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
ea40a4a 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
3db69a2 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
634133c 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
3288258 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
36e7474 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
664fc1c 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
59e2dda 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
0fecd5c 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
ab7620f 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
c206f38 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
d99bf13 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
5987e78 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
4659a54 
…cold_test.dart`) (flutter/flutter#160258)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
1e2322c Enable explicit-package-dependencies (`resident_web_runner_…
c208f32 
…cold_test.dart`) (flutter/flutter#160258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey @bkonyi