Skip to content

Conversation

@harri35
Copy link
Contributor

@harri35 harri35 commented Dec 13, 2024

Fixes #160242

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@harri35
Copy link
Contributor Author

harri35 commented Dec 13, 2024

Two tests failed because of dependency downloads (and both seem unrelated to the document change):

Windows tool_integration_tests_2_9

"Server returned HTTP response code: 504" while downloading Gradle 8.9:

..
Exception: flutter build failed: 1
  Exception in thread "main" java.io.IOException: Server returned HTTP response code: 504 for URL: https://github.com/gradle/gradle-distributions/releases/download/v8.9.0/gradle-8.9-all.zip
  	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1997)
..

Logs: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8728664679088180113/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_2_9/stdout

It seems the server just temporarily failed; it downloads fine now. I guess there is nothing to do here except discuss if there should be a cache or some other way here which would eliminate the need for CI downloading it or at least reduce the amount of times it needs to be done.

Mac gradle_plugin_bundle_test

"Error: The downloaded Xcode app is possibly corrupted":

..
[W 2024-12-13 04:56:13] Xcode should be re-installed due to error failed to open /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/temp_653b993b-53c4-4b5a-991b-e826f66c0414_xcode.app/Contents/version.plist: open /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/temp_653b993b-53c4-4b5a-991b-e826f66c0414_xcode.app/Contents/version.plist: no such file or directory
..
[P12514 04:56:14.457 instancecache.go:196 I] Using instance cache at /Volumes/Work/s/w/ir/cache/cipd_cache/instances
[P12514 04:56:14.459 instancecache.go:435 I] [fetch] Cache hit for infra_internal/ios/xcode/mac:gnwbgR1c6kLYi9RC3LmbaNILYU7cZRfkxTbswj_GppgC
[P12514 04:56:14.607 deployer.go:303 I] [unzip] Deploying infra_internal/ios/xcode/mac:gnwbgR1c6kLYi9RC3LmbaNILYU7cZRfkxTbswj_GppgC into /Volumes/Work/s/w/ir/cache/osx_sdk/xcode_15a240d/tmp2806263878/Xcode.app(/)
..
[W 2024-12-13 05:02:10] Downloaded Xcode might be corrupted, going to retry... Error: The downloaded Xcode app is possibly corrupted. The app has been deleted. Please retry...
..

Logs: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8728664679246935201/+/u/install_xcode/install_xcode_from_cipd/stdout

The XCode installer was retrieved fine from a cache, but it turned out to be corrupted. While the retry message says it will redownload it, it just prefetched it from the same cache and seems to have gotten the same corrupted one again as it hit the same cache. The cache is corrupted? Seems to be similar to #157931

@harri35
Copy link
Contributor Author

harri35 commented Dec 13, 2024

@johnmccutchan FYI: I created a small PR to add information to the DeviceLab Readme that would help developers run tests better locally based on what we have learned so far.

@harri35
Copy link
Contributor Author

harri35 commented Dec 17, 2024

Merged in the new master, all tests fine now

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. f: gestures flutter/packages/flutter/gestures repository. a: desktop Running on desktop f: focus Focus traversal, gaining or losing focus d: docs/ flutter/flutter/docs, for contributors labels Dec 23, 2024
@harri35 harri35 force-pushed the fix/devicelab-additional-info-for-local-runs branch from f25ec1b to bacc304 Compare December 23, 2024 08:03
@github-actions github-actions bot removed a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. f: gestures flutter/packages/flutter/gestures repository. a: desktop Running on desktop f: focus Focus traversal, gaining or losing focus d: docs/ flutter/flutter/docs, for contributors labels Dec 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the DeviceLab README.md with updated warnings and info on how to run tests on a local machine

3 participants