Skip to content

Manual pub roll with flutter_tools patch #160174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 9 commits into from
Dec 16, 2024
Merged

Manual pub roll with flutter_tools patch #160174

auto-submit merged 9 commits into from
Dec 16, 2024

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Dec 12, 2024 •
edited
Loading

Fixes: #160055

@bkonyi
Manual pub roll with flutter_tools patch
a9e6983 
Handles update to package:archive 4.x from 3.x which introduced some
type changes.
@bkonyi bkonyi requested a review from matanlurey as a code owner December 12, 2024 16:13
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Dec 12, 2024
christopherfujino
christopherfujino approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

christopherfujino commented Dec 12, 2024

More errors, however:

warning • Unnecessary cast • dev/bots/suite_runners/run_framework_tests.dart:117:39 • unnecessary_cast
warning • Unnecessary cast • dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart:398:40 • unnecessary_cast
warning • Unnecessary cast • dev/devicelab/bin/tasks/build_android_host_app_with_module_source.dart:373:40 • unnecessary_cast
   info • Use 'const' with the constructor to improve performance • packages/flutter_tools/lib/src/base/os.dart:539:7 • prefer_const_constructors
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart:690:56 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/base/analyze_size_test.dart:79:54 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/base/analyze_size_test.dart:163:54 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/base/analyze_size_test.dart:253:98 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/base/os_test.dart:578:61 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_test.dart:41:42 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_test.dart:52:45 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_test.dart:83:49 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_test.dart:90:53 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_test.dart:119:49 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_test.dart:129:53 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_test.dart:177:42 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_validator_test.dart:531:59 • unnecessary_non_null_assertion
warning • The '!' will have no effect because the receiver can't be null • packages/flutter_tools/test/general.shard/intellij/intellij_validator_test.dart:567:56 • unnecessary_non_null_assertion

@christopherfujino
Copy link
Contributor

christopherfujino commented Dec 12, 2024

To fix the gradle lockfiles, you'll have to run this script:

https://github.com/flutter/flutter/blob/master/dev/tools/bin/generate_gradle_lockfiles.dart

With the invocation dart generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion.

This was referenced Dec 13, 2024
Closed
Closed
Merged
bkonyi added a commit to flutter/tests that referenced this pull request Dec 13, 2024
@bkonyi
Disable flutter_devtools.test (#434)
40113e2 
Unblocks package roll: flutter/flutter#160174
Tracked in flutter/flutter#160247
This was referenced Dec 13, 2024
Closed
Closed
christopherfujino
christopherfujino approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bkonyi added a commit to flutter/tests that referenced this pull request Dec 16, 2024
@bkonyi
Disable flutter_devtools_analysis.test
9ceca1f 
Unblocks package roll: flutter/flutter#160174
Tracked in flutter/flutter#160247
@bkonyi bkonyi mentioned this pull request Dec 16, 2024
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
6c07273 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
5732145 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
644454b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
23f027f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
4cdcb6f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
6046211 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
3c93679 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
d40f9c8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
c6df01f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
abb612c 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
5add339 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
8c138a9 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
b60c84d 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
52064f4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
3ccf133 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
cb941c4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
e1b4dd1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
fa8768a 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
0f7e45a 
)
victoreronmosele pushed a commit to victoreronmosele/tests that referenced this pull request Feb 5, 2025
@bkonyi @victoreronmosele
Disable flutter_devtools.test (flutter#434)
7f957e7 
Unblocks package roll: flutter/flutter#160174
Tracked in flutter/flutter#160247
victoreronmosele pushed a commit to victoreronmosele/tests that referenced this pull request Feb 5, 2025
@bkonyi @victoreronmosele
Disable flutter_devtools_analysis.test (flutter#435)
073c7ba 
Unblocks package roll: flutter/flutter#160174
Tracked in flutter/flutter#160247
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
e71a1e2 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
8782f29 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
ecbc893 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
f0b97ce 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
6159f2e Manual pub roll with flutter_tools patch (flutter/flutter#160174
c905452 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey Awaiting requested review from matanlurey

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package roll breaks flutter_tools

2 participants

@bkonyi @christopherfujino