Skip to content

Revert "Framework sends a11y message when enabling semantics (#159163)" #160039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Dec 10, 2024
Merged

Revert "Framework sends a11y message when enabling semantics (#159163)" #160039

auto-submit merged 1 commit into from
Dec 10, 2024

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Dec 10, 2024 •
edited
Loading

This reverts commit 1a2d6a3.

This is a straight revert as we are pivot away from using message channel, instead we will be adding api to dart:ui.
See flutter/engine#56691

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from matanlurey as a code owner December 10, 2024 17:58
@chunhtai chunhtai requested a review from hannah-hyj December 10, 2024 17:59
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Dec 10, 2024
@matanlurey
Copy link
Contributor

matanlurey commented Dec 10, 2024

This is a straight revert as we are pivot away from using message channel

Could you link or describe in the PR description what we'll be doing instead?

@chunhtai
Copy link
Contributor Author

chunhtai commented Dec 10, 2024

This is a straight revert as we are pivot away from using message channel

Could you link or describe in the PR description what we'll be doing instead?

Done

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 10, 2024
Merged via the queue into flutter:master with commit a893157 Dec 10, 2024
80 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
87385dd 
…(#159163)" (flutter/flutter#160039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
93d9f01 
…(#159163)" (flutter/flutter#160039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
49adaf0 
…(#159163)" (flutter/flutter#160039)
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
Closed
11 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
1b52c24 
…(#159163)" (flutter/flutter#160039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
0545069 
…(#159163)" (flutter/flutter#160039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
9411dc7 
…(#159163)" (flutter/flutter#160039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
242496e 
…(#159163)" (flutter/flutter#160039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
a893157 Revert "Framework sends a11y message when enabling semantics …
5656e65 
…(#159163)" (flutter/flutter#160039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chunhtai @matanlurey @hannah-hyj