Add handler for SemanticsAction.scrollToOffset
#159811
Conversation
github-actions
bot
added
a: text input
github-actions
bot
added
the
a: tests
| /// | ||
| /// The callback, if not `null`, should typically set the scroll offset of | ||
| /// the associated scrollable container to the given `targetOffset` without | ||
| /// animation as it is already animated by the caller: the iOS focus engine |
There was a problem hiding this comment.
isn't the animation controlled by flutter? how does the caller (I assume iOS) animate the scrollable?
There was a problem hiding this comment.
UIKit would create a display link that calls setContentOffset every frame with different scroll offsets. So the animation / curve is determined by UIKIt.
There was a problem hiding this comment.
(should I rephrase somehow to make this clear?)
There was a problem hiding this comment.
yes, some rephrasing can help
Do we translate all the setContentOffset to scrollToOffset call?
There was a problem hiding this comment.
Yeah. Made some minor adjustments to the last sentence.
| _physics = _configuration.getScrollPhysics(context); | ||
| _physics = physicsFromWidget?.applyTo(_physics) ?? _physics; |
There was a problem hiding this comment.
hmm if I apply the suggested change, is _physics going to be up to date for the expression before ??
There was a problem hiding this comment.
oh I didn't realize the applyTo uses _physics, in that case no, the suggestion is wrong, the original code is fine
|
|
||
| void _onScrollToOffset(Offset targetOffset) { | ||
| final double offset = switch (axis) { | ||
| Axis.horizontal => targetOffset.dx, |
There was a problem hiding this comment.
will there be cases where dx and dy both none zero?
There was a problem hiding this comment.
Not currently. In the iOS implementation, every semantics node is only scrollable in one axis I think, so iOS won't issue commands that would scroll both axes. If it does then I think we can't do anything other than just ignoring the unscrollable axis?
There was a problem hiding this comment.
oh ok, just want to double check there isn't any surprise.
2 participants
Also closes #159515
Looking at the google testing failurescl/703169955Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.