Revert "Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9… #15980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a test failure in the integration_ui_ios devicelab test. ``` stdout: [ +3 ms] 00:02 [32m+0[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size[0m stdout: [+8129 ms] 00:11 [32m+0[0m[31m -1[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size [1m[31m[E][0m[0m stdout: [ +5 ms] DriverError: Failed to fulfill Tap: Flutter application not responding stdout: [ ] Original error: TimeoutException after 0:00:07.500000: Future not completed stdout: [ ] Original stack trace: stdout: [ ] #0 FlutterDriver._sendCommand (package:flutter_driver/src/driver/driver.dart:324:18) stdout: [ ] stdout: [ ] flutter#1 FlutterDriver.tap (package:flutter_driver/src/driver/driver.dart:368:11) stdout: [ ] stdout: [ ] flutter#2 main.. (file:///[... snip ...]/flutter/dev/integration_tests/ui/test_driver/keyboard_resize_test.dart:34:20) ``` This reverts commit 067be92.
a-siva
approved these changes
Mar 27, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This caused a test failure in the integration_ui_ios devicelab test. ``` stdout: [ +3 ms] 00:02 [32m+0[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size[0m stdout: [+8129 ms] 00:11 [32m+0[0m[31m -1[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size [1m[31m[E][0m[0m stdout: [ +5 ms] DriverError: Failed to fulfill Tap: Flutter application not responding stdout: [ ] Original error: TimeoutException after 0:00:07.500000: Future not completed stdout: [ ] Original stack trace: stdout: [ ] #0 FlutterDriver._sendCommand (package:flutter_driver/src/driver/driver.dart:324:18) stdout: [ ] stdout: [ ] flutter#1 FlutterDriver.tap (package:flutter_driver/src/driver/driver.dart:368:11) stdout: [ ] stdout: [ ] flutter#2 main.. (file:///[... snip ...]/flutter/dev/integration_tests/ui/test_driver/keyboard_resize_test.dart:34:20) ``` This reverts commit 067be92.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ab (#15885)"
This caused a test failure in the integration_ui_ios devicelab test.
This reverts commit 067be92.