Enabled provisioning updates and device registration during building xcarchive. #159622

czarny · 2024-11-29T23:06:34Z

Provisioning updates and device registration were disabled when development team was specified in the xcode project. This lead to build error when provisioning profile was not present. Now provisioning updates and device registration are enabled when tool builds codesigned archive. This will allow to build the iOS version of app without launching xcode in order to enforce provisioning profile updates.

Issues fixed by this PR.

Improved allowProvisioningUpdates & auth key support #139212
Flutter build IPA with --export-options-plist not working #113977
allow passing build flags to xcodebuild command for building Apple apps. #121702 (partly because author asks for possibility of passing xcode flags like allowProvisioningUpdates)

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
All existing and new tests are passing.

google-cla · 2024-11-29T23:06:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

flutter-dashboard · 2024-11-29T23:06:57Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

…xcarchive. Provisioning updates and device registration were disabled when development team was specified in the xcode project. This lead to build error when provisioning profile was not present. Now provisioning updates and device registration are enabled when tool builds codesigned archive.

czarny · 2025-01-08T09:09:18Z

Hi, I did sign the CLA but after sending the PR. Please take on the check list https://github.com/flutter/flutter/pull/159622/checks?check_run_id=33761072081

…

Wiadomość napisana przez cedvdb ***@***.***> w dniu 7 sty 2025, o godz. 17:56: @czarny <https://github.com/czarny> You did not sign the CLA — Reply to this email directly, view it on GitHub <#159622 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJNWNNVNZKVKYRXREBHEZD2JQBNVAVCNFSM6AAAAABSX3RRMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVG44TGOBVGM>. You are receiving this because you were mentioned.

czarny · 2025-01-08T11:08:08Z

@cedvdb I merged latest master to the PR.

cedvdb · 2025-01-08T13:49:13Z

I believe format ran on one of your file, that may be an issue for review. I've requested a review on flutter discord

cedvdb · 2025-01-18T00:13:31Z

@jmagman requesting a review

jmagman · 2025-01-18T00:18:41Z

@vashworth could you take a look at this logic?

vashworth

This makes sense to me.

Currently, Flutter only add -allowProvisioningUpdates and -allowProvisioningDeviceRegistration if Flutter is also setting DEVELOPMENT_TEAM. However, DEVELOPMENT_TEAM may be set in the project settings, in which case Flutter doesn't set it and therefore -allowProvisioningUpdates/-allowProvisioningDeviceRegistration don't get used. This PR fixes that and uses those flags if codesigning is enabled.

Thanks for the contribution @czarny!

auto-submit · 2025-01-22T16:22:01Z

auto label is removed for flutter/flutter/159622, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

cbracken

lgtm from me too for the second review.

…uilding xcarchive. (flutter/flutter#159622)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) Manual roll requested by [email protected] flutter/flutter@b9e86a5...b2f515f 2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035) 2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564) 2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020) 2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855) 2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788) 2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925) 2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019) 2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768) 2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775) 2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468) 2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015) 2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774) 2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577) 2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016) 2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622) 2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537) 2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991) 2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650) 2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992) 2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989) 2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024) 2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981) 2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977) 2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705) 2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863) 2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841) 2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625) 2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824) 2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301) 2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825) 2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994) 2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656) 2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941) 2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717) 2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916) 2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811) 2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924) 2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789) 2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913) 2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914) 2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917) 2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785) If this roll has caused a breakage, revert this CL and stop the roller ...

…xcarchive. (flutter#159622) Provisioning updates and device registration were disabled when development team was specified in the xcode project. This lead to build error when provisioning profile was not present. Now provisioning updates and device registration are enabled when tool builds codesigned archive. This will allow to build the iOS version of app without launching xcode in order to enforce provisioning profile updates. Issues fixed by this PR. * flutter#139212 * flutter#113977 * flutter#121702 (partly because author asks for possibility of passing xcode flags like allowProvisioningUpdates) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] All existing and new tests are passing.

…uilding xcarchive. (flutter/flutter#159622)

) Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) Manual roll requested by [email protected] flutter/flutter@b9e86a5...b2f515f 2025-01-22 [email protected] Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035) 2025-01-22 [email protected] `const AnimationStyle` (flutter/flutter#160564) 2025-01-22 [email protected] Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020) 2025-01-22 [email protected] [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855) 2025-01-22 [email protected] Experiment with a `files-changed.json` per PR (flutter/flutter#161788) 2025-01-22 [email protected] Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925) 2025-01-22 [email protected] Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019) 2025-01-22 [email protected] Adds cupertino picker semantics test (flutter/flutter#161768) 2025-01-22 [email protected] [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775) 2025-01-22 [email protected] fix: Add enabled property for search anchor named constructor (flutter/flutter#161468) 2025-01-22 [email protected] Roll pub packages (flutter/flutter#162015) 2025-01-22 [email protected] [web] Remove spam from test output (flutter/flutter#161774) 2025-01-22 [email protected] Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577) 2025-01-22 [email protected] Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016) 2025-01-22 [email protected] Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622) 2025-01-22 [email protected] [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537) 2025-01-22 [email protected] Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991) 2025-01-22 [email protected] Fix incorrect [enabled] documentation (flutter/flutter#161650) 2025-01-22 [email protected] Add `windows_host_engine_test`. (flutter/flutter#161992) 2025-01-22 [email protected] Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989) 2025-01-22 [email protected] Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024) 2025-01-22 [email protected] [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981) 2025-01-22 [email protected] Merge changelog for 3.27.3 release (flutter/flutter#161977) 2025-01-21 [email protected] Remove FlKeyboardViewDelegate (flutter/flutter#161705) 2025-01-21 [email protected] Fix documentation of Flow.clipBehavior (flutter/flutter#161863) 2025-01-21 [email protected] [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841) 2025-01-21 [email protected] [Impeller] backfilling TextContents unit tests (flutter/flutter#161625) 2025-01-21 [email protected] Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824) 2025-01-21 [email protected] fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301) 2025-01-21 [email protected] Get `et` working for local web engine builds. (flutter/flutter#161825) 2025-01-21 [email protected] Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994) 2025-01-21 [email protected] Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656) 2025-01-21 [email protected] Don't crash flutter tool if Chrome is not available (flutter/flutter#154941) 2025-01-21 [email protected] Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717) 2025-01-21 [email protected] [native assets] Cleanup dead code 2 (flutter/flutter#161916) 2025-01-21 [email protected] Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811) 2025-01-21 [email protected] Roll pub packages (flutter/flutter#161924) 2025-01-21 [email protected] Make `PipelineOwner` a `base` class (flutter/flutter#161789) 2025-01-20 [email protected] [native assets] Cleanup dead code (flutter/flutter#161913) 2025-01-20 [email protected] Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914) 2025-01-20 [email protected] [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917) 2025-01-19 [email protected] Update documentation on what display information is provided. (flutter/flutter#161785) If this roll has caused a breakage, revert this CL and stop the roller ...

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 29, 2024

czarny force-pushed the master branch from 2c579f7 to b60e4a5 Compare November 29, 2024 23:10

czarny force-pushed the master branch 4 times, most recently from f890fc1 to d0e7173 Compare December 2, 2024 00:36

bkonyi added the team-ios Owned by iOS platform team label Dec 6, 2024

cedvdb mentioned this pull request Jan 7, 2025

Enabled provisioning updates and device registration during building xcarchive #161246

Closed

9 tasks

Merge remote-tracking branch 'flutter/master'

4f45d01

czarny force-pushed the master branch from b702687 to 4f45d01 Compare January 8, 2025 14:21

jmagman requested a review from vashworth January 18, 2025 00:18

vashworth approved these changes Jan 22, 2025

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

vashworth requested a review from cbracken January 22, 2025 16:26

cbracken approved these changes Jan 22, 2025

View reviewed changes

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit bot added this pull request to the merge queue Jan 22, 2025

Merged via the queue into flutter:master with commit e33e4f0 Jan 22, 2025
167 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

engine-flutter-autoroll mentioned this pull request Jan 22, 2025

Manual roll Flutter from b9e86a565f92 to b2f515f45ef5 (42 revisions) flutter/packages#8482

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025

e33e4f0 Enabled provisioning updates and device registration during b…

69331c4

…uilding xcarchive. (flutter/flutter#159622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

e33e4f0 Enabled provisioning updates and device registration during b…

b02ec88

…uilding xcarchive. (flutter/flutter#159622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

e33e4f0 Enabled provisioning updates and device registration during b…

e49edf1

…uilding xcarchive. (flutter/flutter#159622)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

e33e4f0 Enabled provisioning updates and device registration during b…

e99a4e9

…uilding xcarchive. (flutter/flutter#159622)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enabled provisioning updates and device registration during building xcarchive. #159622

Enabled provisioning updates and device registration during building xcarchive. #159622

Uh oh!

czarny commented Nov 29, 2024 •

edited

Loading

Uh oh!

google-cla bot commented Nov 29, 2024

Uh oh!

flutter-dashboard bot commented Nov 29, 2024

Uh oh!

czarny commented Jan 8, 2025 via email •

edited

Loading

Uh oh!

czarny commented Jan 8, 2025

Uh oh!

cedvdb commented Jan 8, 2025 •

edited

Loading

Uh oh!

cedvdb commented Jan 18, 2025

Uh oh!

jmagman commented Jan 18, 2025

Uh oh!

vashworth left a comment

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

cbracken left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Enabled provisioning updates and device registration during building xcarchive. #159622

Enabled provisioning updates and device registration during building xcarchive. #159622

Uh oh!

Conversation

czarny commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented Nov 29, 2024

Uh oh!

flutter-dashboard bot commented Nov 29, 2024

Uh oh!

czarny commented Jan 8, 2025 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

czarny commented Jan 8, 2025

Uh oh!

cedvdb commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cedvdb commented Jan 18, 2025

Uh oh!

jmagman commented Jan 18, 2025

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 22, 2025

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

czarny commented Nov 29, 2024 •

edited

Loading

czarny commented Jan 8, 2025 via email •

edited

Loading

cedvdb commented Jan 8, 2025 •

edited

Loading