Reverts "Roll Flutter Engine from 6f941c961b05 to 202506d686e3 (10 revisions) (#159345)" #159360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Nov 22, 2024
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
auto-submit
bot
removed
the
revert of
Contributor
Author
|
auto label is removed for flutter/flutter/159360, Failed to enqueue flutter/flutter/159360 with HTTP 400: GraphQL mutate failed. |
hannah-hyj
deleted the
revert_fc2254cca8bef21a9bc4ee43adfb96409967acbc
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 23, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 23, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 24, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 24, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 25, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 25, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 25, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 25, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 26, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 26, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 26, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 26, 2024
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
…3 (10 revisions) (#159345)" (flutter/flutter#159360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #159345
Initiated by: hannah-hyj
Reason for reverting: tree is red on " Linux_build_test flutter_gallery__transition_perf_hybrid" after engine auto roll
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
flutter/engine@6f941c9...202506d
2024-11-22 [email protected] [Impeller] cache and reuse openGL framebuffer attachments. (flutter/engine#56746)
2024-11-22 [email protected] Roll Skia from 700e685861c8 to e7caf38140ce (25 revisions) (flutter/engine#56756)
2024-11-22 [email protected] Roll Dart SDK from c1106f7e4cde to 141291fd570d (1 revision) (flutter/engine#56748)
2024-11-22 [email protected] [engine] more consistently flush dart event loop, run vsync callback immediately (flutter/engine#56738)
2024-11-22 [email protected] Extract backend-specific code in ShellTestPlatformView (flutter/engine#56722)
2024-11-22 [email protected] Eliminate ShellTestPlatformView::BackendType::kDefaultBackendType (flutter/engine#56744)
2024-11-22 [email protected] Roll Skia from 2614590b4f32 to 700e685861c8 (1 revision) (flutter/engine#56725)
2024-11-22 [email protected] Roll Dart SDK from b36e4d731d67 to c1106f7e4cde (12 revisions) (flutter/engine#56742)
2024-11-22 [email protected] [Impeller] libImpeller: A C++ wrapper to the Impeller API. (flutter/engine#56682)
2024-11-21 [email protected] [Impeller] Run simulator tests with Impeller enabled. (flutter/engine#56740)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md