Skip to content

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Nov 22, 2024

Reverts: #159348

Initiated by: hannah-hyj

Reason for reverting: tree is red on " Linux_build_test flutter_gallery__transition_perf_hybrid" after this PR

Original PR Author: engine-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

flutter/engine@202506d...9384df4

2024-11-22 [email protected] Roll Fuchsia Linux SDK from zhFzwYCH-N_wasTnM... to D5CBHuB2c-v3Zai-c... (flutter/engine#56757)
2024-11-22 [email protected] Roll Dart SDK from 141291fd570d to 8b65a7a628e2 (1 revision) (flutter/engine#56755)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zhFzwYCH-N_w to D5CBHuB2c-v3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Nov 22, 2024
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Nov 22, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@auto-submit auto-submit bot added this pull request to the merge queue Nov 22, 2024
@auto-submit auto-submit bot closed this Nov 22, 2024
@auto-submit auto-submit bot deleted the revert_9cffcefa15ceac3d72b1a5150fb180c1592cebcc branch November 22, 2024 23:53
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Nov 22, 2024
@hannah-hyj hannah-hyj restored the revert_9cffcefa15ceac3d72b1a5150fb180c1592cebcc branch November 22, 2024 23:53
@hannah-hyj hannah-hyj reopened this Nov 22, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Nov 22, 2024
@auto-submit auto-submit bot closed this Nov 22, 2024
@auto-submit auto-submit bot deleted the revert_9cffcefa15ceac3d72b1a5150fb180c1592cebcc branch November 22, 2024 23:54
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Nov 22, 2024
@hannah-hyj hannah-hyj restored the revert_9cffcefa15ceac3d72b1a5150fb180c1592cebcc branch November 22, 2024 23:54
@hannah-hyj hannah-hyj reopened this Nov 22, 2024
@hannah-hyj hannah-hyj added this pull request to the merge queue Nov 22, 2024
@auto-submit
Copy link
Contributor Author

auto-submit bot commented Nov 22, 2024

auto label is removed for flutter/flutter/159359, Failed to enqueue flutter/flutter/159359 with HTTP 400: GraphQL mutate failed.

@auto-submit auto-submit bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Nov 22, 2024
Merged via the queue into master with commit 0d8c57a Nov 22, 2024
10 of 12 checks passed
@hannah-hyj hannah-hyj deleted the revert_9cffcefa15ceac3d72b1a5150fb180c1592cebcc branch November 22, 2024 23:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 26, 2024
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
11 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants