Skip to content

Fix SafeArea DartPad sample #159344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Dec 9, 2024
Merged

Fix SafeArea DartPad sample #159344

auto-submit merged 3 commits into from
Dec 9, 2024

Conversation

@nate-thegrate
Copy link
Contributor

@nate-thegrate nate-thegrate commented Nov 22, 2024

This pull request fixes a bug I introduced in #158019.


Before

RenderFlex overflowed

After

RenderFlex overflowed



@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 22, 2024
@goderbauer goderbauer requested a review from chunhtai November 26, 2024 23:05
chunhtai
chunhtai reviewed Nov 27, 2024
View reviewed changes
examples/api/lib/widgets/safe_area/safe_area.0.dart Outdated
Text(label),
Builder(
builder: (BuildContext context) => Slider(
key: ValueKey<Inset>(this),
Copy link
Contributor

@chunhtai chunhtai Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Contributor Author

@nate-thegrate nate-thegrate Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it to make the testing easier… now that you mention it, I could probably just loop through every slider that the finder returns.

Copy link
Contributor Author

@nate-thegrate nate-thegrate Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factored this out in dfef025!

@nate-thegrate nate-thegrate marked this pull request as draft November 27, 2024 22:32
@nate-thegrate nate-thegrate marked this pull request as ready for review December 3, 2024 00:07
chunhtai
chunhtai approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Dec 9, 2024
Merged via the queue into flutter:master with commit dc58093 Dec 9, 2024
39 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@nate-thegrate nate-thegrate deleted the fix-safearea-example branch December 9, 2024 19:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
bc14ada
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
0c95ae4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
6b76e96
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
ce500c6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
7e656d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
ecc67f3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
3c51d2c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
56cb4b0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
1a92f66
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
Closed
11 tasks
@Piinks Piinks mentioned this pull request Dec 13, 2024
Closed
@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
3a6c509
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
139a7f9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
e6646c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
050f61b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
dc58093 Fix SafeArea DartPad sample (flutter/flutter#159344)
3b18d80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SafeArea code sample not rendering properly

2 participants

@nate-thegrate @chunhtai