Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 19, 2024

Label PRs that touch any *android* files in flutter_tool with platform-android. In particular this should catch the template android directories.

Labeler log: https://github.com/flutter/flutter/actions/runs/11921551623/job/33225914301?pr=159166#step:2:240

Included files
$ git ls-files 'packages/flutter_tools/*android**'
packages/flutter_tools/ide_templates/intellij/dev/manual_tests/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/flutter_gallery/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/hello_world/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/platform_channel/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/platform_view/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/stocks/android.iml.copy.tmpl
packages/flutter_tools/lib/src/android/README.md
packages/flutter_tools/lib/src/android/adb.dart
packages/flutter_tools/lib/src/android/android.dart
packages/flutter_tools/lib/src/android/android_builder.dart
packages/flutter_tools/lib/src/android/android_console.dart
packages/flutter_tools/lib/src/android/android_device.dart
packages/flutter_tools/lib/src/android/android_device_discovery.dart
packages/flutter_tools/lib/src/android/android_emulator.dart
packages/flutter_tools/lib/src/android/android_sdk.dart
packages/flutter_tools/lib/src/android/android_studio.dart
packages/flutter_tools/lib/src/android/android_studio_validator.dart
packages/flutter_tools/lib/src/android/android_workflow.dart
packages/flutter_tools/lib/src/android/application_package.dart
packages/flutter_tools/lib/src/android/build_validation.dart
packages/flutter_tools/lib/src/android/deferred_components_gen_snapshot_validator.dart
packages/flutter_tools/lib/src/android/deferred_components_prebuild_validator.dart
packages/flutter_tools/lib/src/android/deferred_components_validator.dart
packages/flutter_tools/lib/src/android/gradle.dart
packages/flutter_tools/lib/src/android/gradle_errors.dart
packages/flutter_tools/lib/src/android/gradle_utils.dart
packages/flutter_tools/lib/src/android/java.dart
packages/flutter_tools/lib/src/android/migrations/android_studio_java_gradle_conflict_migration.dart
packages/flutter_tools/lib/src/android/migrations/cmake_android_16k_pages_migration.dart
packages/flutter_tools/lib/src/android/migrations/min_sdk_version_migration.dart
packages/flutter_tools/lib/src/android/migrations/multidex_removal_migration.dart
packages/flutter_tools/lib/src/android/migrations/top_level_gradle_build_file_migration.dart
packages/flutter_tools/lib/src/build_system/targets/android.dart
packages/flutter_tools/lib/src/commands/android_analyze.dart
packages/flutter_tools/lib/src/isolated/native_assets/android/native_assets.dart
packages/flutter_tools/templates/app_shared/android-java.tmpl/app/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/app/src/main/java/androidIdentifier/MainActivity.java.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/src/main/kotlin/androidIdentifier/MainActivity.kt.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/.gitignore
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/debug/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/drawable-v21/launch_background.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/drawable/launch_background.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-hdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-mdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xxhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/values-night/styles.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/values/styles.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/profile/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/gradle.properties.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/gradle/wrapper/gradle-wrapper.properties.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/settings.gradle.kts.tmpl
packages/flutter_tools/templates/module/android/deferred_component/build.gradle.tmpl
packages/flutter_tools/templates/module/android/deferred_component/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/gradle/build.gradle.tmpl
packages/flutter_tools/templates/module/android/gradle/gradle.properties.tmpl
packages/flutter_tools/templates/module/android/gradle/settings.gradle.tmpl
packages/flutter_tools/templates/module/android/gradle/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/java/androidIdentifier/host/MainActivity.java.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/drawable/launch_background.xml
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/mipmap-hdpi/ic_launcher.png
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/values/styles.xml
packages/flutter_tools/templates/module/android/host_app_editable/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/android/host_app_ephemeral/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/flutter.iml.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/include_flutter.groovy.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/common/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/src/main/java/androidIdentifier/pluginClass.java.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/src/test/java/androidIdentifier/pluginClassTest.java.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/src/main/kotlin/androidIdentifier/pluginClass.kt.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/src/test/kotlin/androidIdentifier/pluginClassTest.kt.tmpl
packages/flutter_tools/templates/plugin/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin/android.tmpl/settings.gradle.tmpl
packages/flutter_tools/templates/plugin/android.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/plugin_ffi/android.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin_ffi/android.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin_shared/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin_shared/android.tmpl/settings.gradle.tmpl
packages/flutter_tools/templates/plugin_shared/android.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/test/android_java11_integration.shard/android_dependency_version_checking_test.dart
packages/flutter_tools/test/android_preview_integration.shard/README.md
packages/flutter_tools/test/android_preview_integration.shard/flutter_build_preview_sdk_test.dart
packages/flutter_tools/test/commands.shard/hermetic/android_analyze_test.dart
packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart
packages/flutter_tools/test/general.shard/android/android_device_discovery_test.dart
packages/flutter_tools/test/general.shard/android/android_device_port_forwarder_test.dart
packages/flutter_tools/test/general.shard/android/android_device_start_test.dart
packages/flutter_tools/test/general.shard/android/android_device_test.dart
packages/flutter_tools/test/general.shard/android/android_emulator_test.dart
packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart
packages/flutter_tools/test/general.shard/android/android_install_test.dart
packages/flutter_tools/test/general.shard/android/android_project_migration_test.dart
packages/flutter_tools/test/general.shard/android/android_sdk_test.dart
packages/flutter_tools/test/general.shard/android/android_studio_test.dart
packages/flutter_tools/test/general.shard/android/android_studio_validator_test.dart
packages/flutter_tools/test/general.shard/android/android_workflow_test.dart
packages/flutter_tools/test/general.shard/android/build_validation_test.dart
packages/flutter_tools/test/general.shard/android/deferred_components_gen_snapshot_validator_test.dart
packages/flutter_tools/test/general.shard/android/deferred_components_prebuild_validator_test.dart
packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart
packages/flutter_tools/test/general.shard/android/gradle_find_bundle_test.dart
packages/flutter_tools/test/general.shard/android/gradle_test.dart
packages/flutter_tools/test/general.shard/android/gradle_utils_test.dart
packages/flutter_tools/test/general.shard/android/java_test.dart
packages/flutter_tools/test/general.shard/android/migration/cmake_android_16k_pages_migration_test.dart
packages/flutter_tools/test/general.shard/android/template_test.dart
packages/flutter_tools/test/general.shard/android_plugin_test.dart
packages/flutter_tools/test/general.shard/build_system/targets/android_test.dart
packages/flutter_tools/test/general.shard/isolated/android/native_assets_test.dart
packages/flutter_tools/test/integration.shard/android_e2e_api_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_daemon_cache_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_deprecated_plugin_apply_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_flutter_source_path_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_java_version_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_legacy_flutter_plugins_strings_in_comments_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_outputs_app_link_settings_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_print_build_variants_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_compilesdkversion_mismatch_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_example_app_build_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_ndkversion_mismatch_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_new_output_dir_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart
packages/flutter_tools/test/integration.shard/flutter_build_android_app_project_builddir_test.dart
packages/flutter_tools/test/integration.shard/gradle_non_android_plugin_test.dart
packages/flutter_tools/test/src/android_common.dart

Expand #158970

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 19, 2024
@jmagman
Copy link
Member Author

jmagman commented Nov 19, 2024

@andrewkolos If you see tools PRs that are missing platform labels, please feel free to edit the labeler and add paths!

@jmagman jmagman requested a review from reidbaker November 19, 2024 20:55
@andrewkolos
Copy link
Contributor

@andrewkolos If you see tools PRs that are missing platform labels, please feel free to edit the labeler and add paths!

TIL about .github/labeler.yml. Thanks!

Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Nov 19, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2024
Merged via the queue into flutter:master with commit c12f750 Nov 19, 2024
34 checks passed
@jmagman jmagman deleted the android-label branch November 20, 2024 00:36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 21, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 21, 2024
Roll Flutter from 8536b96 to 93d772c (37 revisions)

flutter/flutter@8536b96...93d772c

2024-11-21 [email protected] Added additional logging to `_listCoreDevices` (flutter/flutter#159275)
2024-11-21 [email protected] Roll Flutter Engine from 78b87f3fe023 to d1a08064e193 (1 revision) (flutter/flutter#159280)
2024-11-21 [email protected] Shut down DevTools and DDS processes if flutter_tools is killed by a signal (flutter/flutter#159238)
2024-11-21 [email protected] Remove `RepaintBoundary` that is no longer needed. (flutter/flutter#159232)
2024-11-21 [email protected] Try a speculative fix for Gradle OOMs. (flutter/flutter#159234)
2024-11-21 [email protected] On-device Widget Inspector button exits widget selection (flutter/flutter#158219)
2024-11-21 [email protected] Roll Flutter Engine from 523d381893c8 to 78b87f3fe023 (2 revisions) (flutter/flutter#159270)
2024-11-21 [email protected] Remove `firebase_abstract_method_smoke_test` (flutter/flutter#159145)
2024-11-21 [email protected] Roll Packages from e95f6d8 to 913b99e (7 revisions) (flutter/flutter#159268)
2024-11-21 [email protected] Roll Flutter Engine from 69c325513a65 to 523d381893c8 (3 revisions) (flutter/flutter#159263)
2024-11-21 [email protected] [flutter_tools] opt iOS/macOS apps out of Metal API validation via migrator, update templates in repo. (flutter/flutter#159228)
2024-11-21 [email protected] Scribe Android handwriting text input (flutter/flutter#148784)
2024-11-21 [email protected] Terminate non-detached test devices on `flutter run` completion (flutter/flutter#159170)
2024-11-21 [email protected] Un-skip tests that use `flutter build apk`. (flutter/flutter#159231)
2024-11-20 [email protected] Roll Flutter Engine from 2d32cf3a7971 to 69c325513a65 (1 revision) (flutter/flutter#159229)
2024-11-20 [email protected] Roll Flutter Engine from 3828681d1f86 to 2d32cf3a7971 (3 revisions) (flutter/flutter#159226)
2024-11-20 [email protected] Roll Flutter Engine from 3245c8976976 to 3828681d1f86 (1 revision) (flutter/flutter#159217)
2024-11-20 [email protected] Add `--dry-run` to `dev/bots/test.dart`. (flutter/flutter#158956)
2024-11-20 [email protected] Add docs for setting up Android Studio to auto format Kotlin code (flutter/flutter#159209)
2024-11-20 [email protected] Roll Flutter Engine from 80d77505fdde to 3245c8976976 (1 revision) (flutter/flutter#159214)
2024-11-20 [email protected] Fix: The enableFeedback property of InkWell cannot be set to a nullabâ�¦ (flutter/flutter#158907)
2024-11-20 [email protected] Roll Flutter Engine from 3f19207e820e to 80d77505fdde (1 revision) (flutter/flutter#159210)
2024-11-20 [email protected] Roll Packages from fc4adc7 to e95f6d8 (6 revisions) (flutter/flutter#159201)
2024-11-20 [email protected] Remove dependency on [Target] and instead operate on [Architecture] (flutter/flutter#159196)
2024-11-20 [email protected] Fix git command in Quality-Assurance.md (flutter/flutter#155146)
2024-11-20 [email protected] Roll Flutter Engine from 7eb87547cbc6 to 3f19207e820e (4 revisions) (flutter/flutter#159176)
2024-11-20 [email protected] Make `runner` non-nullable as it always is. (flutter/flutter#159156)
2024-11-19 [email protected] Update Material 3 `CircularProgressIndicator` for new visual style (flutter/flutter#158104)
2024-11-19 [email protected] Roll Flutter Engine from 4ff696b555dc to 7eb87547cbc6 (3 revisions) (flutter/flutter#159168)
2024-11-19 [email protected] Add platform-android label for all flutter_tools *android* files (flutter/flutter#159166)
2024-11-19 [email protected] Roll Flutter Engine from d5820a638885 to 4ff696b555dc (1 revision) (flutter/flutter#159164)
2024-11-19 [email protected] Reland Add UI Benchmarks (flutter/flutter#153368)
2024-11-19 [email protected] fix lint usage of `task` inside `resolve_dependecies.gradle` file (flutter/flutter#158022)
2024-11-19 [email protected] Roll Flutter Engine from cff1e751f853 to d5820a638885 (5 revisions) (flutter/flutter#159155)
2024-11-19 [email protected] Removing redundant backticks in `flutter\packages\flutter_tools\gradle\gradle.kts` (flutter/flutter#159051)
2024-11-19 [email protected] Fixes initial validation with AutovalidateMode.always on first build (flutter/flutter#156708)
2024-11-19 [email protected] Introduce new Material 3 `Slider` shapes (flutter/flutter#152237)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
11 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2025
`git ls-files "packages/flutter_tools/*android*'"` returns nothing. Fix
typo from #159166.

This caused #169544 to not get
the correct label.



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
`git ls-files "packages/flutter_tools/*android*'"` returns nothing. Fix
typo from flutter#159166.

This caused flutter#169544 to not get
the correct label.



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
`git ls-files "packages/flutter_tools/*android*'"` returns nothing. Fix
typo from flutter#159166.

This caused flutter#169544 to not get
the correct label.



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
`git ls-files "packages/flutter_tools/*android*'"` returns nothing. Fix
typo from flutter#159166.

This caused flutter#169544 to not get
the correct label.



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants