[CP-beta][ tool ] Don't throw StateError when DDS fails to start #159079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started happening after moving DDS to launch from `dart development-service` rather than `DartDevelopmentService` (see 33b402d) . This state error was originally meant to be thrown when some string parsing failed, but is currently wrapping the `DartDevelopmentServiceException`. Fixes flutter#158537
Author
|
@bkonyi please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
tool
bkonyi
requested review from
christopherfujino and
reidbaker
and removed request for
christopherfujino
reidbaker
approved these changes
Dec 2, 2024
christopherfujino
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/159079, Failed to enqueue flutter/flutter/159079 with HTTP 400: GraphQL mutate failed. |
auto-submit
bot
removed
the
autosubmit
christopherfujino
merged commit 3264426
into
flutter:flutter-3.27-candidate.0
122 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#158537
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Avoid rethrowing
DartDevelopmentServiceExceptions asStateErrors when the Dart Development Service fails to start due to the target shutting down.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Currently one of the top tool crashers on the beta branch. The crash is harmless and shouldn't impact user workflows, but causes significant noise.
Workaround:
Is there a workaround for this issue?
No workaround available.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Hard to replicate the original issue consistently, but in theory: start applications and immediately shut them down before DDS can finish starting.