Roll Flutter Engine from 4878f1c9ed1c to d0f0526827f0 (3 revisions) #159055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Nov 17, 2024
auto-submit
bot
removed
the
autosubmit
Contributor
Author
|
Commit queue failed; closing this roll. |
github-merge-queue
bot
removed this pull request from the merge queue due to a manual request
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-ddc3d9c7-47cb-411a-9e21-e26d857c097f-1731886761
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@4878f1c...d0f0526
2024-11-17 [email protected] iOS,macOS: Fix string constant declarations (flutter/engine#56661)
2024-11-17 [email protected] iOS: Make FlutterViewController.engine a strong ref (flutter/engine#56663)
2024-11-17 [email protected] iOS: Clean up uses of string literal constants (flutter/engine#56658)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md