-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix NavigationBar example overflow alignment #159034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NavigationBar example overflow alignment #159034
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
562e76c to
4ed6f02
Compare
4ed6f02 to
93206e0
Compare
TahaTesser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bleroux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
flutter/flutter@0e2d55e...b3818f6 2024-11-18 [email protected] Roll Flutter Engine from a63841d0c64b to f365c9f5dce3 (1 revision) (flutter/flutter#159064) 2024-11-18 [email protected] Roll Flutter Engine from 4878f1c9ed1c to a63841d0c64b (8 revisions) (flutter/flutter#159057) 2024-11-17 [email protected] Roll Flutter Engine from 4c1eb8cacb95 to 4878f1c9ed1c (1 revision) (flutter/flutter#159050) 2024-11-17 [email protected] Roll Flutter Engine from 9d0720a7b0ec to 4c1eb8cacb95 (1 revision) (flutter/flutter#159049) 2024-11-17 [email protected] Roll Flutter Engine from 6f9854ad6ed7 to 9d0720a7b0ec (2 revisions) (flutter/flutter#159047) 2024-11-17 [email protected] Roll Flutter Engine from 40000c742910 to 6f9854ad6ed7 (2 revisions) (flutter/flutter#159041) 2024-11-16 [email protected] Fix NavigationBar example overflow alignment (flutter/flutter#159034) 2024-11-16 [email protected] Roll Flutter Engine from 908061196148 to 40000c742910 (1 revision) (flutter/flutter#159038) 2024-11-16 [email protected] Roll Flutter Engine from 85d445e3cf78 to 908061196148 (3 revisions) (flutter/flutter#159032) 2024-11-16 [email protected] Roll Flutter Engine from 1800193ba961 to 85d445e3cf78 (1 revision) (flutter/flutter#159020) 2024-11-16 [email protected] Roll Flutter Engine from 98c3b7f8d1a7 to 1800193ba961 (1 revision) (flutter/flutter#159019) 2024-11-16 [email protected] Roll Flutter Engine from f23832175b7a to 98c3b7f8d1a7 (1 revision) (flutter/flutter#159017) 2024-11-16 [email protected] Roll Flutter Engine from f649330affa8 to f23832175b7a (1 revision) (flutter/flutter#159016) 2024-11-16 [email protected] Roll Flutter Engine from 619804c0fbb7 to f649330affa8 (47 revisions) (flutter/flutter#159015) 2024-11-16 [email protected] Marks Linux web_benchmarks_skwasm_st to be unflaky (flutter/flutter#158563) 2024-11-16 [email protected] Marks Windows windows_desktop_impeller to be unflaky (flutter/flutter#158565) 2024-11-15 [email protected] [flutter triage] Update list of frequent web contributors (flutter/flutter#159008) 2024-11-15 [email protected] Switch `flutter_build_apk_health_tests` to use a subset of current tests. (flutter/flutter#159004) 2024-11-15 [email protected] Make the focus node on SelectableRegion optional. (flutter/flutter#158994) 2024-11-15 [email protected] Style change in Flutter-Web-Triage.md (flutter/flutter#159006) 2024-11-15 [email protected] Refactor native asset integration into flutter tools (flutter/flutter#158932) 2024-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try running historically flaky tests first to make `flutter build apk` health tests time out more often? (#158967)" (flutter/flutter#158993) 2024-11-15 [email protected] [web] Remove the benchmarks of the HTML renderer (flutter/flutter#158520) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fix the NavigationBar example overflow alignment.
Before:
After:
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.