Skip to content

Conversation

@yaostyle
Copy link
Contributor

@yaostyle yaostyle commented Nov 16, 2024

Fix the NavigationBar example overflow alignment.

Before:

After:

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Nov 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 16, 2024
@yaostyle yaostyle force-pushed the fix_navigationbar_example branch from 562e76c to 4ed6f02 Compare November 16, 2024 19:53
@yaostyle yaostyle force-pushed the fix_navigationbar_example branch from 4ed6f02 to 93206e0 Compare November 16, 2024 20:03
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser requested a review from bleroux November 16, 2024 20:06
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2024
@auto-submit auto-submit bot added this pull request to the merge queue Nov 16, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2024
Merged via the queue into flutter:master with commit c2309f3 Nov 16, 2024
38 checks passed
@yaostyle yaostyle deleted the fix_navigationbar_example branch November 16, 2024 22:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2024
flutter/flutter@0e2d55e...b3818f6

2024-11-18 [email protected] Roll Flutter Engine from a63841d0c64b to f365c9f5dce3 (1 revision) (flutter/flutter#159064)
2024-11-18 [email protected] Roll Flutter Engine from 4878f1c9ed1c to a63841d0c64b (8 revisions) (flutter/flutter#159057)
2024-11-17 [email protected] Roll Flutter Engine from 4c1eb8cacb95 to 4878f1c9ed1c (1 revision) (flutter/flutter#159050)
2024-11-17 [email protected] Roll Flutter Engine from 9d0720a7b0ec to 4c1eb8cacb95 (1 revision) (flutter/flutter#159049)
2024-11-17 [email protected] Roll Flutter Engine from 6f9854ad6ed7 to 9d0720a7b0ec (2 revisions) (flutter/flutter#159047)
2024-11-17 [email protected] Roll Flutter Engine from 40000c742910 to 6f9854ad6ed7 (2 revisions) (flutter/flutter#159041)
2024-11-16 [email protected] Fix NavigationBar example overflow alignment (flutter/flutter#159034)
2024-11-16 [email protected] Roll Flutter Engine from 908061196148 to 40000c742910 (1 revision) (flutter/flutter#159038)
2024-11-16 [email protected] Roll Flutter Engine from 85d445e3cf78 to 908061196148 (3 revisions) (flutter/flutter#159032)
2024-11-16 [email protected] Roll Flutter Engine from 1800193ba961 to 85d445e3cf78 (1 revision) (flutter/flutter#159020)
2024-11-16 [email protected] Roll Flutter Engine from 98c3b7f8d1a7 to 1800193ba961 (1 revision) (flutter/flutter#159019)
2024-11-16 [email protected] Roll Flutter Engine from f23832175b7a to 98c3b7f8d1a7 (1 revision) (flutter/flutter#159017)
2024-11-16 [email protected] Roll Flutter Engine from f649330affa8 to f23832175b7a (1 revision) (flutter/flutter#159016)
2024-11-16 [email protected] Roll Flutter Engine from 619804c0fbb7 to f649330affa8 (47 revisions) (flutter/flutter#159015)
2024-11-16 [email protected] Marks Linux web_benchmarks_skwasm_st to be unflaky (flutter/flutter#158563)
2024-11-16 [email protected] Marks Windows windows_desktop_impeller to be unflaky (flutter/flutter#158565)
2024-11-15 [email protected] [flutter triage] Update list of frequent web contributors (flutter/flutter#159008)
2024-11-15 [email protected] Switch `flutter_build_apk_health_tests` to use a subset of current tests. (flutter/flutter#159004)
2024-11-15 [email protected] Make the focus node on SelectableRegion optional. (flutter/flutter#158994)
2024-11-15 [email protected] Style change in Flutter-Web-Triage.md (flutter/flutter#159006)
2024-11-15 [email protected] Refactor native asset integration into flutter tools (flutter/flutter#158932)
2024-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try running historically flaky tests first to make `flutter build apk` health tests time out more often? (#158967)" (flutter/flutter#158993)
2024-11-15 [email protected] [web] Remove the benchmarks of the HTML renderer (flutter/flutter#158520)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Dec 13, 2024
11 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants