[CP-beta]Adds a new helpful tool exit message for SocketExceptions thrown during mdns discovery #158950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng mdns discovery (flutter#157638) Addresses flutter#150131, but doesn't fix it, as there seem to be cases where the steps included in the messages added in this PR don't work.
Author
|
@LouiseHsu please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
tool
loic-sharma
approved these changes
Nov 14, 2024
christopherfujino
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/158950, Failed to enqueue flutter/flutter/158950 with HTTP 400: GraphQL mutate failed. |
auto-submit
bot
removed
the
autosubmit
christopherfujino
merged commit 32cb6f7
into
flutter:flutter-3.27-candidate.0
123 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…eptions thrown during mdns discovery (flutter/flutter#158950)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…eptions thrown during mdns discovery (flutter/flutter#158950)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#150131
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Suggest macOS Sequoia Local Network permissions instead of CLI tool SocketException crash.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
The app fatally crashes on
flutter run ioswith a non-actionable error.Workaround:
Is there a workaround for this issue?
The potential workarounds are listed in the error message added by this PR.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
It's hard to validate this PR because the original issue is hard to reproduce, but you can manually add a socket exception here
flutter/packages/flutter_tools/lib/src/mdns_discovery.dart
Lines 235 to 239 in 4b818b5
flutter run ios, and inspect the output.