Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab #15885

a-siva · 2018-03-23T23:00:09Z

Includes:

Make flutter_test on Mac exit on error like Linux and Windows. (Make flutter_test on Mac exit on error like Linux and Windows. engine#4873)
Revert "Fix vulkan include path (Fix vulkan include path engine#4870)" (Confusing that --debug builds have Release in their path? #4872)
Allow FirstFrameListeners to remove themselves from the FlutterView's list (Allow FirstFrameListeners to remove themselves from the FlutterView's list engine#4871)
Fix vulkan include path (Fix vulkan include path engine#4870)
Support for decimal and signed numeric keyboard (Support for decimal and signed numeric keyboard engine#4853)
CONTRIBUTING.md: explain the need for building host with non-host (CONTRIBUTING.md: explain the need for building host with non-host engine#4863
Roll Dart to 2f68e82526d59b679a522e25db224d8c7e23d280 (- roll Dart to 2f68e82526d59b679a522e25db224d8c7e23d280 engine#4864)
Remove declaration for undefined GPUSurfaceGL::SelectPixelConfig (Remove declaration for undefined GPUSurfaceGL::SelectPixelConfig engine#4857)
Vulkan swap chain setup no longer uses GrPixelConfig and doesn't incl…
Revert dart roll 20180322 (Revert dart roll 20180322 engine#4855)
Roll back pub upgrade. (Roll back pub upgrade. engine#4854)
Roll flutter 20180322a (Roll flutter 20180322a engine#4852)
Document Window.defaultRouteName a little better. (Document Window.defaultRouteName a little better. engine#4851)
Roll dart to 95e9e890a9 (Roll dart to 95e9e890a9 engine#4850)
Fix GPUSurfaceGL includes on Linux (Fix GPUSurfaceGL includes on Linux engine#4849)
Slightly improve the docs for the internal _futurize method (Slightly improve the docs for the internal _futurize method engine#4847)
Fix supported color type check on iOS simulators (Fix supported color type check on iOS simulators engine#4846)
Fix GPUSurfaceGL includes on macOS (Fix GPUSurfaceGL includes on macOS engine#4844)
Handle Apple-specific GLES headers (Handle Apple-specific GLES headers engine#4843)
[fuchsia] Fix up includes of Zircon headers ([fuchsia] Fix up includes of Zircon headers engine#4842)
VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig ( VulkanSurface and GPUSurfaceGL no longer use GrPixelConfig engine#4814)
Roll Skia (Roll Skia version to abf7b763e2c1ba069942dedec914494817fd27a8 engine#4841)
Provide asset lookup key on ios (Provide asset lookup key on iOS engine#4817)
Load kernel files from the script URI in the isolate create callback (Load kernel files from the script URI in the isolate create callback engine#4828)
Remove some unneeded profiling flags (Remove some unneeded profiling flags engine#4827)
Remove the canvas save/restore calls in Paragraph::Paint (Remove the canvas save/restore calls in Paragraph::Paint engine#4822)

the version just before the roll of Dart into the engine.

which contains a roll of Dart in it.

aam · 2018-03-24T04:57:25Z

Looks like few tests are failing

⏩ RUNNING: cd packages/flutter_driver; ../../bin/flutter test
00:00 +0: /home/travis/build/flutter/flutter sdk/packages/flutter_driver/test/flutter_driver_test.dart: FlutterDriver.connect connects to isolate paused at start
00:00 +0 -1: loading /home/travis/build/flutter/flutter sdk/packages/flutter_driver/test/src/extension_test.dart
00:00 +0 -1: /home/travis/build/flutter/flutter sdk/packages/flutter_driver/test/flutter_driver_test.dart: FlutterDriver.connect connects to isolate paused at start [E]
  type 'MockVM' is not a subtype of type 'Future<VM>' where
    MockVM is from file:///home/travis/build/flutter/flutter%20sdk/packages/flutter_driver/test/flutter_driver_test.dart
    Future is from dart:async
    VM is from package:vm_service_client/src/vm.dart
  
  package:vm_service_client/vm_service_client.dart      MockVMServiceClient.getVM
  package:flutter_driver/src/driver/driver.dart 165:32  FlutterDriver.connect

package.

in order to pick up the fix for engine exiting when an error is encountered reading a dart script.

This caused a test failure in the integration_ui_ios devicelab test. ``` stdout: [ +3 ms] 00:02 [32m+0[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size[0m stdout: [+8129 ms] 00:11 [32m+0[0m[31m -1[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size [1m[31m[E][0m[0m stdout: [ +5 ms] DriverError: Failed to fulfill Tap: Flutter application not responding stdout: [ ] Original error: TimeoutException after 0:00:07.500000: Future not completed stdout: [ ] Original stack trace: stdout: [ ] #0 FlutterDriver._sendCommand (package:flutter_driver/src/driver/driver.dart:324:18) stdout: [ ] stdout: [ ] flutter#1 FlutterDriver.tap (package:flutter_driver/src/driver/driver.dart:368:11) stdout: [ ] stdout: [ ] flutter#2 main.. (file:///[... snip ...]/flutter/dev/integration_tests/ui/test_driver/keyboard_resize_test.dart:34:20) ``` This reverts commit 067be92.

This caused a test failure in the integration_ui_ios devicelab test. ``` stdout: [ +3 ms] 00:02 [32m+0[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size[0m stdout: [+8129 ms] 00:11 [32m+0[0m[31m -1[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size [1m[31m[E][0m[0m stdout: [ +5 ms] DriverError: Failed to fulfill Tap: Flutter application not responding stdout: [ ] Original error: TimeoutException after 0:00:07.500000: Future not completed stdout: [ ] Original stack trace: stdout: [ ] #0 FlutterDriver._sendCommand (package:flutter_driver/src/driver/driver.dart:324:18) stdout: [ ] stdout: [ ] #1 FlutterDriver.tap (package:flutter_driver/src/driver/driver.dart:368:11) stdout: [ ] stdout: [ ] #2 main.. (file:///[... snip ...]/flutter/dev/integration_tests/ui/test_driver/keyboard_resize_test.dart:34:20) ``` This reverts commit 067be92.

Roll engine to version dd6f46c

This caused a test failure in the integration_ui_ios devicelab test. ``` stdout: [ +3 ms] 00:02 [32m+0[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size[0m stdout: [+8129 ms] 00:11 [32m+0[0m[31m -1[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size [1m[31m[E][0m[0m stdout: [ +5 ms] DriverError: Failed to fulfill Tap: Flutter application not responding stdout: [ ] Original error: TimeoutException after 0:00:07.500000: Future not completed stdout: [ ] Original stack trace: stdout: [ ] #0 FlutterDriver._sendCommand (package:flutter_driver/src/driver/driver.dart:324:18) stdout: [ ] stdout: [ ] flutter#1 FlutterDriver.tap (package:flutter_driver/src/driver/driver.dart:368:11) stdout: [ ] stdout: [ ] flutter#2 main.. (file:///[... snip ...]/flutter/dev/integration_tests/ui/test_driver/keyboard_resize_test.dart:34:20) ``` This reverts commit 067be92.

First roll engine version to 3e877d3

3162410

the version just before the roll of Dart into the engine.

googlebot added the cla: yes label Mar 23, 2018

Roll engine version to e622bd9

e94117a

which contains a roll of Dart in it.

a-siva force-pushed the rollengine branch from e751113 to e94117a Compare March 23, 2018 23:40

a-siva changed the title ~~Roll engine to version 6280adbfb1f9f63cdc6179b9b78634add1e4f2e3~~ Roll engine to version e622bd93c902a308788c28f3637325154b9e9cc4 Mar 23, 2018

Merge branch 'master' of github.com:flutter/flutter into rollengine

a387b2b

a-siva requested a review from aam March 24, 2018 03:56

Fix some strong mode errors.

980e18f

aam mentioned this pull request Mar 26, 2018

Crash doing full restart that spawns an isolate #15894

Closed

aam approved these changes Mar 26, 2018

View reviewed changes

a-siva added 3 commits March 26, 2018 10:48

Fix analyzer warning.

633493e

Correctly fix analyzer warning.

3f49a48

Fix more strong mode errors resulting from the use of the mockito

ac5d685

package.

tvolkert approved these changes Mar 26, 2018

View reviewed changes

Updated engine version to dd6f46c

0364b34

in order to pick up the fix for engine exiting when an error is encountered reading a dart script.

a-siva changed the title ~~Roll engine to version e622bd93c902a308788c28f3637325154b9e9cc4~~ Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab Mar 27, 2018

a-siva merged commit 067be92 into flutter:master Mar 27, 2018

a-siva deleted the rollengine branch March 27, 2018 05:16

cbracken mentioned this pull request Mar 27, 2018

Revert "Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9… #15980

Merged

cbracken mentioned this pull request Mar 27, 2018

Apply Mockito-related type fixes #16002

Merged

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018

Roll engine to version dd6f46c (flutter#15885)

d581f77

Roll engine to version dd6f46c

github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab #15885

Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab #15885

Uh oh!

a-siva commented Mar 23, 2018 •

edited by cbracken

Loading

Uh oh!

aam commented Mar 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab #15885

Roll engine to version dd6f46c485192f4506035088c9065b9f5dbba9ab #15885

Uh oh!

Conversation

a-siva commented Mar 23, 2018 • edited by cbracken Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aam commented Mar 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

a-siva commented Mar 23, 2018 •

edited by cbracken

Loading