Remove tear-off mocking in refresh_test #15869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC @xster |
Contributor
Author
|
CC @aam |
Member
|
LG! |
aam
approved these changes
Mar 23, 2018
Contributor
Author
|
Learning things. This PR breaks compatibility with Dart 1 mode. Working on a fix that works in both modes. |
Member
|
Still LG. Thanks for figuring it out! |
Contributor
Author
|
Green Travis. Go for it! |
Contributor
Author
|
Someone with write access should totally merge this PR 😁 😁 😁 |
Member
|
Didn't realize you can't submit it, @srawlins . |
Member
|
AppVeyor completed, ready to be submitted as soon as flutter-build turns green. |
Contributor
|
Can we submit this PR. |
Member
|
Please go ahead
…On Fri, Mar 23, 2018, 5:38 PM Siva ***@***.***> wrote:
Can we submit this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15869 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXQ0XtOoBcFCcFJG_h8lmJCeYmN-KTlks5thZWEgaJpZM4S5HgB>
.
|
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Remove tear-off mocking in refresh_test * Comments * Analyzer fix * Final final final final mushroom mushroom! * Fix for Dart 1 AND Dart 2 semantics; anonymous closure over tear-off * Final final
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15849.
In Dart 2 semantics (so far...) Mock objects cannot have their methods torn off as a part of mocking.
Related to dart-lang/mockito#107.