Reland Add test for dynamic_content_color.0.dart #158547

ValentinVignal · 2024-11-13T01:46:25Z

Fixes #130459

Follow up of the reverted #158309

It adds a test for

examples/api/lib/material/color_scheme/dynamic_content_color.0.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

Nice!

Because this example is somewhat complex, consider introducing several tests.
See my comment about factoring out the fake loader.

First test is the one you have (just removed the last step).
Second test would be the end of your test (switching brightness).
Third test would simulate selecting the second image and checking the color scheme has changed.

bleroux · 2024-11-13T06:49:55Z

examples/api/test/material/color_scheme/dynamic_content_color.0_test.dart

+
+  testWidgets('The theme colors are created dynamically from the first image', (WidgetTester tester) async {
+    final List<(ImageProvider<Object>, Brightness)> loadColorSchemeCalls = <(ImageProvider<Object>, Brightness)>[];
+    await tester.pumpWidget(
+      example.DynamicColorExample(
+        loadColorScheme: (ImageProvider<Object> provider, Brightness brightness) async {
+          loadColorSchemeCalls.add((provider, brightness));
+          return const ColorScheme.light();
+        },
+      ),
+    );
+    await tester.pump();


Suggested change

testWidgets('The theme colors are created dynamically from the first image', (WidgetTester tester) async {

final List<(ImageProvider<Object>, Brightness)> loadColorSchemeCalls = <(ImageProvider<Object>, Brightness)>[];

await tester.pumpWidget(

example.DynamicColorExample(

loadColorScheme: (ImageProvider<Object> provider, Brightness brightness) async {

loadColorSchemeCalls.add((provider, brightness));

return const ColorScheme.light();

},

),

);

await tester.pump();

final List<(ImageProvider<Object>, Brightness)> loadColorSchemeCalls = <(ImageProvider<Object>, Brightness)>[];

Future<ColorScheme> fakeColorSchemeLoader(ImageProvider<Object> provider, Brightness brightness) async {

loadColorSchemeCalls.add((provider, brightness));

return provider == example.DynamicColorExample.images[1]

? ColorScheme.fromSeed(seedColor: Colors.lightBlue)

: const ColorScheme.light();

}

setUp(() {

loadColorSchemeCalls.clear();

});

testWidgets('The theme colors are created dynamically from the first image', (WidgetTester tester) async {

await tester.pumpWidget(

example.DynamicColorExample(loadColorScheme: fakeColorSchemeLoader),

);

await tester.pump();

Proposed way to share the fake loader between several tests.

bleroux · 2024-11-13T06:53:46Z

examples/api/test/material/color_scheme/dynamic_content_color.0_test.dart

+      Brightness.light,
+    );
+
+    await tester.tap(find.byType(Switch));


Starting there, it could be more readable to start a new test, maybe named 'Brightness can be changed'
(the content should be updated because the list containing calls is cleared between tests).

ValentinVignal · 2024-11-13T15:29:56Z

Nice suggestions @bleroux ! I've done the changes in test: More detailed tests, hope it is good enough :)

bleroux

Almost ready, see my comments

bleroux · 2024-11-13T15:56:45Z

examples/api/test/material/color_scheme/dynamic_content_color.0_test.dart

+    expect(
+      loadColorSchemeCalls.single.$1,
+      isA<NetworkImage>()
+        .having(
+          (NetworkImage provider) => provider.url,
+          'url',
+          'https://flutter.github.io/assets-for-api-docs/assets/material/content_based_color_scheme_1.png',
+        ),
+    );
+    expect(
+      loadColorSchemeCalls.single.$2,
+      Brightness.light,
+    );


Maybe make the test shorter by removing those lines as it was already tested on the other test and it is not what this test focus on.

bleroux · 2024-11-13T15:57:25Z

examples/api/test/material/color_scheme/dynamic_content_color.0_test.dart

+      loadColorSchemeCalls.last.$2,
+      Brightness.light,
+    );
+


Is there a way to check the app color scheme is the new one?

bleroux

Congratulations for finishing this missing example tests task 🙏

…tter#158547)

Roll Flutter from ed553d1 to 0e2d55e (40 revisions) flutter/flutter@ed553d1...0e2d55e 2024-11-15 [email protected] Roll Packages from b9ac917 to b164be3 (4 revisions) (flutter/flutter#158986) 2024-11-15 [email protected] Label PRs with gradle and Android paths "platform-android" (flutter/flutter#158970) 2024-11-15 [email protected] Fix code asset copying logic in native asset code (flutter/flutter#158984) 2024-11-15 [email protected] Fix duplicate work in native assets release builds (flutter/flutter#158980) 2024-11-15 [email protected] Stop generate both `.kts` and non-`.kts` gradle files for a test project. (flutter/flutter#158965) 2024-11-15 [email protected] Further skip `native_assets_test`(s) that runs `flutter build apk`. (flutter/flutter#158966) 2024-11-15 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/flutter#157473) 2024-11-15 [email protected] Try running historically flaky tests first to make `flutter build apk` health tests time out more often? (flutter/flutter#158967) 2024-11-15 [email protected] [ tool ] Don't throw StateError when DDS fails to start (flutter/flutter#158744) 2024-11-14 [email protected] Create merge_queue.md (flutter/flutter#158959) 2024-11-14 [email protected] Marks Mac_x64 hot_mode_dev_cycle_macos_target__benchmark to be flaky (flutter/flutter#158569) 2024-11-14 [email protected] Marks Mac_arm64 mac_desktop_impeller to be unflaky (flutter/flutter#158564) 2024-11-14 [email protected] [gen_l10n] When localizing a message, prefer placeholder definitions defined by the current locale rather than the template locale (flutter/flutter#153459) 2024-11-14 [email protected] feat: Include web 1.x.x in plugin template (flutter/flutter#156947) 2024-11-14 [email protected] hide members where possible (flutter/flutter#158492) 2024-11-14 [email protected] Move platform-specific log-reading implementation details from `ResidentRunner`/`FlutterDevice` to `DeviceLogReader` implementations (flutter/flutter#156181) 2024-11-14 [email protected] Updated document to clarify Clip Behaviour (flutter/flutter#157719) 2024-11-14 [email protected] Enable --verbose for android_plugin_skip_unsupported_test tests (flutter/flutter#158933) 2024-11-14 [email protected] Roll Packages from 26e123a to b9ac917 (5 revisions) (flutter/flutter#158938) 2024-11-14 [email protected] Add `dev_dependency` attribute to plugins in `.flutter-plugins-dependencies` (flutter/flutter#158009) 2024-11-14 [email protected] No longer pass `--verbose` to implicit `pub` calls when `flutter --verbose` is set. (flutter/flutter#158898) 2024-11-14 [email protected] Update triage flow chart for SVG packages (flutter/flutter#158670) 2024-11-14 [email protected] Add one MenuAnchor alignment test (flutter/flutter#158915) 2024-11-14 [email protected] Reland Add test for dynamic_content_color.0.dart (flutter/flutter#158547) 2024-11-14 [email protected] Roll Flutter Engine from e97b148e796d to 619804c0fbb7 (1 revision) (flutter/flutter#158905) 2024-11-14 [email protected] Roll Flutter Engine from 82940a9aa714 to e97b148e796d (1 revision) (flutter/flutter#158901) 2024-11-14 [email protected] Move explicit package dependencies to a feature flag (flutter/flutter#158016) 2024-11-14 [email protected] Try with `bringup: true` debugging why `flutter build apk` often times out. (flutter/flutter#158895) 2024-11-14 [email protected] Add constraint options to `SearchAnchor` suggestions builder (flutter/flutter#148856) 2024-11-14 [email protected] Adjusts the Hindi TimeOfDayFormat to display in a LTR orientation in localizations. (flutter/flutter#157998) 2024-11-14 [email protected] Fix update order of SliverAppBar (flutter/flutter#158159) 2024-11-13 [email protected] #154792 - CupertinoActionSheetAction cursor doesn't change to clickable on desktop (flutter/flutter#158470) 2024-11-13 [email protected] Adds a skip message for analyzer (flutter/flutter#158890) 2024-11-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Marks Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark to be flaky (#158242)" (flutter/flutter#158891) 2024-11-13 [email protected] [SwiftPM] Move the logic for SwiftPM enablement to the platform project (flutter/flutter#158213) 2024-11-13 [email protected] Temporarily skip flutter build apk for native_assets tests. (flutter/flutter#158880) 2024-11-13 [email protected] docs: include Human Interface haptic information in HapticFeedback (flutter/flutter#158587) 2024-11-13 [email protected] Roll Flutter Engine from db3e5af2ca22 to 82940a9aa714 (2 revisions) (flutter/flutter#158799) 2024-11-13 [email protected] Stream the output of `flutter build` for debugging. (flutter/flutter#158757) 2024-11-13 [email protected] "Fix failing checks" wiki page for new contributors (flutter/flutter#154629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…tter#158547)

ValentinVignal requested a review from bleroux November 13, 2024 01:46

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 13, 2024

bleroux reviewed Nov 13, 2024

View reviewed changes

ValentinVignal requested a review from bleroux November 14, 2024 02:06

ValentinVignal added 3 commits November 14, 2024 10:54

test: Add test for dynamic_content_color.0.dart

58399a7

test: More detailed tests

0853adf

test: Better tests by evaluating the color scheme

03b1bd1

ValentinVignal force-pushed the flutter/examples/api/Reland-test-for-dynamic-color-content branch from aac7e2c to 03b1bd1 Compare November 14, 2024 02:54

bleroux approved these changes Nov 14, 2024

View reviewed changes

ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2024

auto-submit bot merged commit c1ee381 into flutter:master Nov 14, 2024
154 checks passed

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2024

engine-flutter-autoroll mentioned this pull request Nov 14, 2024

Roll Flutter from ed553d10cf63 to 8f62a9904da0 (19 revisions) flutter/packages#8082

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2024

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

5e716e9

…tter#158547)

engine-flutter-autoroll mentioned this pull request Nov 14, 2024

Roll Flutter from ed553d10cf63 to 752ac20f8755 (20 revisions) flutter/packages#8083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2024

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

233d67e

…tter#158547)

engine-flutter-autoroll mentioned this pull request Nov 14, 2024

Roll Flutter from ed553d10cf63 to 46a41585ebb0 (21 revisions) flutter/packages#8085

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2024

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

2f7a234

…tter#158547)

engine-flutter-autoroll mentioned this pull request Nov 14, 2024

Roll Flutter from ed553d10cf63 to e40306f92f0c (23 revisions) flutter/packages#8086

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2024

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

d04d377

…tter#158547)

engine-flutter-autoroll mentioned this pull request Nov 15, 2024

Roll Flutter from ed553d10cf63 to 256359194e2b (37 revisions) flutter/packages#8104

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2024

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

07b4f3c

…tter#158547)

engine-flutter-autoroll mentioned this pull request Nov 15, 2024

Roll Flutter from ed553d10cf63 to c4c8f6d2bd79 (39 revisions) flutter/packages#8105

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2024

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

488f40a

…tter#158547)

engine-flutter-autoroll mentioned this pull request Nov 15, 2024

Roll Flutter from ed553d10cf63 to 0e2d55e0e7b2 (40 revisions) flutter/packages#8106

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2024

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

26026b9

…tter#158547)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

d5e175f

…tter#158547)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

1508552

…tter#158547)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

3bd2372

…tter#158547)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

255b25b

…tter#158547)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

c1ee381 Reland Add test for dynamic_content_color.0.dart (flutter/flu…

87d6d9b

…tter#158547)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland Add test for dynamic_content_color.0.dart #158547

Reland Add test for dynamic_content_color.0.dart #158547

Uh oh!

ValentinVignal commented Nov 13, 2024

Uh oh!

bleroux left a comment •

edited

Loading

Uh oh!

bleroux Nov 13, 2024

Uh oh!

bleroux Nov 13, 2024

Uh oh!

ValentinVignal commented Nov 13, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux Nov 13, 2024

Uh oh!

bleroux Nov 13, 2024

Uh oh!

bleroux left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reland Add test for dynamic_content_color.0.dart #158547

Reland Add test for dynamic_content_color.0.dart #158547

Uh oh!

Conversation

ValentinVignal commented Nov 13, 2024

Pre-launch Checklist

Uh oh!

bleroux left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Nov 13, 2024

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bleroux left a comment •

edited

Loading