Skip to content

Increase Java heap limit to 8GB for plugin integration tests using deferred components #158330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bkonyi merged 1 commit into from
Nov 7, 2024
Merged

Increase Java heap limit to 8GB for plugin integration tests using deferred components #158330

bkonyi merged 1 commit into from
Nov 7, 2024

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Nov 7, 2024

Should help resolve #156953

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 7, 2024
@reidbaker
Copy link
Contributor

reidbaker commented Nov 7, 2024

I think this is correct but am leaving a breadcrumb for myself. If it turns out this issue is actually about the number/length of command line args then GRADLE_OPS documented in https://docs.gradle.org/current/userguide/build_environment.html is the right next place to expand.

christopherfujino
christopherfujino reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I grep -rnI 'Xmx4G', I get a lot of hits. Should we just mass update them all?

@christopherfujino
Copy link
Contributor

christopherfujino commented Nov 7, 2024

Also, per flutter-pub-roller-bot@225e4aa, should we bump the MaxMetaspaceSize and add a flag for ReservedCodeCacheSize?

I'm genuinely asking. I don't understand any of these, and going into swap would be bad too, maybe worse since it's be hard to detect?

@reidbaker
Copy link
Contributor

reidbaker commented Nov 7, 2024

When I grep -rnI 'Xmx4G', I get a lot of hits. Should we just mass update them all?

I dont think we should update all of the heap sizes. Lets see if this helps. 4 gigs is really big

@christopherfujino
Copy link
Contributor

christopherfujino commented Nov 7, 2024

When I grep -rnI 'Xmx4G', I get a lot of hits. Should we just mass update them all?

I dont think we should update all of the heap sizes. Lets see if this helps. 4 gigs is really big

I agree that 4gb is REALLY big. I'm not happy about upping this. I also have no better idea...

@christopherfujino
Copy link
Contributor

christopherfujino commented Nov 7, 2024

When I grep -rnI 'Xmx4G', I get a lot of hits. Should we just mass update them all?

I dont think we should update all of the heap sizes. Lets see if this helps. 4 gigs is really big

I'm ok with updating just this one app.

@bkonyi
Copy link
Contributor Author

bkonyi commented Nov 7, 2024

Yeah, I'm not happy with it either but... shrugs

@reidbaker should we also update MaxMetaspaceSize and ReservedCodeCacheSize as @christopherfujino suggested?

@reidbaker
Copy link
Contributor

reidbaker commented Nov 7, 2024

My gut its that we should only update the ones we think will do something.
https://stackoverflow.com/questions/31455644/should-i-set-a-maxmetaspacesize indicates that the cost of bumping that value is proably low.

From https://stackoverflow.com/questions/7513185/what-are-reservedcodecachesize-and-initialcodecachesize we are not seeing the logs that would have me think that value would help. Honestly I wonder if dropping these memory settings to nothing might be a better solution.

FWIW I dont expect bumping to 8 gb will help but I dont have better solutions for you.

@bkonyi bkonyi merged commit 998f42a into master Nov 7, 2024
132 checks passed
@bkonyi bkonyi deleted the fix_java_heap_error branch November 7, 2024 20:24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 8, 2024
@engine-flutter-autoroll
998f42a Increase Java heap limit to 8GB for plugin integration tests …
80ae634 
…using deferred components (flutter/flutter#158330)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 8, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 8, 2024
@engine-flutter-autoroll
998f42a Increase Java heap limit to 8GB for plugin integration tests …
ca8ad28 
…using deferred components (flutter/flutter#158330)
@bkonyi bkonyi mentioned this pull request Nov 8, 2024
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 11, 2024
@engine-flutter-autoroll
Roll Flutter from 73546b3 to c8510f2 (30 revisions) (#8042)
3663103 
flutter/flutter@73546b3...c8510f2

2024-11-08 [email protected] Roll Flutter Engine from 44d788f4651b to a08bd5a07c2a (3 revisions) (flutter/flutter#158375)
2024-11-08 [email protected] Add ability to override `NavigationDestination.label` padding for `NavigationBar` (flutter/flutter#158260)
2024-11-08 [email protected] Add flutter/package code generation instructions (flutter/flutter#158326)
2024-11-08 [email protected] Roll Flutter Engine from 8e19915c19fc to 44d788f4651b (3 revisions) (flutter/flutter#158362)
2024-11-08 [email protected] Roll Flutter Engine from bcb281cde579 to 8e19915c19fc (4 revisions) (flutter/flutter#158354)
2024-11-07 [email protected] Make `_SelectableRegionSelectionContainerDelegate` public (flutter/flutter#147080)
2024-11-07 [email protected] Manual roll Flutter Engine from 371c86fb6b49 to bcb281cde579 (flutter/flutter#158346)
2024-11-07 [email protected] Add clarification on review timelines in PR template (flutter/flutter#158345)
2024-11-07 [email protected] Increase Java heap limit to 8GB for plugin integration tests using deferred components (flutter/flutter#158330)
2024-11-07 [email protected] Roll pub packages (flutter/flutter#158337)
2024-11-07 [email protected] Roll Flutter Engine from ac50b20ae5c9 to 371c86fb6b49 (5 revisions) (flutter/flutter#158336)
2024-11-07 [email protected] Fix a breakage caused by the test being unskipped. (flutter/flutter#158335)
2024-11-07 [email protected] Roll Flutter Engine from 8a963cfc134c to ac50b20ae5c9 (1 revision) (flutter/flutter#158308)
2024-11-07 [email protected] `Plugin.isDevDependency` if exclusively in `dev_dependencies` (flutter/flutter#157462)
2024-11-07 [email protected] Add recently imported packages to issue template (flutter/flutter#158324)
2024-11-07 [email protected] Roll Flutter Engine from 076688d95818 to 8a963cfc134c (1 revision) (flutter/flutter#158304)
2024-11-07 [email protected] Roll Flutter Engine from 94dac953a95f to 076688d95818 (2 revisions) (flutter/flutter#158303)
2024-11-07 [email protected] Make leak tracking bots blocking. (flutter/flutter#157866)
2024-11-07 [email protected] Roll Flutter Engine from b36ca3319825 to 94dac953a95f (1 revision) (flutter/flutter#158297)
2024-11-06 [email protected] Roll Flutter Engine from 58ac1dadd69d to b36ca3319825 (9 revisions) (flutter/flutter#158295)
2024-11-06 [email protected] Added cusor control properties to CupertinoSearchTextField and tests (flutter/flutter#158240)
2024-11-06 [email protected] Fix flakiness in hot_reload_test.dart (flutter/flutter#158271)
2024-11-06 [email protected] Fix use of deprecated `buildDir` in Android templates/tests/examples (flutter/flutter#157560)
2024-11-06 [email protected] Roll Flutter Engine from f03f11300a9d to 58ac1dadd69d (5 revisions) (flutter/flutter#158283)
2024-11-06 [email protected] Roll pub packages (flutter/flutter#158281)
2024-11-06 [email protected] Delete firebase_android_embedding_v2_smoke_test (flutter/flutter#158223)
2024-11-06 [email protected] [web] fix --ab option for web benchmarks (flutter/flutter#154574)
2024-11-06 [email protected] excluding website-cms from critical pr triage (flutter/flutter#158220)
2024-11-06 [email protected] Add test for `image.frame_builder.0.dart` (flutter/flutter#158247)
2024-11-06 [email protected] Roll Packages from 7219431 to bb5a258 (6 revisions) (flutter/flutter#158267)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
998f42a Increase Java heap limit to 8GB for plugin integration tests …
b10d954 
…using deferred components (flutter/flutter#158330)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
998f42a Increase Java heap limit to 8GB for plugin integration tests …
643216e 
…using deferred components (flutter/flutter#158330)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
998f42a Increase Java heap limit to 8GB for plugin integration tests …
27275ba 
…using deferred components (flutter/flutter#158330)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
998f42a Increase Java heap limit to 8GB for plugin integration tests …
ec376df 
…using deferred components (flutter/flutter#158330)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
998f42a Increase Java heap limit to 8GB for plugin integration tests …
9b8d9c8 
…using deferred components (flutter/flutter#158330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows tool_integration_tests_2_9 is 3.00% flaky

3 participants

@bkonyi @reidbaker @christopherfujino